Re: [PATCH] Detached HEAD (experimental)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Tuesday, January 2, 2007 - 3:44 pm

Carl Worth <cworth@cworth.org> writes:


I am not saying being risky is useful.  That's why I said it is
experimental.

We could do two things, and I think disallowing commits is not
necessarily a better option of the two.  We could allow commits
and prevent the user from switching out of the detached HEAD
state without an explicit action instead.  If we go the first
route, you need to also prevent merges into the detached HEAD.
If we go the latter I think you only need to add a check in
"git-checkout" but there may be other cases.  In either way, we
need a safety valve, which the experimental code does not have.

And being able to merge into the detached HEAD turns out to be
somewhat useful.  I checked out the v1.4.4.3 and tried to see if
a topic is applicable by merging into that detached HEAD and
running testsuite.  Of course, without any safety valve, I can
easily lose the merge result by switching out of the detached
HEAD state (say, "git checkout master"), but on the other hand,
creating a new branch at that point with "git checkout -b
v1.4.4.3-maint" would let me continue from that point without
losing anything.

But this is only "somewhat" -- I do not have strong opinion
either way, other than that we need a safety valve (which we
agree).

In any case, I did this because I got tired of waiting for it to
happen (I thought you wanted to hack on this over the long
week^W yearend, so I deliberately stayed away from doing this)
and I was bored.  This will not be in 'next' in the current
shape.

You've thought about the issue long enough to write your
commentary and I agree to most of your points (including
favoring "no commit allowed in this state" over "allow commits
and merges to help advanced usage" for its simplicity), so if
you code it up with a clean patch, I would not reject it on the
basis of its design.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Detached HEAD (experimental), Junio C Hamano, (Tue Jan 2, 12:45 am)
Re: [PATCH] Detached HEAD (experimental), Edgar Toernig, (Tue Jan 2, 12:59 pm)
Re: [PATCH] Detached HEAD (experimental), Carl Worth, (Tue Jan 2, 2:56 pm)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Tue Jan 2, 3:44 pm)
[PATCH] git-branch: show detached HEAD, Lars Hjemli, (Tue Jan 2, 4:22 pm)
Re: [PATCH] Detached HEAD (experimental), Carl Worth, (Tue Jan 2, 4:34 pm)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Tue Jan 2, 7:45 pm)
Re: [PATCH] git-branch: show detached HEAD, Shawn O. Pearce, (Tue Jan 2, 10:18 pm)
Re: [PATCH] git-branch: show detached HEAD, Junio C Hamano, (Wed Jan 3, 12:05 am)
Re: [PATCH] git-branch: show detached HEAD, Lars Hjemli, (Wed Jan 3, 12:37 am)
Re: [PATCH] Detached HEAD (experimental), Jeff King, (Wed Jan 3, 3:46 am)
Re: [PATCH] Detached HEAD (experimental), Jeff King, (Wed Jan 3, 4:59 am)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Mon Jan 8, 4:19 am)
Re: [PATCH] Detached HEAD (experimental), Jeff King, (Mon Jan 8, 6:17 am)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Mon Jan 8, 5:19 pm)
Re: [PATCH] Detached HEAD (experimental), Carl Worth, (Mon Jan 8, 5:43 pm)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Mon Jan 8, 6:05 pm)
Re: [PATCH] Detached HEAD (experimental), Carl Worth, (Mon Jan 8, 6:15 pm)
Re: [PATCH] Detached HEAD (experimental), Shawn O. Pearce, (Mon Jan 8, 8:26 pm)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Tue Jan 9, 12:07 am)
Re: [PATCH] Detached HEAD (experimental), Luben Tuikov, (Tue Jan 9, 1:12 am)
Re: [PATCH] Detached HEAD (experimental), Jeff King, (Tue Jan 9, 7:21 am)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Tue Jan 9, 2:20 pm)
Re: [PATCH] Detached HEAD (experimental), J. Bruce Fields, (Tue Jan 9, 2:31 pm)
Re: [PATCH] Detached HEAD (experimental), Carl Worth, (Tue Jan 9, 2:43 pm)
Re: [PATCH] Detached HEAD (experimental), J. Bruce Fields, (Tue Jan 9, 2:53 pm)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Tue Jan 9, 3:37 pm)
Re: [PATCH] Detached HEAD (experimental), Shawn O. Pearce, (Tue Jan 9, 4:39 pm)
Re: [PATCH] Detached HEAD (experimental), Shawn O. Pearce, (Tue Jan 9, 4:44 pm)
Re: [PATCH] Detached HEAD (experimental), Linus Torvalds, (Tue Jan 9, 4:46 pm)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Tue Jan 9, 5:10 pm)
Re: [PATCH] Detached HEAD (experimental), Shawn O. Pearce, (Tue Jan 9, 5:18 pm)
Re: [PATCH] Detached HEAD (experimental), Carl Worth, (Tue Jan 9, 5:51 pm)
Re: [PATCH] Detached HEAD (experimental), Linus Torvalds, (Tue Jan 9, 5:54 pm)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Wed Jan 10, 1:02 am)
Re: [PATCH] Detached HEAD (experimental), Andy Parkins, (Wed Jan 10, 2:04 am)
Re: [PATCH] Detached HEAD (experimental), Shawn O. Pearce, (Wed Jan 10, 2:05 am)
Re: [PATCH] Detached HEAD (experimental), Andreas Ericsson, (Wed Jan 10, 2:08 am)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Wed Jan 10, 2:33 am)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Wed Jan 10, 2:40 am)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Wed Jan 10, 2:46 am)
Re: [PATCH] Detached HEAD (experimental), Andy Parkins, (Wed Jan 10, 3:10 am)
Re: [PATCH] Detached HEAD (experimental), Shawn O. Pearce, (Wed Jan 10, 3:25 am)
Re: [PATCH] Detached HEAD (experimental), Jeff King, (Wed Jan 10, 7:04 am)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Wed Jan 10, 9:18 am)
Re: [PATCH] Detached HEAD (experimental), Daniel Barkalow, (Wed Jan 10, 9:30 am)
Re: [PATCH] Detached HEAD (experimental), Junio C Hamano, (Wed Jan 10, 5:34 pm)
Re: [PATCH] Detached HEAD (experimental), J. Bruce Fields, (Wed Jan 10, 9:31 pm)
Re: [PATCH] Detached HEAD (experimental), Andreas Ericsson, (Thu Jan 11, 2:45 am)