git mailing list

FromSubjectsort iconDate
Junio C Hamano
Re: git and time
The more I think about this, if we were to add yet another command, I think it should be a command that lets us inspect ref-log. We do not have an UI other than @{time} syntax to interact with it right now. What are the things we would want? Here is a strawman. - List when and how a branch was changed. git ref-log --list --type=merge next (when did I merge into my 'next'?) git ref-log --list --type=merge (ditto but any branches) git ref-log --list next (any changes not just ...
Sep 29, 3:27 pm 2006
Junio C Hamano
Re: [PATCH] gitweb: start to generate PATH_INFO URLs
Supporting PATH_INFO in the sense that we do sensible things when we get called with one is one thing, but generating such a URL that uses PATH_INFO is a different thing. I suspect not everybody's webserver is configured to call us with PATH_INFO, so this should be conditional. -
Sep 29, 3:30 pm 2006
Martin Waitz
[PATCH] gitweb: start to generate PATH_INFO URLs
Instead of providing the project as a ?p= parameter it is simply appended to the base URI. All other parameters are appended to that, except for ?a=summary which is the default and can be omitted. Signed-off-by: Martin Waitz <tali@admingilde.org> --- gitweb/gitweb.perl | 15 ++++++++++++++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 597d29f..e507ce9 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -355,6 ...
Sep 29, 3:16 pm 2006
Junio C Hamano
Re: [PATCH 0/5] fetch & co: misc output cleanup
A Large Angry SCM <gitzilla@gmail.com> writes: > Santi B
Sep 29, 2:27 pm 2006
Johannes Schindelin
kernel.org problems?
Hi, when I try fetching from kernel.org, I get fatal: read error (Connection reset by peer) Fetch failure: git://git.kernel.org/pub/scm/git/git.git all the time. Fetching by HTTP instead of git protocol works fine, though. What is happening? Ciao, Dscho -
Sep 29, 11:37 am 2006
sbejar
[PATCH 4/5] fetch: Add output for the not fast forward case
Use the ... notation to be able to use this directly in "git log" to see how the two non-fast-forward heads have diverged. Signed-off-by: Santi Béjar <sbejar@gmail.com> --- git-fetch.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/git-fetch.sh b/git-fetch.sh index 32553f8..ee4f5bd 100755 --- a/git-fetch.sh +++ b/git-fetch.sh @@ -190,6 +190,7 @@ fast_forward_local () { ;; esac || { echo >&2 "* $1: does not fast forward to $3;" + echo >&2 " ...
Sep 29, 11:07 am 2006
sbejar
[PATCH 0/5] fetch & co: misc output cleanup
Hi *, this patchset includes: fetch: Reset remote refs list each time fetch_main is called fetch & co: Use "hash1..hash2" instead of "from hash1 to hash2" fetch & co: Use short sha1 in the output fetch: Add output for the not fast forward case fetch: Clean output The first one is actually a bugfix (at least for me), but needed for the last one. git-fetch.sh | 19 ++++++++++++++----- git-merge.sh | 2 +- git-resolve.sh | 2 +- 3 files ...
Sep 29, 11:05 am 2006
Junio C Hamano Sep 29, 7:17 pm 2006
Santi
Re: [PATCH 0/5] fetch & co: misc output cleanup
2006/9/29, A Large Angry SCM <gitzilla@gmail.com>: > Santi B
Sep 29, 1:48 pm 2006
sbejar
[PATCH 1/5] fetch: Reset remote refs list each time fetc ...
This prevents the fetch of the heads again in the second call of fetch_main. Signed-off-by: Santi Béjar <sbejar@gmail.com> --- git-fetch.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/git-fetch.sh b/git-fetch.sh index bcc67ab..f1522bd 100755 --- a/git-fetch.sh +++ b/git-fetch.sh @@ -257,6 +257,7 @@ fi fetch_main () { reflist="$1" refs= + rref= for ref in $reflist do -- 1.4.2.1.g38049 -
Sep 29, 11:05 am 2006
A Large Angry SCM Sep 29, 11:54 am 2006
sbejar
[PATCH 2/5] fetch & co: Use "hash1..hash2" instead of "f ...
I find it shorter, easier to copy&paste and cleaner. Signed-off-by: Santi Béjar <sbejar@gmail.com> --- git-fetch.sh | 2 +- git-merge.sh | 2 +- git-resolve.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/git-fetch.sh b/git-fetch.sh index f1522bd..08d86cd 100755 --- a/git-fetch.sh +++ b/git-fetch.sh @@ -182,7 +182,7 @@ fast_forward_local () { ;; *,$local) echo >&2 "* $1: fast forward to $3" - echo >&2 " from $local to $2" + echo ...
Sep 29, 11:06 am 2006
sbejar
[PATCH 5/5] fetch: Clean output
Do not show duplicated remote branch information and reformat the output as: $ git fetch -v # the committish lines for the -v. * refs/heads/origin: fast forward to remote branch 'master' of ../git/ 1ad7a06..bc1a580 committish: bc1a580 * refs/heads/pu: does not fast forward to remote branch 'pu' of ../git/; 7c733a8...5faa935 not updating. forcing update. committish: 5faa935 * refs/heads/next: same as remote branch 'origin/next' of ../git/ committish: ce47b9f ... * ...
Sep 29, 11:08 am 2006
sbejar
[PATCH 3/5] fetch & co: Use short sha1 in the output
... for brevity. Signed-off-by: Santi Béjar <sbejar@gmail.com> --- git-fetch.sh | 6 +++--- git-merge.sh | 2 +- git-resolve.sh | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/git-fetch.sh b/git-fetch.sh index 08d86cd..32553f8 100755 --- a/git-fetch.sh +++ b/git-fetch.sh @@ -129,11 +129,11 @@ append_fetch_head () { then headc_=$(git-rev-parse --verify "$head_^0") || exit echo "$headc_ $not_for_merge_ $note_" >>"$GIT_DIR/FETCH_HEAD" - [ ...
Sep 29, 11:06 am 2006
Sean
Re: git and time
On Fri, 29 Sep 2006 13:37:36 -0400 It was just a single example, one maybe not important to you. In fact it might be interesting to someone who isn't even running _any_ Linux kernel themselves; a security researcher or journalist for instance. There are other examples as well. Maybe none of them would apply to your needs, but there are people who would find it interesting and convenient. Sean -
Sep 29, 10:46 am 2006
Jan Harkes
Re: git and time
I don't see the point in knowing how many days ago the security fix was published, since I'd really care if my machine is running a kernel that contains the fix. So I can see how I might want to know which branches (and/or tags) in my repository contain the security fix. And this is pretty easy, #!/bin/sh fix="$(git-rev-parse --verify $1)" git ls-remote . | while read sha ref ; do [ "$fix" == "$(git-merge-base "$fix" "$sha")" ] && echo $ref done Of course this could be cleaned up ...
Sep 29, 10:37 am 2006
Luben Tuikov
[PATCH] gitweb: tree view: hash_base and hash are now co ...
In tree view, by default, hash_base is HEAD and hash is the entry equivalent. Else the user had selected a hash_base or hash, say by clicking on a revision or commit, in which case those values are used. Signed-off-by: Luben Tuikov <ltuikov@yahoo.com> --- gitweb/gitweb.perl | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-)
Sep 29, 9:57 am 2006
picca
problem with cvsimport
hello When I tried to import the tango-cs project from sourceforge with this command: git cvsimport -p --no-cvs-direct -v -d :pserver:anonymous@tango-cs.cvs.sourceforge.net/cvsroot/tango-cs -C . tango The import stop with: skip patchset 3711: 1159522098 before 1159522323 skip patchset 3712: 1159522157 before 1159522323 skip patchset 3713: 1159522283 before 1159522323 skip patchset 3714: 1159522323 before 1159522323 DONE. fatal: Needed a single revision fatal: Needed a single ...
Sep 29, 8:25 am 2006
Petr Baudis
[ANNOUNCE] Cogito-0.18
Hello, I just released cogito-0.18 - new feature release of the Cogito user-friendly Git user interface. The biggest highlights are super-duper cg-log, tagging interface and cg-patch -m. Contrary to my plan, this unfortunately does NOT contain three big things yet that are missing but will be in cogito-0.19 (which should be already quite near the ever-approaching version 1.0): - Rigorous three-way merging of uncommitted local changes instead of stashing local changes in patches ...
Sep 29, 5:06 am 2006
Geert Uytterhoeven
git sometimes stripping one path component in commit mails
Hi, I noticed git sometimes strips one path component from the filenames in the patches mailed to the git-commits mailing lists. This causes problems when piping these mails through diffstat. Here is a part of an actual mail received through git-commits-head@vger.kernel.org to demonstrate this issue: Is this a current git bug, or a bug in the version used for those mailing lists? | commit 94c12cc7d196bab34aaa98d38521549fa1e5ef76 | tree 8e0cec0ed44445d74a2cb5160303d6b4dfb1bc31 | parent ...
Sep 29, 1:41 am 2006
Junio C Hamano
Re: git sometimes stripping one path component in commit mails
This is a current git bug (and git bug ever since it started to say "dissimilarity index"). Thanks for noticing, and very sorry for the trouble. It seems that a complete rewrite diff never worked and nobody seriously looked at them. This should fix it. -- >8 -- [PATCH] git-diff -B output fix. Geert noticed that complete rewrite diff missed the usual a/ and b/ leading paths. Pickaxe says it never worked, ever. Embarrassing. Signed-off-by: Junio C Hamano <junkio@cox.net> --- ...
Sep 29, 2:08 am 2006
Carl Worth
Re: [PATCH] Use "hash1..hash2" instead of "from hash1 to ...
I had requested this change once to help cut and paste. The current behavior I get for selecting hash1..hash2 with (for example) gnome-terminal is somewhat unfortunate, (double-clicking on any character selects the pair plus the separator). Obviously, '.' must be considered a word character, not a separator. I wonder if such selection is easily capable of being told to consider ".." a word separator? If so, it seems the output would be quite convenient whether one or two of the hashes were ...
Sep 29, 12:53 pm 2006
Johannes Schindelin
Re: [PATCH] --stat: ensure at least one '-' for deletion ...
Hi, I see that you care deeply about the 7 column example. In that case, yes, I would rather have columns be rounded down to the next even number. I care more about the consistency: if there are changes, I want to see them, and it should be linear: the more changes, the more plusses or minusses. Ciao, Dscho P.S.: here's a patch on top of my last one: -- snip -- [PATCH] force even diffstat width Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> --- diff.c | 3 ...
Sep 28, 9:07 pm 2006
Johannes Schindelin
Re: Fix approxidate() to understand more extended numbers
Hi, Actually, yesterday I saw a digital wrist watch for the first time in my life! Amazing! ;-) There is even a running joke about Great Britain: "Oh yes, I _love_ English dishes; especially the Chinese ones!" Ciao, Dscho -
Sep 29, 7:04 am 2006
Linus Torvalds
Re: Fix approxidate() to understand more extended numbers
I think 12pm is correct, but 12am probably isn't (12am should _subtract_ 12, while 12pm does _not_ add 12). That said, I have a rice cooker that avoids the problem by saying "0:10 PM" for ten minutes past midday ;) Of course, all sane and civilized countries just use 24-hour format anyway. "Military time" my *ss. Some day the US will turn metric and 24-hour-format. If the sun doesn't turn into a red giant first, that is. Linus -
Sep 28, 11:03 pm 2006
Linus Torvalds
Re: Fix approxidate() to understand more extended numbers
That's not the point. If you write 12:30 am you really _should_ subtract 12, leaving you with 0:30. We don't. So we end up with a 24-hour time of 12:30, which is obviously _pm_, and wrong. Ok, is it just me, or is that just a very odd question? I can see the question "You eat uni?". That really _does_ take a bit of getting used to. And Natto I really _really_ don't see the point of. But rice? Afaik, it's the most common food-staple in the world. It's not Yeah, well, ...
Sep 28, 11:42 pm 2006
Linus Torvalds
Re: Fix approxidate() to understand more extended numbers
Here's a patch that should work. It just simplifies the whole thing to say "hour = (hour % 12) + X" where X is 12 for PM and 0 for AM. It also fixes the "exact date" parsing, which didn't parse AM at all, and as such would do the same "12:30 AM" means "12:30 24-hour-format" bug. Of course, I hope that no exact dates use AM/PM anyway, but since we support the PM format, let's just get it right. Not hugely tested, but I did test some of it, and it all _looks_ ...
Sep 29, 12:36 pm 2006
Junio C Hamano
Re: Fix approxidate() to understand more extended numbers
Ah, that's what you meant. My brain a bit too tired from the Having rice cooker implied eating the stuff regularly and I just did not expect that from a north european. Just showing my ignorance -- I've never been to Europe. -
Sep 29, 12:09 am 2006
Junio C Hamano
Re: Fix approxidate() to understand more extended numbers
But you have "if (hour > 0 && hour < 12)" in both am and pm so You are referring to the US, but neither is Japan sane nor civilized ;-). -
Sep 28, 11:14 pm 2006
Andreas Ericsson
Re: git and time
Moot point (it has been iterated so many times that I can't be asked to Most people use ntp, and are in general concerned with keeping their clocks in sync as lots of other software depend on it (calender functions, fe). It shouldn't be the task of project leaders to make sure that the ~50000 random people around the world that submit patches to Can be done using reflog. Feel free to submit patches. Make sure you sync your clock to whatever ntp-server or other timekeeping mechanism ...
Sep 29, 1:16 am 2006
Andreas Ericsson
Re: [PATCH 3/3] diff --stat: sometimes use non-linear scaling.
Why not just take the stupid and simple solution and make it: file1 | +31,-19 +++ file2 | +19,-106 --- file3 | +10,-10 ### That is, show the number of lines that actually changed, and print a fixed number of plusses or minuses after the numbers to make it easy to, at a glance, check if more lines were added than deleted or vice versa. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 ...
Sep 29, 3:56 am 2006
Petr Baudis
Re: What's in git.git
Dear diary, on Fri, Sep 29, 2006 at 09:34:51AM CEST, I got a letter The passage should be kept and even GITPERLLIB - just drop the second path after the colon. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ #!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj $/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1 lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/) -
Sep 29, 1:32 am 2006
Junio C Hamano
Re: What's in git.git
quoting myself... || * The 'next' branch, in addition, has these. I think the ones || marked with + could be 1.4.3-rc1 material: -
Sep 29, 1:09 am 2006
Junio C Hamano
Re: What's in git.git
I came up with this to apply on top of "next". Extra sets of eyeballs very much appreciated. -- >8 -- Remove -fPIC which was only needed for Git.xs The distinction between BASIC_ vs ALL_ is still kept, since it is not Git.xs specific -- we could face the same issue when we do other language bindings (e.g. Python). Signed-off-by: Junio C Hamano <junkio@cox.net> --- INSTALL | 13 ------------- Makefile | 13 ------------- config.mak.in | 1 - configure.ac | 7 ...
Sep 29, 12:34 am 2006
Linus Torvalds
Re: [PATCH 1/3] diff --stat: allow custom diffstat outpu ...
I phrased that badly. IF C pointer conversion allowed implicit addition of "const" past the top-most level, ANSI C would have just done "strtoul()" as unsigned long strtoul(const char *n, const char **p, int); ie they could just have added the "const" not just to the first argument, and legact programs (without const) would still have worked fine. But _because_ that's not how C type rules work, we have the current situation where the first argument is a "const char *", and the ...
Sep 28, 11:17 pm 2006
Linus Torvalds
Re: [PATCH 1/3] diff --stat: allow custom diffstat outpu ...
The _code_ really is right. The problem is "strtoul()" interfaces and a You could fix it by doing something like this: static inline unsigned long sane_strtoul(const char *n, const char **p, int base) { char *end; unsigned long res; res = strtoul(n, &end, base); *p = end; return res; } because the only reason strtoul() warns now is that C type-rules don't allow the (obviously safe - but pointers migth have strange representations) conversion of ...
Sep 28, 10:58 pm 2006
Junio C Hamano
Re: [PATCH 1/3] diff --stat: allow custom diffstat outpu ...
This is simply too clever; -pedantic does not like assignment of arg to end (constness -- and strtoul takes pointer to non-const char *, so making the type of end const char * is not an answer either). And I do not like casting constness away: end = (char *) arg. Hmmmm. -
Sep 28, 10:26 pm 2006
Junio C Hamano
Re: [PATCH 1/3] diff --stat: allow custom diffstat outpu ...
Yes, the code is right (not only because you wrote it ;-) and not just right but it is crystal clear to humans what is going on and why the final "if (*end)" is all that is needed without ... which I ended up doing anyway. Thanks. -
Sep 28, 11:11 pm 2006
Jakub Narebski
Re: git and time
It is planned to add reflog support (view) to gitweb. But of course the repository that is under gitweb has to have reflog _enabled_ to be able to view it. -- Jakub Narebski Poland -
Sep 29, 1:42 pm 2006
Jakub Narebski
Re: git and time
No, as of now "commitdiff_plain" or "commit_plain" view shows either git-name-rev information, or just tag if the tag points exactly at given [child] commit, not git-describe information. Although it would be fairly easy to add this information, though... -- Jakub Narebski Poland -
Sep 29, 1:58 pm 2006
Johannes Schindelin
Re: git and time
Hi, It is called git-browser, and was done by Artem Khodush. See http://straytree.com/. I asked Artem what the plans are, since some features are not yet implemented, but he said that the thing is too slow, and he'll probably not continue to work on it. Ciao, Dscho -
Sep 29, 7:09 am 2006
Andreas Ericsson
Re: git and time
True that. I would have had a hard time introducing git as The SCM in the company if it hadn't been for gitk and qgit. They both let you just skip over 90% of that initial steep part of the learning curve and jump Someone started hacking on a web-thingie to show the graph. Whatever happened to that? If it's no longer alive, perhaps we could add some qgit/gitk screenshots to the git wiki/docs so the people who spend most of their lives in browsers can get some visual aid in understanding ...
Sep 29, 12:52 am 2006
Andreas Ericsson
Re: git and time
Ah well. I hope he keeps that page running though, and I hope the "time-is-importan" people find it. For reference, it gives a crude (and indeed slow) picture of what gitk and qgit does. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 -
Sep 29, 7:21 am 2006
Jakub Narebski
Re: [PATCH] gitweb: tree view: hash_base and hash are no ...
As a interim solution it is a good idea, moreover with using $hash_base defaulting to HEAD instead of using HEAD literaly. The correct solution would be to make "html" page (i.e. "blob" not "blob_plain" view) also for binary files. <img> element for image/* mimetype, perhaps <embed> or <object>, or just plain link for other binary (not text/* or some application/*) types I was AFK for few days. -- Jakub Narebski Poland -
Sep 29, 1:35 pm 2006
Luben Tuikov
Re: [PATCH] gitweb: tree view: hash_base and hash are no ...
We already do have a hash_base context. It is what allows us to "select" a revision from shortlog and ask "tree", "history", etc from there on, having set "h" and/or "hb". What this patch does is simply set "h" and/or "hb" to the string "HEAD" instead of the string "<SHA1 of HEAD>" when h/hb is not defined. -
Sep 29, 4:30 pm 2006
Luben Tuikov
Re: [PATCH] gitweb: tree view: hash_base and hash are no ...
We haven't heard anything from him, and on our last correspondence Doing it right now. Thanks, Luben -
Sep 29, 9:16 am 2006
Junio C Hamano
Re: [PATCH] gitweb: tree view: hash_base and hash are no ...
No objections from me --- rather lack of objections from Jakub ;-) But the fragments do not appear to apply anymore. @@ -1625,7 +1625,7 @@ sub git_print_tree_entry { "history"); } print " | " . - $cgi->a({-href => href(action=>"blob_plain", hash_base=>"HEAD", + $cgi->a({-href => href(action=>"blob_plain", hash_base=>$hash_base, file_name=>"$basedir$t->{'name'}")}, "raw"); print "</td>\n"; There is no call to create blob_plain link with ...
Sep 28, 11:06 pm 2006
Martin Waitz
Re: Notes on Using Git with Subprojects
hoi :) ok, it's not independent in that sense that you can move the directory away and expect the submodule to work even when the parent does not exist any more. But you can do normal GIT work as before. You can create new branches (they will be stored in the parent but you have to "git add .gitmodule/..." explicitly in order to track the branch in the parent), fetch/pull from other sides, create commits, etc. So in your normal workflow you do not have to do anything in the parent while ...
Sep 29, 12:04 am 2006
Santi
Re: [PATCH] branch: write branch properties
Any comments on this? Possible comments :D - No comments - Not interested - Not interesting - I like the idea but not the patch because... - I like the patch but not the idea (?) - Broken syntax. Could be done in this other way... - Stop all this crazy things, just config all this manually! - Start more crazy things, like... - ... Santi -
Sep 29, 3:47 pm 2006
Robin Rosenberg
Re: [PATCH] Make cvsexportcommit work with filenames con ...
But, then I can stop here, because that sounds like a much better solution. My hack is kind-of-kludgy anyway. I'll look in the pu branch. Still want the test cases, although not complete? -- robin -
Sep 29, 12:25 am 2006
Junio C Hamano
Re: [PATCH] Make cvsexportcommit work with filenames con ...
Please do not do more than one patch per e-mail; I'll have to save the attachment in separate files and manually make commits, which is more work. The build procedure for the release to build rpms runs testsuite as part of it, so I need to think a bit how to proceed with this patch. Leaving the test failing on FC5 means I won't be able to cut binary releases. Checking early in the test script to see if "patch" can grok a diff for a file with whitespaces, and skipping the whitespace test if ...
Sep 28, 11:37 pm 2006
previous daytodaynext day
September 28, 2006September 29, 2006September 28, 2006