On Mon, 28 Aug 2006, Jakub Narebski wrote:
quoted text
>
> This series of patches makes signoff lines to be not removed in commitdiff and log 
> views, adds author information to comittdiff view, and adds diff tree with links
> to patches in commitdiff view.
> 
> You will be able to see it at work at
>   http://front.fuw.edu.pl/cgi-bin/jnareb/gitweb.cgi

Goodie, that looks exactly like I envisioned. And the shortcuts to find 
the patch to a specific file (when the patch is larger) works beautifully.

Now I think "commit-diff" is prettier than the "commit" view (the latter 
ends up showing the "--pretty=full" information, which can be useful, but 
usually is just distracting). That's as it should be - I consider 
"commit-diff" to be the _normal_ thing, and then the "commit" view is the 
"give me all the ugly details in just the commit".

I've got _one_ small beef with gitweb still, which is that it seems to 
like always showing things in UTC rather than the "native" timezone, but I 
can see why people would sometimes want that. So I'm not actually sure 
it's wrong.

I think it _may_ be worth showing the native timezone in the "commit-diff" 
view (when you see only one commit), and then show the UTC time in the 
"log" view (when you see a lot of commits, and might want to compare times 
in different timezones more easily).

But I think that timezone thing is probably a matter of taste rather than 
much anything else.

Thanks,

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html