Home » Mailing list archives » git » 2006 » July » 7

[PATCH] git-svn: migrate out of contrib

Previous thread: Re: git on HP-UX by Junio C Hamano on Thursday, July 6, 2006 - 5:20 pm. (3 messages)

Next thread: [PATCH] Add "raw" output option to blobs in "tree" view format by Luben Tuikov on Thursday, July 6, 2006 - 11:39 pm. (4 messages)
[view original message]
From: Junio C Hamano
Subject: Re: [RFC/PATCH] git-svn: migrate out of contrib
Date: Thursday, July 6, 2006 - 5:20 pm

Overall it looks good.

9104 and 9105 fail when GIT_SVN_NO_LIB is unset and the
libsvn-*-perl is not available.  Maybe check this just like you
check and omit tests when svn or svnadmin is unavailable?


-


[ message continues ]
[view original message]
From: Eric Wong
Subject: [PATCH] git-svn: migrate out of contrib
Date: Friday, July 7, 2006 - 3:03 am

Allow NO_SVN_TESTS to be defined to skip git-svn tests.  These
tests are time-consuming due to SVN being slow, and even more so
if SVN Perl libraries are not available.

Also added a check for SVN::Core so test 910[45] don't fail
if the user doesn't have those installed, thanks to Junio for
noticing this.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 Junio C Hamano <junkio@cox.net> wrote:
 > Overall it looks good.
 > 
 > 9104 and 9105 fail when GIT_SVN_NO_LIB is unset and the
 > libsvn-*-perl is not available.  Maybe check this just like you
 > check and omit tests when svn or svnadmin is unavailable?

 Done.  While I was at it, I changed the test != to test -eq
 and brought the similarity below the threshold, which may
 make me want to expand on another patch...

 .gitignore                                         |    1 
 {contrib/git-svn => Documentation}/git-svn.txt     |    0 
 Makefile                                           |    6 ++-
 contrib/git-svn/.gitignore                         |    4 --
 contrib/git-svn/Makefile                           |   44 --------------------
 contrib/git-svn/git-svn.perl => git-svn.perl       |    2 -
 t/Makefile                                         |   10 +++++
 {contrib/git-svn/t => t}/lib-git-svn.sh            |   29 ++++++++-----
 .../t9100-git-svn-basic.sh                         |    4 ++
 .../t9101-git-svn-props.sh                         |    0 
 .../t9102-git-svn-deep-rmdir.sh                    |    0 
 .../t9103-git-svn-graft-branches.sh                |    0 
 .../t9104-git-svn-follow-parent.sh                 |    0 
 .../t9105-git-svn-commit-diff.sh                   |    0 
 14 files changed, 37 insertions(+), 63 deletions(-)

diff --git a/.gitignore b/.gitignore
index 2bcc604..52d61f3 100644
--- a/.gitignore
+++ b/.gitignore
@@ -107,6 +107,7 @@ git-ssh-push
 git-ssh-upload
 git-status
 git-stripspace
+git-svn
 git-svnimport
 git-symbolic-ref
 git-tag
diff --git a/contrib/git-svn/git-svn.txt ...
[ message continues ]
Previous thread: Re: git on HP-UX by Junio C Hamano on Thursday, July 6, 2006 - 5:20 pm. (3 messages)

Next thread: [PATCH] Add "raw" output option to blobs in "tree" view format by Luben Tuikov on Thursday, July 6, 2006 - 11:39 pm. (4 messages)