[PATCH 3/7] Git.pm: Swap hash_object() parameters

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Petr Baudis
Date: Saturday, June 24, 2006 - 6:54 pm

I'm about to introduce get_object() and it will be better for consistency
if the object type always goes first. And writing 'blob' there explicitly
is not much bother.

Signed-off-by: Petr Baudis <pasky@suse.cz>
---

 perl/Git.pm |    8 ++++----
 perl/Git.xs |    4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/perl/Git.pm b/perl/Git.pm
index 6da11a6..eea6c07 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -570,13 +570,13 @@ sub ident_person {
 
 
 
-=item hash_object ( FILENAME [, TYPE ] )
+=item hash_object ( TYPE, FILENAME )
 
-=item hash_object ( FILEHANDLE [, TYPE ] )
+=item hash_object ( TYPE, FILEHANDLE )
 
 Compute the SHA1 object id of the given C<FILENAME> (or data waiting in
-C<FILEHANDLE>) considering it is of the C<TYPE> object type (C<blob>
-(default), C<commit>, C<tree>).
+C<FILEHANDLE>) considering it is of the C<TYPE> object type (C<blob>,
+C<commit>, C<tree>).
 
 In case of C<FILEHANDLE> passed instead of file name, all the data
 available are read and hashed, and the filehandle is automatically
diff --git a/perl/Git.xs b/perl/Git.xs
index ebaac4b..2fd1c67 100644
--- a/perl/Git.xs
+++ b/perl/Git.xs
@@ -105,9 +105,9 @@ CODE:
 }
 
 char *
-xs_hash_object(file, type = "blob")
-	SV *file;
+xs_hash_object(type, file)
 	char *type;
+	SV *file;
 CODE:
 {
 	unsigned char sha1[20];
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 3/7] Git.pm: Swap hash_object() parameters, Petr Baudis, (Sat Jun 24, 6:54 pm)
[PATCH 6/7] Git.pm: Introduce fast get_object() method, Petr Baudis, (Sat Jun 24, 6:54 pm)
[PATCH 7/7] Convert git-annotate to use Git.pm, Petr Baudis, (Sat Jun 24, 6:54 pm)
Re: [PATCH 7/7] Convert git-annotate to use Git.pm, Ryan Anderson, (Sun Jun 25, 2:27 am)
Re: [PATCH 7/7] Convert git-annotate to use Git.pm, Petr Baudis, (Sun Jun 25, 2:36 am)