Re: What's in git.git

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Junio C Hamano <junkio@...>
Cc: <git@...>
Date: Tuesday, May 9, 2006 - 11:48 pm

On Tue, 9 May 2006, Junio C Hamano wrote:

The reason for the failure is the new syntax for multi-section variables.

This patch makes the test succed, by changing

	[1.2.3]

into

	[1 "2.3"]

which is how subsections now end up being shown (you can still _parse_ 
them the old way, but they get created the new way, which is why the test 
fails)

That's a very strange test-case, and on the face of it the new syntax 
looks "worse", but if you were to be realistic about this kind of section 
name, it would more likely explain _what_ that number sequence means, so 
you would more realistically name your sections something like

	[version "1.2.3"]

which I think everybody agrees looks nicer than

	[version.1.2.3]

or similar.

Of course, I don't think we currently actually have any _users_ of any 
multi-level section names at all, so this is all entirely theoretical 
until we start actually using them.

		Linus
---
diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
index 7090ea9..54b3394 100755
--- a/t/t1300-repo-config.sh
+++ b/t/t1300-repo-config.sh
@@ -241,7 +241,7 @@ # empty line
 	NoNewLine = wow2 for me
 [123456]
 	a123 = 987
-[1.2.3]
+[1 "2.3"]
 	alpha = beta
 EOF
 
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
What's in git.git, Junio C Hamano, (Tue May 9, 11:11 pm)
Re: What's in git.git, Martin Langhoff, (Wed May 10, 1:34 am)
Re: What's in git.git, Randal L. Schwartz, (Wed May 10, 12:36 am)
Re: What's in git.git, Junio C Hamano, (Wed May 10, 1:05 am)
Re: What's in git.git, Linus Torvalds, (Wed May 10, 12:45 am)
Re: What's in git.git, Nicolas Pitre, (Wed May 10, 10:15 am)
Re: What's in git.git, Linus Torvalds, (Wed May 10, 12:48 pm)
Re: What's in git.git, Alex Riesen, (Wed May 10, 11:00 am)
Re: What's in git.git, Linus Torvalds, (Wed May 10, 12:21 am)
Re: What's in git.git, Junio C Hamano, (Wed May 10, 12:41 am)
Re: What's in git.git, Linus Torvalds, (Wed May 10, 12:51 am)
Re: What's in git.git, Linus Torvalds, (Wed May 10, 12:26 am)
Re: What's in git.git, Linus Torvalds, (Tue May 9, 11:48 pm)