Home » Mailing list archives » git » 2006 » May » 21

[PATCH] compress output of `cd' when installing templates

Previous thread: First tarball release of qgit with tabs by Marco Costalba on Sunday, May 21, 2006 - 7:29 am. (1 message)

Next thread: What's in git.git by Junio C Hamano on Sunday, May 21, 2006 - 12:01 pm. (1 message)
[view original message]
From: Gang Chen
Subject: [PATCH] compress output of `cd' when installing templates
Date: Sunday, May 21, 2006 - 8:41 am

When CDPATH is set in Bash, `cd' writes new working directory to
stdout, which corrupts output of `tar cf - .'.

Signed-off-by: Gang Chen <goncha.ml@gmail.com>

---

 Makefile |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/Makefile b/templates/Makefile
index 8f7f4fe..cb67489 100644
--- a/templates/Makefile
+++ b/templates/Makefile
@@ -44,5 +44,5 @@ clean:
 
 install: all
 	$(INSTALL) -d -m755 $(call shellquote,$(DESTDIR)$(template_dir))
-	(cd blt && $(TAR) cf - .) | \
+	(cd blt > /dev/null && $(TAR) cf - .) | \
 	(cd $(call shellquote,$(DESTDIR)$(template_dir)) && $(TAR) xf -)

-- 
If it makes you happy, it can't be that bad.
-


[ message continues ]
[view original message]
From: Timo Hirvonen
Subject: Re: [PATCH] compress output of `cd' when installing templates
Date: Sunday, May 21, 2006 - 8:54 am

Fix bash instead, or just don't export CDPATH.  It is used by bash only
so exporting it is unnecessary.

-- 
http://onion.dynserv.net/~timo/
-


[ message continues ]
[view original message]
From: Junio C Hamano
Subject: Re: [PATCH] compress output of `cd' when installing templates
Date: Sunday, May 21, 2006 - 11:23 am

Thanks.

It is not just unnecessary, but "export CDPATH" anywhere in your
rc scripts is actively *WRONG*.

-


[ message continues ]
Previous thread: First tarball release of qgit with tabs by Marco Costalba on Sunday, May 21, 2006 - 7:29 am. (1 message)

Next thread: What's in git.git by Junio C Hamano on Sunday, May 21, 2006 - 12:01 pm. (1 message)