login
Header Space

 
 

Re: [PATCH] Make '@' not valid in a ref name.

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Eric Wong <normalperson@...>
Cc: Junio Hamano <junkio@...>, <git@...>, Martin Langhoff <martin.langhoff@...>
Date: Saturday, May 20, 2006 - 10:19 pm

Eric Wong <normalperson@hand.yhbt.net> wrote:

OK, so this patch is quite unpopular and should never make it
into GIT.  I'm glad we have many eyes on this mailing list!


There was just a short conversation on #git about converting
the sha1 expression evaluator into a split parser/interpreter
model.  The idea here would be to convert an expression such as

  HEAD@{yesterday}~3^{tree}

into a an expression tree such as (in LISP style):

  (peel-onion (walk-back 3 (date-spec yesterday (ref HEAD))))

with such a tree it is relatively easy to evaluate the expression,
but its also easy to determine if a ref name is valid.  Just pass
it through the parser and see if you get back anything more complex
then '(ref <input>)'.

Comments?

-- 
Shawn.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Make '@' not valid in a ref name., Shawn Pearce, (Sat May 20, 9:37 pm)
Re: [PATCH] Make '@' not valid in a ref name., Eric Wong, (Sat May 20, 10:00 pm)
Re: [PATCH] Make '@' not valid in a ref name., Shawn Pearce, (Sat May 20, 10:19 pm)
Re: [PATCH] Make '@' not valid in a ref name., Junio C Hamano, (Sat May 20, 9:42 pm)
Re: [PATCH] Make '@' not valid in a ref name., Shawn Pearce, (Sat May 20, 9:58 pm)
speck-geostationary