login
Header Space

 
 

[PATCH] Make '@' not valid in a ref name.

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Junio Hamano <junkio@...>
Cc: <git@...>
Date: Saturday, May 20, 2006 - 9:37 pm

Now that the sha1 expression syntax supports looking up a ref's
value at a prior point in time through the '@' operator the '@'
operator should not be permitted in a ref name.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

---

90d3212d5351d2f6c6ad33578c9f9df2e07af12e
 refs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

90d3212d5351d2f6c6ad33578c9f9df2e07af12e
diff --git a/refs.c b/refs.c
index eeb1196..2530c99 100644
--- a/refs.c
+++ b/refs.c
@@ -213,14 +213,14 @@ int get_ref_sha1(const char *ref, unsign
  *
  * - any path component of it begins with ".", or
  * - it has double dots "..", or
- * - it has ASCII control character, "~", "^", ":" or SP, anywhere, or
+ * - it has ASCII control character, "@", "~", "^", ":" or SP,
  * - it ends with a "/".
  */
 
 static inline int bad_ref_char(int ch)
 {
 	return (((unsigned) ch) <= ' ' ||
-		ch == '~' || ch == '^' || ch == ':' ||
+		ch == '@' || ch == '~' || ch == '^' || ch == ':' ||
 		/* 2.13 Pattern Matching Notation */
 		ch == '?' || ch == '*' || ch == '[');
 }
-- 
1.3.3.gfad60

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Make '@' not valid in a ref name., Shawn Pearce, (Sat May 20, 9:37 pm)
Re: [PATCH] Make '@' not valid in a ref name., Eric Wong, (Sat May 20, 10:00 pm)
Re: [PATCH] Make '@' not valid in a ref name., Shawn Pearce, (Sat May 20, 10:19 pm)
Re: [PATCH] Make '@' not valid in a ref name., Junio C Hamano, (Sat May 20, 9:42 pm)
Re: [PATCH] Make '@' not valid in a ref name., Shawn Pearce, (Sat May 20, 9:58 pm)
speck-geostationary