login
Header Space

 
 

git mailing list

FromSubjectsort iconDate
Linus Torvalds
[PATCH] libify git-ls-files directory traversal
This moves the core directory traversal and filename exclusion logic into the general git library, making it available for other users directly. If we ever want to do "git commit" or "git add" as a built-in (and we do), we want to be able to handle most of git-ls-files as a library. NOTE! Not all of git-ls-files is libified by this. The index matching and pathspec prefix calculation is still in ls-files.c, but this is a big part of it. Signed-off-by: Linus Torvalds <torvalds@osdl.org>...
May 16, 10:02 pm 2006
Linus Torvalds
[PATCH] Clean up git-ls-file directory walking library inter...
This moves the code to add the per-directory ignore files for the base directory into the library routine. That not only allows us to turn the function push_exclude_per_directory() static again, it also simplifies the library interface a lot (the caller no longer needs to worry about any of the per-directory exclude files at all). Signed-off-by: Linus Torvalds <torvalds@osdl.org> --- dir.c | 28 +++++++++++++++++++++++++++- dir.h | 2 -- ls-files.c | 22 +----------...
May 16, 10:46 pm 2006
Linus Torvalds
Re: [PATCH] libify git-ls-files directory traversal
Side note: the reason I held off on the index matching is that git-ls-files currently uses a pretty disgusting trick to make the index accesses faster for the common subdirectory case, namely it basically rewrites the index so that it only contains the entries defined by a common prefix. Now, that's fine for git-ls-files, but it's not fine for a library function where the caller may well want to actually use the index that it has read in (eg "git add" and "git commit" both want to work ...
May 16, 10:36 pm 2006
Stefan Pfetzing
Git 1.3.2 on Solaris
Hi, I've been trying to get git to work on the latest Solaris Express release (with the help of NetBSD's pkgsrc). It mostly miserabely fails because of common "shell commands" being used with GNU options. (like xargs, diff, tr and prob. some more) On my box (and thats AFAIK the default when you install gnu coreutils on Solaris) the commands do have a g prefix. So there are 2 possible solutions to get git working on Solaris. 1. fix every single shellscript automatically during the build phas...
May 16, 7:52 pm 2006
Linus Torvalds
Re: Git 1.3.2 on Solaris
[ Junio - see the "grep" issue ] If the biggest issue is git depending on some GNU extensions, I'd really suggest (a) install all the normal GNU binaries, and put them in the path before git just to get it working (and don't try to change git at all) (b) help send in patches that just remove the dependency entirely. I've been - on and off - trying to libify most of the core git sources, so that the shell scripts can be re-written to be just plain C. Most of the time it's not actua...
May 16, 10:20 pm 2006
Jason Riedy
Re: Git 1.3.2 on Solaris
And Linus Torvalds writes: - - The complete libification will take some time, and in the meantime, a few - silly C files that hard-code the shell logic is probably much preferable - to using the shell and all the problems that involves (like the whole - problem with quoting arguments - just _gone_ when you do it as a execve() - in a simple C program). But for recommending and using git on these systems _now_... Simply translating the shell script into C with execs doesn't help if you'r...
May 16, 11:26 pm 2006
Linus Torvalds
Re: Git 1.3.2 on Solaris
Yes. For that, I would literally suggest having people install the GNU tools (and/or a recent enough perl) somewhere early in the path. If you use the git wrapper, for example, you can already depend on the fact that it will prepend the git installation directory to the path, so while the GNU tools might not _normally_ be on the path, if you put them in the same directory as your git install, you'll automatically get them as long as you use the "git cmd" format (rather than the "git-cmd" ...
May 16, 11:49 pm 2006
Jason Riedy
Re: Git 1.3.2 on Solaris
And "Stefan Pfetzing" writes: - I've been trying to get git to work on the latest Solaris Express - release (with the help of NetBSD's pkgsrc). I've been using it on Solaris 8 and 9 with the GNU tools in pkgsrc for quite a while, as well as on AIX with the GNU tools available as modules (but I haven't compiled a new AIX version for a month or two). - It mostly miserabely fails because of common "shell commands" being - used with GNU options. (like xargs, diff, tr and prob. some more) On - ...
May 16, 9:25 pm 2006
Linus Torvalds
Remove old "git-grep.sh" remnants
It's built-in now. Signed-off-by: Linus Torvalds <torvalds@osdl.org> ---- diff --git a/Makefile b/Makefile index 93779b0..9ba608c 100644 --- a/Makefile +++ b/Makefile @@ -124,7 +124,7 @@ SCRIPT_SH = \ git-tag.sh git-verify-tag.sh \ git-applymbox.sh git-applypatch.sh git-am.sh \ git-merge.sh git-merge-stupid.sh git-merge-octopus.sh \ - git-merge-resolve.sh git-merge-ours.sh git-grep.sh \ + git-merge-resolve.sh git-merge-ours.sh \ git-lost-found.sh SCRIPT_PERL = \ @@ -16...
May 16, 7:46 pm 2006
Junio C Hamano
Re: [PATCH] improve depth heuristic for maximum delta size
Good job, and it does not seem to spend too many more cycles either (it does slow it down a bit because it needs to do more deltas, but that is to be expected). Here is the average chain length and resulting pack size from full repacking of git.git repository, with three versions. Avg 6.20 6516kB (master) Avg 5.97 5784kB (next, has 1/x version) Avg 6.89 5536kB (this patch on top of next) What's interesting is that the 1/x version shortens the chain (i.e. decrea...
May 16, 7:34 pm 2006
Junio C Hamano
Re: [PATCH] Update the documentation for git-merge-base
The first one is because at 1.3.0 I pulled everything from "next" to "master". Usually "next" incorporates topic branches that stem from different commits on "master", and when a new topic is merged to "next", it gets the updates to "master" up to that point along with the new topic. When topics graduate (i.e. merged back) to "master", they do so at different pace. topic2 o---o---o---o---H---. / \ \ next -----------o---o---E---o...
May 16, 7:20 pm 2006
Jakub Narebski
Re: "git add $ignored_file" fail
Well, if shell expansion cannot find a file matching pattern, it uses pattern as file name literaly. It would be nice to have easy (git core porcelain level) way to add files which match ignore pattern. -- Jakub Narebski Warsaw, Poland -
May 16, 6:41 pm 2006
Santi
Ouput of git diff with <ent>:<path>
Hi *, just curious if this is the expected output. I find this syntax very usefull but the "a/v1.3.3:" of even without the tree "a/:" a bit confusing. And I didn't expect the rename from/to neither the similarity index 0%. diff --git a/v1.3.3:Makefile b/Makefile similarity index 0% rename from v1.3.3:Makefile rename to Makefile index b808eca..55d1937 100644 --- a/v1.3.3:Makefile +++ b/Makefile Thanks. Santi -
May 16, 6:24 pm 2006
Junio C Hamano
Re: Ouput of git diff with <ent>:<path>
Yes I am aware of this one; I just haven't bothered to deal with it. It looks at two strings, "v1.3.3:Makefile" and "Makefile", and says "they have different names -- they are renamed". Patches welcome as long as you do not break more usual cases ;-). -
May 16, 6:44 pm 2006
Santi
"git add $ignored_file" fail
Hi *, When you try to add ignored files with the git-add command it fails because the call to: git-ls-files -z \ --exclude-from="$GIT_DIR/info/exclude" \ --others --exclude-per-directory=.gitignore does not output this file because it is ignored. I know I can do it with: git-update-index --add $ignored_file I understand the behaviour of git-ls-files but I think it is no the expected for git-add, at least for me. Thanks Santi -
May 16, 6:07 pm 2006
Linus Torvalds
Re: "git add $ignored_file" fail
Well, the thing is, git-add doesn't really take a "file name", it takes a filename _pattern_. Clearly we can't add everything that matches the pattern, because one common case is to add a whole subdirectory, and thus clearly the .gitignore file must override the pattern. So it's consistent that it overrides it also for a single filename case, no? Linus -
May 16, 6:28 pm 2006
Santi
Re: "git add $ignored_file" fail
It's consistent from an implementation point of view, but not from the (my?) user point of view. This is why I say I understand it for git-ls-files. For the case of git-add even the usage and the man page talk about &lt;file&gt;... Clearly for the case of a whole subdirectory, or even ".", the .gitignore file must override the pattern, but not for the case of a pattern that is a single existing file. Santi -
May 16, 6:42 pm 2006
Santi
Merge with local conflicts in new files
Hi *, In the case of: - You merge from a branch with new files - You have these files in the working directory - You do not have these files in the HEAD. The end result is that you lose the content of these files. So an additional check for the merge is to check for these dirty but not in HEAD files. Here is a test that reproduce it. I expect the merge to fail and with the content of foo being bar. test_description='Test merge with local conflicts in new files' . ./tes...
May 16, 6:00 pm 2006
Junio C Hamano
Re: Merge with local conflicts in new files
and At this point, you have not told git that foo is a file that is relevant on branch B, so git considers it a fair game to overwrite. At least, that was the original reasoning. It happens not just during the ordinary "git-merge", by the way. If you are on branch B that did not have 'foo', created 'foo' and switched to branch A (which has 'foo') before telling the index that you care about your version of 'foo' on branch B, 'foo' from branch A will overwrite your throwaway copy in the w...
May 16, 6:40 pm 2006
Santi
Re: Merge with local conflicts in new files
For me it is the other way, all my files matter but git can do Thanks, it works here. Santi -
May 16, 7:11 pm 2006
Junio C Hamano
Re: Merge with local conflicts in new files
You really do not mean that. If you told git a file matters, and have local modifications to the file in the working tree that you have not run update-index yet, merge and apply should be careful not to overwrite your changes that is not ready while doing whatever thing they have to do. And they are careful, because you have told git that they matter, and the way you tell git that they matter is to have entries for them in the index. -
May 16, 7:28 pm 2006
Santi
Re: Merge with local conflicts in new files
Sorry, the test is wrong. Use this: test_description='Test merge with local conflicts in new files' . ./test-lib.sh test_expect_success 'prepare repository' \ 'echo "Hello" &gt; init &amp;&amp; git add init &amp;&amp; git commit -m "Initial commit" &amp;&amp; git checkout -b B &amp;&amp; echo "foo" &gt; foo &amp;&amp; git add foo &amp;&amp; git commit -m "File: foo" &amp;&amp; git checkout master &amp;&amp; echo "bar" &gt; foo &amp;&amp; ' test_expect_code 1 'Merge with local conflicts i...
May 16, 6:12 pm 2006
Luke
let's meet
Hire, i am here sittiang in the internet caffe. Found your email a!nd decided to write. I might be coming to your p!lace in 14 days, so I decided to email you. May be we ca!n meet? I am 25 y.o. girl. I have a picture if you want. No need to reply here as this is not my email. Write me at ex@datetodayy.com -
May 16, 2:42 pm 2006
Randal L. Schwartz
Re: let's meet
&gt;&gt;&gt;&gt;&gt; "Luke" == Luke &lt;oxwacpp@arsenal.co.uk&gt; writes: Luke&gt; Hire, Luke&gt; i am here sittiang in the internet caffe. Found your email a!nd Luke&gt; decided to write. I might be coming to your p!lace in 14 days, Luke&gt; so I decided to email you. May be we ca!n meet? I am 25 y.o. Luke&gt; girl. I have a picture if you want. No need to reply here as Luke&gt; this is not my email. Write me at ex@datetodayy.com I hope she has a big table. :) -- Randal L. Schwartz - Sto...
May 16, 4:34 pm 2006
Junio C Hamano
Re: let's meet
Huh? She's coming to *your* place, so you are the one to prepare a big table to cover the locations we all live---perhaps "earth"? ;-) -
May 16, 4:40 pm 2006
Tommi Virtanen
git-svn vs. $Id$
Hi. I just ran into trouble with git-svn, related to a file containing $Id$. Yes, I know $Id$ sucks and should be avoided, and I'll be removing them shortly, but that doesn't change the fact that the history contains files with them. Just wanted to let you know of a workaround: manually edit the relevant file in .git/git-svn/tree/ to undo the $Id$ change, and git-svn fetch works again. $ git-svn fetch Tree mismatch, Got: c242bb60d78c1dfce133e0bbaca7f13895de00b2, Expected: 07d35ac911cc56aabea86f...
May 16, 1:33 pm 2006
Linus Torvalds
Re: git-svn vs. $Id$
Isn't there some flag to svn to avoid keyword expansion, like "-ko" to CVS? Any import script definitely should avoid keyword expansion (and that's true whether you end up wanting to use keywords or not). (And yes, CVS is probably a bad example. Those "substitution modes" are confusing as hell, and I don't know which one is the right one. Is it "-ko" or "-kk"? Don't ask me, I'm CVS-illiterate. I don't know why the current cvsimport uses -kk, and only does it conditionally. Whatever.) ...
May 16, 1:48 pm 2006
Tommi Virtanen
Re: git-svn vs. $Id$
Well, yes, I agree. But, at least git-svn.txt says this: BUGS ---- ... svn:keywords can't be ignored in Subversion (at least I don't know of a way to ignore them). I guess one might be able to reach that information through the svn API. Or just propget svn:keywords and sed s/\$Id\(:[^$]*\)\$/$Id$/ all files with keywords, for all relevant keywords. Eww. -- Inoi Oy, Tykist
May 16, 2:12 pm 2006
Eric W. Biederman
[PATCH] Implement git-quiltimport
Importing a quilt patch series into git is not very difficult but parsing the patch descriptions and all of the other minutia take a bit of effort to get right, so this automates it. Since git and quilt complement each other it makes sense to make it easy to go back and forth between the two. --- Eric Documentation/git-quiltimport.txt | 50 +++++++++++++++++++++ Makefile | 2 - git-quiltimport.sh | 88 +++++++++++++++++++++++++++++++++++++ ...
May 16, 12:51 pm 2006
Linus Torvalds
Re: [PATCH] Implement git-quiltimport
Please don't do this. Just error out. It would be horrible to have a quilt import "succeed", and then later notice that some of the patches had incorrect authorship attribution just because the import script didn't check it, but just made it "unknown". An un-attributed patch is simply not acceptable in any serious project. It's much better to consider it an error than to say "ok". Linus -
May 16, 1:03 pm 2006
Eric W. Biederman
Re: [PATCH] Implement git-quiltimport
There are two practical problems with this. 1) quilt does not force any authorship information to be preserved, in the description, so this probably a common case. Although for most users just needing to specify --author sounds reasonable. 2) There are currently 84 out of roughly 1322 patches in 2.6.17-rc4-mm1 that git-mailinfo cannot compute the author for. Generally the information is there but in such an irregular form that it cannot be automatically detected. If we can r...
May 16, 1:53 pm 2006
Junio C Hamano
Re: [PATCH] Implement git-quiltimport
I agree it is probably a good way to error by default, optinally allowing to say "don't care". I do not think Linus would pull from such a tree or trees branched from it into his official tree, so I do not think we would need to worry about commits with incomplete information propagating for this particular "gitified mm" usage. But as a general purpose tool to produce "gitified quilt series" tree, we would. It depends on the expected use of the resulting gitified mm tree. If it is for an in...
May 16, 3:01 pm 2006
Jakub Narebski
Re: gateway status?
Eric Wong &lt;normalperson@yhbt.net&gt; wrote: in "[0/2 PATCH] git-svn 1.0.0 release" thread http://permalink.gmane.org/gmane.comp.version-control.git/19644 &gt; It's been very solid for a long time now.
May 16, 9:54 am 2006
Sam Song
Fwd: [OT] Re: Git via a proxy server?
Hello, With above usage on GIT_PROXY_COMMAND, I still have problem on connection with remote git repository. I also tried setting http_proxy directly but the same result. It's first usage of git in our network. Well, need I enable the git port 9418 at proxy server? Or did I miss sth or what? I use git-2006-05-14.tar.gz package on FC3. Method I : Use GIT_PROXY_COMMAND [root@sam u-boot]# git clone \ git://www.denx.de/git/u-boot.git u-boot-denx.git fatal: exec failed fetch-pack fro...
May 16, 8:13 am 2006
Petr Vandrovec
Re: Fwd: [OT] Re: Git via a proxy server?
Yes. Try running 'socket 192.168.40.99 80', and type CONNECT 204.152.191.37:9418 HTTP/1.0 Proxy-Authorization: Basic &lt;yoursecret,f.e.wget -d should reveal this to you&gt; &lt;empty line&gt; You should get back user readable diagnostics what went wrong. Yes, your admin Is $GIT_PROXY_COMMAND executable? (just in case...) Try 'strace -f git clone What is '&lt;um&gt;' and '&lt;pwd&gt;' ? socket just connects somewhere, so if you are supposed to use &lt;username&gt;:&lt;pwd&gt; to connec...
May 16, 9:11 am 2006
Sam Song
Re: Fwd: [OT] Re: Git via a proxy server?
I cannot run "socket" and "CONNECT" on Fedora Core 3. It simply told me that no such command. How could I Seems you tried proxy-cmd.sh on Debian. Which distribution did you use? Thanks a lot, Sam __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com -
May 16, 11:56 pm 2006
Timo Hirvonen
[PATCH] Simplify packing public repositories
Support "git repack project.git" syntax which is more intuitive than using the GIT_DIR environment variable. Signed-off-by: Timo Hirvonen &lt;tihirvon@gmail.com&gt; --- git-repack.sh | 27 ++++++++++++++++++++++++--- 1 files changed, 24 insertions(+), 3 deletions(-) c09c41750023e5b502312ddaa21bf5a2371e66ac diff --git a/git-repack.sh b/git-repack.sh index 4fb3f26..b24cd1a 100755 --- a/git-repack.sh +++ b/git-repack.sh @@ -3,8 +3,8 @@ # # Copyright (c) 2005 Linus Torvalds # -USAG...
May 16, 7:46 am 2006
Sean
Re: [PATCH] Simplify packing public repositories
On Tue, 16 May 2006 14:46:35 +0300 There are a few commands that would benefit from being easier to run in a bare repository. If this option was added to the "git" wrapper rather than git-repack, it would work for all of them. But maybe git could just automatically recognize when it's in a bare repository. Sean -
May 16, 7:47 am 2006
Jakub Narebski
Re: [PATCH] CMIT_FMT_EMAIL: Q-encode Subject: and display-na...
I guess that we also need MIME-Version: 1.0 (from what I remember of troubles with Eoutlook Express not sending all the required headers, and tin not working properly). If I remember correctly encoding headers using quoted-printable is needed only because headers are before charset is set. IIRC there was proposal to use UTF-8 for headers regardless of the charset used for body of message. P.S. Should we set User-Agent header as well? -- Jakub Narebski Warsaw, Poland -
May 16, 6:38 am 2006
Simeon Kuhn
Buy popular drugs online.
The objective of this guide is to save you time and money. http://jrtz.s0g0fjffg7f0aaa3fsslxaaa.sluggingmc.com/?efvck -
May 16, 6:21 am 2006
Junio C Hamano
[PATCH] CMIT_FMT_EMAIL: Q-encode Subject: and display-name p...
By convention, the commit message and the author/committer names in the commit objects are UTF-8 encoded. When formatting for e-mails, Q-encode them according to RFC 2047. While we are at it, generate the content-type and content-transfer-encoding headers as well. Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt; --- With this patch, the output formatted with git show --pretty=email --patch-with-stat 9d7f73d4 would start like this: From 9d7f73d43fa49d0d2f5a8cfcce9d659e8ad2d...
May 16, 6:18 am 2006
Rocco Rutte
Re: [PATCH] CMIT_FMT_EMAIL: Q-encode Subject: and display-na...
Hi, * Junio C Hamano [06-05-16 03:18:24 -0700] wrote: To write an encoder really fully conforming to RfC2047 is a mess. Not so much because the algorithms are difficult but because there're many things to take care of if you want to do it right. For example, encoded words are required to be at most something below 80 characters long. For names this maybe is not an issue, but for subjects. I didn't really check whether your patch produces only the minimum encoding (i.e. only those words that ...
May 16, 6:49 am 2006
Li Yang-r58472
newbie question
I just starting to use git recently. I have setup a public repository, and pushed cloned open source repository to it. As most documents suggested, I need to run a repack on the public repository. Normally git-repack is run in the source directory(the parent directory of .git). Considering the public repository, there is no source directory and the *.git is the uppest level directory. Where am I supposed to run the git-repack command? -
May 16, 3:03 am 2006
Matthias Kestenholz
Re: newbie question
Hello, Do it like that: $ ls project.git $ GIT_DIR=project.git git-repack -a -d -
May 16, 3:09 am 2006
Fredrik Kuivinen
[PATCH] Update the documentation for git-merge-base
Signed-off-by: Fredrik Kuivinen &lt;freku045@student.liu.se&gt; --- Is the code guaranteed to return a least common ancestor? If that is the case we should probably mention it in the documentation. Documentation/git-merge-base.txt | 18 ++++++++++++++---- 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/Documentation/git-merge-base.txt b/Documentation/git-merge-base.txt index d1d56f1..6099be2 100644 --- a/Documentation/git-merge-base.txt +++ b/Documentation/git-merge-ba...
May 16, 1:58 am 2006
Junio C Hamano
Re: [PATCH] Update the documentation for git-merge-base
Unfortunately, no, if you mean by "least common" closest to the tips. See the big illustration at the top of the source for how you can construct pathological case to defeat an attempt to guarantee such. --all guarantees that the output contains all interesting ones, but does not guarantee the output has no suboptimal merge bases. -
May 16, 2:13 am 2006
Fredrik Kuivinen
Re: [PATCH] Update the documentation for git-merge-base
By "least" I mean the following: C is a least common ancestor of A and B if: * C is a common ancestor of A and B, and * for every other common ancestor D (different from C) of A and B, C There are two examples at the top of the source. In the first one a least common ancestor is returned. As I interpret the second one, it is an example of how the old algorithm without the postprocessing step produced a common ancestor which is not least. Am I wrong? Do we have any cases where the current m...
May 16, 2:54 am 2006
Linus Torvalds
Re: [PATCH] Update the documentation for git-merge-base
Yes, git-merge-base should always return a least common ancestor, never anything less. The only question is what happens when there are multiple LCA commits. In fact, even in that case git-merge-base will have a pretty strong specification: "git-merge-base with the '--all' flag will return the complete set of least common ancestors, sorted by most recent (as defined purely by the commit date order, not any graph ordering) first. Without the '--all' flag, it will return just...
May 16, 11:32 am 2006
Linus Torvalds
Re: [PATCH] Update the documentation for git-merge-base
Side note: since LCA's are (by definition) never going to have a direct graph relationship, there is obviously no ordering enforced by the graph itself. So they're all unordered in the graph sense, but you could use other measures of "distance" in the graph. Example other orderings that we _could_ do, and I considered (some purely graph based, others based on content): - order by number of commits between the LCA and the two commits that we are trying to find the LCA for (the "tips...
May 16, 12:32 pm 2006
Junio C Hamano
Re: [PATCH] Update the documentation for git-merge-base
Ah, yes, I remember now. The drawing was done while we were working on the solution to that pathological case; mark_reachable_commits() solves that horizon effect. http://article.gmane.org/gmane.comp.version-control.git/11410 http://article.gmane.org/gmane.comp.version-control.git/11429 http://article.gmane.org/gmane.comp.version-control.git/11552 http://article.gmane.org/gmane.comp.version-control.git/11613 However, our inability to come up with one is not a nonexistence pr...
May 16, 3:51 am 2006
previous daytodaynext day
May 15, 2006May 16, 2006May 17, 2006
speck-geostationary