Re: [PATCH] Fix git-pack-objects for 64-bit platforms

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Thursday, May 11, 2006 - 10:58 am

On Thu, 11 May 2006, Dennis Stosberg wrote:

I think the "ntohl()" hides it. It loads a 64-bit value, but since x86-64 
is little-endian, the low 32 bits are correct. The htonl() will then strip 
the high bits and make it all be big-endian.

And while I actually run a 64-bit big-endian machine myself (G5 ppc64), my 
user space is all 32-bit by default, so it never showed up on linux-ppc64 
either.

Anyway, the correct type to use is "uint32_t" in this case. That's what 
htonl() takes.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Fix git-pack-objects for 64-bit platforms, Dennis Stosberg, (Thu May 11, 10:36 am)
Re: [PATCH] Fix git-pack-objects for 64-bit platforms, Linus Torvalds, (Thu May 11, 10:58 am)
Re: [PATCH] Fix git-pack-objects for 64-bit platforms, Junio C Hamano, (Thu May 11, 11:52 am)
Re: [PATCH] Fix git-pack-objects for 64-bit platforms, Linus Torvalds, (Thu May 11, 12:10 pm)
Re: [PATCH] Fix git-pack-objects for 64-bit platforms, Linus Torvalds, (Thu May 11, 12:27 pm)
Re: [PATCH] Fix git-pack-objects for 64-bit platforms, Junio C Hamano, (Fri May 12, 10:58 pm)
Re: [PATCH] Fix git-pack-objects for 64-bit platforms, Ben Clifford, (Sun May 14, 1:56 pm)