login
Header Space

 
 

Re: gitview 0.3

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Aneesh Kumar <aneesh.kumar@...>
Cc: <git@...>
Date: Thursday, February 2, 2006 - 2:13 am

Nice work for 0.low-number version.

On my notebook, I felt really miserable to see that the middle
band taking so much space to show rev committer timestamp and
parents.  The bottom window starts with the same information
repeated (worse, with unreadable timestamp format) and I had to
scroll all the way down to view the rest of the commit message.

If you absolutely want the middle band, maybe instead of showing
object names in "Parents" "Children" part, you can show the
one-line commit logs from them there, and pop-up the object
names along with the rest of commit log message as mouse hovers
over.

I missed "this commit is branch head of X" and "this commit is
tagged with T" markers gitk has.

Needs a bit more compact layout to be useful for me.  In short,
gitk's display does everything I want it to show in a compact
enough way and I think there is no reason not to imitate it.

Do colors of nodes have any significance?  I couldn't tell from
the UI (and I tried to figure it out without reading code --
otherwise I cannot tell if the choice of colors is intuitive).

It might match more people's expectation if --with-diff were the
default.

This patch might make merges easier to read.

-- >8 --
[PATCH] Use "diff-tree -c" to display merges a bit more readably.

--- a/gitview	2006-02-01 21:16:43.000000000 -0800
+++ b/gitview	2006-02-01 21:46:24.000000000 -0800
@@ -305,7 +305,7 @@
 		return message
 
 	def diff_tree(self):
-		fp = os.popen("git diff-tree --pretty -m -v -p " + " " + self.commit_sha1)
+		fp = os.popen("git diff-tree --pretty -c -v -p " + " " + self.commit_sha1)
 		diff = fp.read()
 		fp.close()
 


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
gitview 0.3, Aneesh Kumar, (Thu Feb 2, 12:33 am)
[PATCH] Fix date display, Jonas Fonseca, (Thu Feb 2, 8:21 am)
Re: gitview 0.3, Junio C Hamano, (Thu Feb 2, 2:13 am)
Re: gitview 0.3, Aneesh Kumar, (Thu Feb 2, 12:03 pm)
Re: gitview 0.3, Aneesh Kumar, (Thu Feb 2, 3:15 am)
speck-geostationary