Re: [PATCH] cvsserver: Avoid miscounting bytes in Perl v5.8.x

Previous thread: Topic descriptions by Andy Parkins on Wednesday, December 6, 2006 - 5:53 pm. (7 messages)

Next thread: [PATCH] Add config example with respect to branch by Aneesh Kumar K.V on Thursday, December 7, 2006 - 2:36 am. (2 messages)
To: <junkio@...>, <git@...>
Cc: Martin Langhoff <martin@...>
Date: Wednesday, December 6, 2006 - 11:38 pm

At some point between v5.6 and 5.8 Perl started to assume its input,
output and filehandles are UTF-8. This breaks the counting of bytes
for the CVS protocol, resulting in the client expecting less data
than we actually send, and storing truncated files.

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
---

This has gone unfixed for quite a while. I thought I had seen
a patch posted addressing it, but it may have been for something else.

In fact, our heavily patched gitweb.cgi has needed a similar patch
as well. Snapshot downloads were getting corrupted until we added
use bytes; there too. I'm not sure how current gitweb does it though...

---
git-cvsserver.perl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index ca519b7..197014d 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -17,6 +17,7 @@

use strict;
use warnings;
+use bytes;

use Fcntl;
use File::Temp qw/tempdir tempfile/;
--
1.4.4.1.g7923a

-

To: Martin Langhoff <martin@...>
Cc: <git@...>
Date: Thursday, December 7, 2006 - 1:48 am

Thanks. Will queue for both maint and master.

-

Previous thread: Topic descriptions by Andy Parkins on Wednesday, December 6, 2006 - 5:53 pm. (7 messages)

Next thread: [PATCH] Add config example with respect to branch by Aneesh Kumar K.V on Thursday, December 7, 2006 - 2:36 am. (2 messages)