Re: [PATCH 2/3] git-fetch: do not use "*" for fetching multiple refs

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Michael Loeffler <zvpunry@...>
Cc: <git@...>
Date: Wednesday, December 6, 2006 - 2:37 pm

Michael Loeffler <zvpunry@zvpunry.de> writes:


Please, don't do regex when talking about paths.  Uniformly
using fnmatch/glob is less confusing.  I do not see anything
wrong with Andy's refspec glob we already have.  Although I
agree that the second asterisk in "src/*:dst/*" has a certain
"Huh?" factor to UNIX-trained eyes, I think it is quite obvious
even to new people what it does.

Also, while I agree that (2) is logical and less typing, I would
avoid cases where foo and foo/ behave differently when "foo"
itself is a directory/tree like thing.  Doing otherwise easily
invites mistakes.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 2/3] git-fetch: do not use "*" for fetching multi..., Johannes Schindelin, (Wed Dec 6, 7:21 pm)
Re: [PATCH 2/3] git-fetch: do not use "*" for fetching multi..., Junio C Hamano, (Wed Dec 6, 2:37 pm)