Re: [RFC] Two conceptually distinct commit commands

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Carl Worth
Date: Monday, December 4, 2006 - 6:18 pm

On Mon, 04 Dec 2006 21:52:38 -0300, "Horst H. von Brand" wrote:

The semantics I intended to describe for commit-working-tree-content
would not add this file. That's a "new file" so would have to be
mentioned either explicitly on the command-line or in a git-add
command before it would be committed.


OK, you've found a bug in my description above, (though not in the
intended semantics). By "rename...detected automatically" I meant only
that the fact that a file has "disappeared" as part of a rename need
not be mentioned to git. The fact that the contents are made available
as a new file name still would need to be told to git with "git add",
(or would be worthwhile to mention "git mv" I suppose).


Perhaps I was too oblique in calling this thing
commit-working-tree-contents. This isn't some fabricated-from-scratch
command. The intent of my message was that readers would recognize the
description as matching what the current "commit -a" and "commit
files..."  commands do. So I really wasn't trying to invent anything
really different than those. So almost any problems of unexpected
behavior you can find almost surely apply to "commit -a" already.

I did throw one new thing into the description, (that does not exist
in current git). That's the mention that new files could be added by
mentioning them explicitly on the command-line. This was intended as a
way to allow a tutorial to sidestep the details of how "git add"
interacts with the index. If this one feature is a bad idea, it could
be dropped with no impact on the rest of the proposal nor my
discussion of it.

Similarly, I worded the mention of "git add" to suggest it be done
"just prior to the commit". Again, I did this just to avoid having to
mention anything about the need to "git add" again if the file was
edited between the time of add and the time of commit. That language
is already proposed for the git-add documentation, so there's no need
to repeat it all here.

-Carl
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] Two conceptually distinct commit commands, Carl Worth, (Mon Dec 4, 12:08 pm)
Re: [RFC] Two conceptually distinct commit commands, Carl Worth, (Mon Dec 4, 1:10 pm)
Re: [RFC] Two conceptually distinct commit commands , Horst H. von Brand, (Mon Dec 4, 5:52 pm)
Re: [RFC] Two conceptually distinct commit commands , Carl Worth, (Mon Dec 4, 6:18 pm)
Re: [RFC] Two conceptually distinct commit commands , Horst H. von Brand, (Mon Dec 4, 7:14 pm)
Re: [RFC] Two conceptually distinct commit commands, Theodore Tso, (Mon Dec 4, 8:51 pm)
Re: [RFC] Two conceptually distinct commit commands, Junio C Hamano, (Mon Dec 4, 11:33 pm)
Re: [RFC] Two conceptually distinct commit commands, Carl Worth, (Mon Dec 4, 11:38 pm)
Re: [RFC] Two conceptually distinct commit commands, Junio C Hamano, (Tue Dec 5, 6:13 pm)
Re: [RFC] Two conceptually distinct commit commands, Carl Worth, (Tue Dec 5, 9:53 pm)
Commit order in git.git, was Re: [RFC] Two conceptually di ..., Johannes Schindelin, (Wed Dec 6, 2:54 am)
Re: [RFC] Two conceptually distinct commit commands, Carl Worth, (Wed Dec 6, 9:14 am)