Home » Mailing list archives » git » 2006 » December » 28

[PATCH/RFT] Work around http-fetch built with cURL 7.16.0

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Junio C Hamano <junkio@...>
To: <git@...>
Subject: [PATCH/RFT] Work around http-fetch built with cURL 7.16.0
Date: Thursday, December 28, 2006 - 8:40 pm

It appears that curl_easy_duphandle() from libcurl 7.16.0
returns a curl session handle which fails GOOD_MULTI_HANDLE()
check in curl_multi_add_handle().  This causes fetch_ref() to
fail because start_active_slot() cannot start the request.

For now, check for 7.16.0 to work this issue around.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

 * I think people who were having trouble with cURL 7.16.0 want
   to have the issue resolved before v1.5.0-rc1.  Please test
   and report, or else ;-).

 http.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/http.h b/http.h
index 6e12e41..324fcf4 100644
--- a/http.h
+++ b/http.h
@@ -18,7 +18,7 @@
 #define curl_global_init(a) do { /* nothing */ } while(0)
 #endif
 
-#if LIBCURL_VERSION_NUM < 0x070c04
+#if (LIBCURL_VERSION_NUM < 0x070c04) || (LIBCURL_VERSION_NUM == 0x071000)
 #define NO_CURL_EASY_DUPHANDLE
 #endif
 
-- 
1.5.0.rc0.gf5c587


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
http git and curl 7.16.0, George Sherwood, (Sat Nov 18, 12:07 am)
Re: http git and curl 7.16.0, Sven Verdoolaege, (Sun Dec 17, 7:32 am)
Re: http git and curl 7.16.0 , Horst H. von Brand, (Wed Dec 27, 10:57 am)
Re: http git and curl 7.16.0, Junio C Hamano, (Wed Dec 27, 3:53 pm)
Re: http git and curl 7.16.0 , Horst H. von Brand, (Wed Dec 27, 9:35 pm)
Re: http git and curl 7.16.0, Shawn Pearce, (Wed Dec 27, 9:42 pm)
Re: http git and curl 7.16.0, Junio C Hamano, (Wed Dec 27, 5:46 pm)
[PATCH/RFT] Work around http-fetch built with cURL 7.16.0, Junio C Hamano, (Thu Dec 28, 8:40 pm)
Re: [PATCH/RFT] Work around http-fetch built with cURL 7.16.0 , Horst H. von Brand, (Fri Dec 29, 8:37 am)