login
Header Space

 
 

Re: [PATCH] merge-recursive: add/add really is modify/modify with an empty base

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Catalin Marinas <catalin.marinas@...>
Cc: Johannes Schindelin <Johannes.Schindelin@...>, <git@...>
Date: Wednesday, December 13, 2006 - 6:26 pm

"Catalin Marinas" <catalin.marinas@gmail.com> writes:


The calls to xdl_merge() from merge-recursive replace
invocations to external "merge" from RCS suite.

An older merge-recursive had a bug (as you noticed and adjusted
StGIT with the commit 8d41555) in that it did not leave anything
in the working tree in add/add situation, while merge-resolve
would have left its best attempt of ancestor-less two file merge
(which is not necessarily the straight diff3 "no common section,
full copies from both" result).  The change in question corrects
that problem and merge-recursive would create a file in the
working tree just like merge-resolve would.

You were CC'ed just in case this change in behaviour might
interact with the abovementioned change in StGIT, but as you say
the change would not break StGIT, we would all be happy ;-).

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 3/3] add test case for recursive merge, Johannes Schindelin, (Sat Dec 9, 7:56 pm)
Re: [PATCH 3/3] add test case for recursive merge, Johannes Schindelin, (Sat Dec 9, 8:18 pm)
Re: [PATCH 3/3] add test case for recursive merge, Junio C Hamano, (Sat Dec 9, 11:10 pm)
[PATCH] t6024: fix timing problem, Johannes Schindelin, (Tue Dec 12, 6:49 pm)
Re: [PATCH] t6024: fix timing problem, Junio C Hamano, (Tue Dec 12, 7:23 pm)
[PATCH] merge-recursive: add/add really is modify/modify wit..., Johannes Schindelin, (Tue Dec 12, 11:05 pm)
Re: [PATCH] merge-recursive: add/add really is modify/modify..., Johannes Schindelin, (Wed Dec 13, 7:48 pm)
Re: [PATCH] merge-recursive: add/add really is modify/modify..., Johannes Schindelin, (Thu Dec 14, 9:44 am)
Re: [PATCH] merge-recursive: add/add really is modify/modify..., Junio C Hamano, (Wed Dec 13, 6:26 pm)
StGit repo &amp; gitweb, was Re: [PATCH] merge-recursive: ad..., Johannes Schindelin, (Wed Dec 13, 7:46 am)
Re: StGit repo &amp; gitweb, was Re: [PATCH] merge-recursive..., Johannes Schindelin, (Wed Dec 13, 7:50 pm)
Re: [PATCH] t6024: fix timing problem, Johannes Schindelin, (Tue Dec 12, 7:59 pm)
Re: [PATCH 3/3] add test case for recursive merge, Johannes Schindelin, (Sun Dec 10, 6:51 pm)
[PATCH 2/3] merge-recursive: make empty tree a known object, Johannes Schindelin, (Sat Dec 9, 7:56 pm)
Re: [PATCH 2/3] merge-recursive: make empty tree a known obj..., Johannes Schindelin, (Sun Dec 10, 7:16 pm)
[PATCH 1/3] diff_tree_sha1(): avoid rereading trees if possi..., Johannes Schindelin, (Sat Dec 9, 7:55 pm)
speck-geostationary