Home » Mailing list archives » git » 2006 » December » 10

Re: [PATCH] editor: make sure $EDITOR is executed as a command

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Clemens Buchacher <drizzd@...>
To: <git@...>
Subject: Re: [PATCH] editor: make sure $EDITOR is executed as a command
Date: Sunday, December 10, 2006 - 10:04 am

Hi,

Sorry about the missing subject.

Make sure $EDITOR is executed as a command. Otherwise, _editor may fail if
$EDITOR is set to something like 'editor', which is also a function within
cg-Xlib.

Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
commit 942341e051fdcbb77a6abfbc58cf08ef8cab388d
tree 96e8fd08cdc7c59b0d3d55d7cb5b4302db443aff
parent b6a6e87cb3e1368ad0f78c18fdb6c29dde4ae83e
author Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100
committer Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100

 cg-Xlib |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cg-Xlib b/cg-Xlib
index c1262bf..9d04eb4 100755
--- a/cg-Xlib
+++ b/cg-Xlib
@@ -568,7 +568,7 @@ _editor()
 	actionname="$1"; shift
 	actionkey="$1"; shift
 
-	${EDITOR:-vi} "$LOGMSG2"
+	command ${EDITOR:-vi} "$LOGMSG2"
 	[ -z "$force" ] || return 0
 	[ ! "$LOGMSG2" -nt "$LOGMSG" ] || return 0
 
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
*** SPAM *** , Clemens Buchacher, (Sun Dec 10, 9:57 am)
Re: [PATCH] editor: make sure $EDITOR is executed as a command, Clemens Buchacher, (Sun Dec 10, 10:04 am)