Home » Mailing list archives » git » 2006 » December » 10

*** SPAM ***

Previous thread: Using GIT to store /etc (Or: How to make GIT store all file permission bits) by Kyle Moffett on Sunday, December 10, 2006 - 9:40 am. (23 messages)

Next thread: Re: Using GIT to store /etc (Or: How to make GIT store all file permission bits) by Jakub Narebski on Sunday, December 10, 2006 - 11:30 am. (9 messages)
[view original message]
From: Clemens Buchacher <clemens.buchacher@...>
To: <git@...>
Subject: *** SPAM ***
Date: Sunday, December 10, 2006 - 9:57 am

Make sure $EDITOR is executed as a command


---

commit 942341e051fdcbb77a6abfbc58cf08ef8cab388d

tree 96e8fd08cdc7c59b0d3d55d7cb5b4302db443aff

parent b6a6e87cb3e1368ad0f78c18fdb6c29dde4ae83e

author Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100

committer Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100


 cg-Xlib |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/cg-Xlib b/cg-Xlib

index c1262bf..9d04eb4 100755

--- a/cg-Xlib

+++ b/cg-Xlib

@@ -568,7 +568,7 @@ _editor()

 	actionname="$1"; shift

 	actionkey="$1"; shift


-	${EDITOR:-vi} "$LOGMSG2"

+	command ${EDITOR:-vi} "$LOGMSG2"

 	[ -z "$force" ] || return 0

 	[ ! "$LOGMSG2" -nt "$LOGMSG" ] || return 0


-
[view original message]
From: Clemens Buchacher <drizzd@...>
To: <git@...>
Subject: Re: [PATCH] editor: make sure $EDITOR is executed as a command
Date: Sunday, December 10, 2006 - 10:04 am

Hi,


Sorry about the missing subject.


Make sure $EDITOR is executed as a command. Otherwise, _editor may fail if

$EDITOR is set to something like 'editor', which is also a function within

cg-Xlib.


Signed-off-by: Clemens Buchacher <drizzd@aon.at>

---

commit 942341e051fdcbb77a6abfbc58cf08ef8cab388d

tree 96e8fd08cdc7c59b0d3d55d7cb5b4302db443aff

parent b6a6e87cb3e1368ad0f78c18fdb6c29dde4ae83e

author Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100

committer Clemens Buchacher <drizzd@aon.at> Sun, 10 Dec 2006 14:37:37 +0100


 cg-Xlib |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/cg-Xlib b/cg-Xlib

index c1262bf..9d04eb4 100755

--- a/cg-Xlib

+++ b/cg-Xlib

@@ -568,7 +568,7 @@ _editor()

 	actionname="$1"; shift

 	actionkey="$1"; shift


-	${EDITOR:-vi} "$LOGMSG2"

+	command ${EDITOR:-vi} "$LOGMSG2"

 	[ -z "$force" ] || return 0

 	[ ! "$LOGMSG2" -nt "$LOGMSG" ] || return 0


-
Previous thread: Using GIT to store /etc (Or: How to make GIT store all file permission bits) by Kyle Moffett on Sunday, December 10, 2006 - 9:40 am. (23 messages)

Next thread: Re: Using GIT to store /etc (Or: How to make GIT store all file permission bits) by Jakub Narebski on Sunday, December 10, 2006 - 11:30 am. (9 messages)