git mailing list

FromSubjectsort iconDate
Jon Smirl
Diffs from CVS keyword expansion
Anyone have a nice script for suppressing diffs caused by CVS keyword expansion when someone checked the kernel sources into CVS? I have 200,000 lines of various forms of this mixed in with real changes It is unclear who checked it into CVS, Microcross or Arch Linux. If it is Arch Linux finding the source for their 2.6.11.4-1 release would help a lot. I looked on their web site and couldn't locate it. I'm starting understand why the support for MX21 on a CSB535FS has never been added to the ...
Nov 30, 8:56 pm 2006
Jakub Narebski
Re: [RFC] Submodules in GIT
Hmmm... I thought the idea was that submodule commit is available in the object repository, be it via alternates mechanism pointing to the submodule repository for alternate storage, or submodule being in "unrelated" branch/tracking branch. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 5:11 pm 2006
Jakub Narebski
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
So, in short, -i is easier to explain, but is also least used. Perhaps also because one can simply update index with <files> before git commit instead of doing "git commit -i <files>". -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 5:06 pm 2006
Jakub Narebski
Re: git blame
Something like Cogito tutorial-script? -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 4:08 pm 2006
Johannes Schindelin
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Hi, I think this is so important, that I vote for including this email as Documentation/howto/explain-why-git-is-better-than-cvs.txt Ciao, Dscho -
Nov 30, 3:55 pm 2006
Nicolas Pitre
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
And personally I think this bastardizes the index. I think so far the index is not a problem. the problem is in the UI and in the doc. With a "git add" as I described it I don't think the user will ask for such thing. And let's have a "git diff --commit" be a much meaningful alias for the appropriate diff argument (which argument I always forget about myself) needed to show what is going to be committed. Nicolas -
Nov 30, 3:46 pm 2006
Nicolas Pitre
Re: [RFC] git-add update with all-0 object
Well, sure. It could be an argument to git-add. But surely not the default? git-add --latest maybe? Nicolas -
Nov 30, 3:49 pm 2006
Jakub Narebski
Re: [RFC] git-add update with all-0 object
Still, perhaps (perhaps!) it would be useful to have "intent to add" git-add. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 3:41 pm 2006
Johannes Schindelin
Re: [RFC] git-add update with all-0 object
Hi, I fear that this is just your being used to the CVS mindset. Please see http://article.gmane.org/gmane.comp.version-control.git/32792 for details. Hth, Dscho -
Nov 30, 3:32 pm 2006
Daniel Barkalow
[RFC] git-add update with all-0 object
One thing that I think is non-intuitive to a lot of users (either novice or who just don't do it much) is that it matters where in the process you do "git add <path>" if you're also changing the file. Even if you understand the index, you may not realize (or may not have internalized the fact) that what git-add does is update the index with what's there now. I think the more obvious behavior is to have it record the fact that you want to have the path tracked, but require one of the usual ...
Nov 30, 3:08 pm 2006
Daniel Barkalow
Re: [RFC] git-add update with all-0 object
I'm not sure I want to see the whole added file more when diffing two trees, or when I do "git diff --cached" after "git update-index --add", than when I do "git diff" after "git add", but I'll concede that viewing the content of a new file as a diff is no fun. (Maybe diff-against-nothing for display needs work in general? It's solve the whole root commit thing, This is where I think "git add" is really broken. For every other git command, if the command causes the index to not match ...
Nov 30, 5:12 pm 2006
Theodore Tso
Re: [RFC] git-add update with all-0 object
But it's not just this one wierd corner case. You yourself said that "git pull/merge" leave the index where it's != HEAD. I have serious trouble believing that "if the command leaves index != HEAD, the command must contain 'index' in either the name of the command or the option" is all that important of a consistent rule or principle that must be maintained at all costs. By the way, after thinking about this for a while, part of the problem is that the name "index" really sucks. ...
Nov 30, 9:57 pm 2006
Linus Torvalds
Re: [RFC] git-add update with all-0 object
While this certainly matches the git model better than just automatically taking whatever state exist at commit time (you instead introduce it as a special "empty state" case), I don't think you really want it. Why? Two reasons: - you're still left with all the same issues (ie you do need to use "git commit -a" because that is simply fundamental, and if you don't, "git commit" now causes an ERROR, which is just illogical - you just added the data!) So it's ...
Nov 30, 3:46 pm 2006
Nicolas Pitre
Re: [RFC] git-add update with all-0 object
And actually I think this is a good thing. This is what makes the index worth it. Better find a way to make it obvious to people what's happening. Nicolas -
Nov 30, 3:34 pm 2006
Jakub Narebski
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Index is accessible, just like committed contents. The fact that gitk, qgit, git-gui doesn't display state of index is their limitation. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 2:41 pm 2006
Junio C Hamano
Re: [RFD] making separate-remote layout easier to use
Think of it not as a difference between you and Shawn, but as a difference in me back then and me now, who finally saw the light in your revelation after gaining a year's worth of experience ;-). Seriously, I did not ignore it, and I think some of your other comments in the message contributed to improved documentation. When your message was posted, the issue Shawn raised in his message was not so prominent, because people did not even get that "Pull: refs/heads/pu:refs/heads/pu" line in ...
Nov 30, 2:22 pm 2006
Johannes Schindelin
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Hi, ... and suffer another thread a la "pull/merge"? Please no. Ciao, Dscho -
Nov 30, 3:26 pm 2006
Michael K. Edwards
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
git mark and git add becomes just a synonym for git mark. Cheers, - Michael -
Nov 30, 2:41 pm 2006
Jakub Narebski Nov 30, 2:16 pm 2006
Carl Worth
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
I actually thought of that. But compared to "refresh" it sounds more like something that suggests marking a file path rather than copying contents, so our dark lord might not approve of the wrong ideas it might allow to persist in brain-damaged heads. It is nice and short, which is a bonus though. -Carl
Nov 30, 2:50 pm 2006
Josef Weidendorfer Nov 30, 3:07 pm 2006
Jakub Narebski
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Dnia czwartek 30. listopada 2006 22:50, Carl Worth napisa
Nov 30, 2:58 pm 2006
Nicolas Pitre
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
I disagree. "add" is beautiful. It is short, easy to remember, and transcend pretty much what the index is all about. And just because "add" and "edited" can be made into the same command is a pretty damn good reason not to create a separate command. You "add" changes to the changeset then you commit that changeset. No need to care whether or not this is a new file, an edited file, etc. Nicolas -
Nov 30, 3:31 pm 2006
Johannes Schindelin
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Hi, I suggest "commit". How about this: after editing the file, you tell git that you finished editing it by doing git commit the-edited-file.txt Hmmm? Ciao, Dscho -
Nov 30, 3:25 pm 2006
Nicolas Pitre Nov 30, 3:37 pm 2006
Junio C Hamano
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
checkin. You check things into index with "git checkin" and later commit the index with "git commit". -
Nov 30, 3:47 pm 2006
Carl Worth
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
I'm happy with the direction of having several commands that take the place of update-index, each with its own name oriented toward what the user wants to do. Obviously, "add", "mv", and "rm" have obvious places where the user wants to use them. There's the merge case where "resolve" and "resolved" have both been floated as possible names. It might even make sense to invent one more name for the case where the user wants to inform git that a file has been edited and that git should ...
Nov 30, 2:37 pm 2006
Junio C Hamano
Re: [BUG] git-fetch -k is broken
True, but your "echo" patch breaks things even more -- when fast forward check fails, it should cause the entire command should report that with the exit status. That suggests that we need to come up with a way to clean up these .keep files some other way than just being one of the command near the end. As to the mysterious "echo e <empty>" I will not have chance to look at it myself until later today (I'm at work now and it is not my git day today). -
Nov 30, 2:21 pm 2006
Nicolas Pitre
[BUG] git-fetch -k is broken
Actually, the .keep file is simply not removed as it should. But first it appears that commit f64d7fd2 added an && on line 431 of git-fetch.sh and that cannot be right. There is simply no condition for not removing the lock file. It must be removed regardless if the previous command succeeded or not. Junio? Now for the actual problem. I instrumented git-fetch.sh to understand what's going on as follows: diff --git a/git-fetch.sh b/git-fetch.sh index 8365785..042040e 100755 --- ...
Nov 30, 1:11 pm 2006
Jakub Narebski
Re: git and bzr
Theodore Tso wrote: >
Nov 30, 1:09 pm 2006
Carl Worth
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Yes. There is a logical explanation for what git does, and it is self-consistent. It just means that the user is _forced_ to pass file state across the: "working tree" -> git boundary at two different times with two different commands for the very first commit the user makes. And the user _must_ understand that this is a two-step process, (even though, without the "typo" in my example above it would be natural to conclude the transition occurred only during "commit"). See? Git _is_ ...
Nov 30, 12:04 pm 2006
Jakub Narebski
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
while in git "git add" means "I want to add this file" (in the state it is now) and not "I want the system to 'know' about this file". And "commit" mean "Please commit the current 'known' state of all files (or/and the current state of files I mention here on the comand line)". Yes, this is different than what other SCM do... -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 11:47 am 2006
Peter Baumann
[PATCH] Use git-rev-parse --git-dir to determine GIT_DIR
Signed-off-by: Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de> --- gitk | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/gitk b/gitk index ab383b3..60f8212 100755 --- a/gitk +++ b/gitk @@ -8,12 +8,7 @@ exec wish "$0" -- "$@" # either version 2, or (at your option) any later version. proc gitdir {} { - global env - if {[info exists env(GIT_DIR)]} { - return $env(GIT_DIR) - } else { - return ".git" - } + return [exec git ...
Nov 30, 9:45 am 2006
Alex Riesen
[PATCH 2/2] add a flag to disable using of Perls MakeMak ...
There installations (Cygwin + ActivateState Perl) where the generated makefiles are not usable, because of lineendings and backslashes. The flags is NO_PERL_MAKEMAKER. Signed-off-by: Alex Riesen <raa.lkml@gmail.com> --- Just remembered configure script. Maybe it could be taught to notice the situation and do something about it (like setting the NO_MAKEMAKER).
Nov 30, 9:30 am 2006
Jakub Narebski Nov 30, 9:28 am 2006
Jakub Narebski
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
You can ^C the git-commit invocation. And I guess ORIG_HEAD would help, and reflog certainly would help reverting (undoing) amend of a commit. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 9:05 am 2006
Catalin Marinas
Re: How to prepend data when formatting patches ?
In the headers or in the message body? StGIT adds this line automatically in the message body (and recently only if the sender is different from the patch author but the templates are flexible and can be changed). -- Catalin -
Nov 30, 9:00 am 2006
Francis Moreau
Re: How to prepend data when formatting patches ?
I stupily thought that it couldn't be used to prepend message for the message body. But since it appends the line at the end of mail header, it does the right thing for me. Thanks for your quick answer -- Francis -
Nov 30, 9:16 am 2006
Francis Moreau
How to prepend data when formatting patches ?
Hi I'd like to add to all patchs created by "git-format-patch" command the following line: From: xxx.yyy <foo@crazy.com> I took a look to the command options and git's hooks but I don't find a solution to this problem. Is there any tricks to do this ? thanks -- Francis -
Nov 30, 7:16 am 2006
Johannes Schindelin
Re: How to prepend data when formatting patches ?
Hi, From Documentation/git-format-patch.txt: -- snip -- CONFIGURATION ------------- You can specify extra mail header lines to be added to each message in the repository configuration as follows: [format] headers = "Organization: git-foo\n" -- snap -- Hth, Dscho -
Nov 30, 8:39 am 2006
Francis Moreau
Re: How to prepend data when formatting patches ?
Hi Johannes adviced me to use: [format] headers = "Organization: git-foo\n" configuration. And it works both for mail header and message body. thanks -- Francis -
Nov 30, 9:19 am 2006
Sven Verdoolaege
Re: [RFC] Submodules in GIT
How are you going to checkout the right commit of the lixcb repo if you didn't store it in the supermodule ? skimo -
Nov 30, 8:20 am 2006
sf
Re: [RFC] Submodules in GIT
Right now you only have commits of the top directory aka the super project. Every subdirectory is just that: a directory (which git stores as trees). Now, if you have a subdirectory that git stores as a commit, not a tree, you have a subproject. It is a directory with history, and because the No, it is not. Currently, there is no way to store a commit within the Here comes the part where we did not meet before. Of course you do not make any reference from your subproject to ...
Nov 30, 9:05 am 2006
Andy Parkins
Re: [RFC] Submodules in GIT
How are these commits any different from just having one big repository? If some of the development of the submodule is contained in the supermodule then it's not a submodule anymore. Why bother with all the effort to make a separation between submodule and supermodule and then store the submodule commits in the supermodule. That's not supermodule/submodule git - that's just normal git. Surely the whole point of having submodule's is so that you can take the submodule away. Let me ...
Nov 30, 7:49 am 2006
Stephan Feder
Re: [RFC] Submodules in GIT
But you have got the submodule on your local disk anyway. So just setup It works as it always works in git: The supermodule commit contains the submodule commit, the submodule commit contains the submodule files, so the supermodule contains the submodule (at least the part of the submodule that is visible). It _must_ be one repository but it need not Again I do not see the problem. Probably I have a much simpler picture of submodules: They are just commits in the supermodule's tree. ...
Nov 30, 7:00 am 2006
sf
Re: [RFC] Submodules in GIT
sf wrote: Sorry, that was supposed to read: followed by a suffix // The :: does not belong in there. -
Nov 30, 9:12 am 2006
Andy Parkins
Re: [RFC] Submodules in GIT
It's not so much an actual commit, as a reference to a commit in another repository. Andy -- Dr Andrew Parkins, M Eng (Hons), AMIEE andyparkins@gmail.com -
Nov 30, 5:01 pm 2006
Sven Verdoolaege
Re: [RFC] Submodules in GIT
Then I have no idea what you are talking about. A commit _contains_ all the history that lead up to that commit, so if you have the commit, then you also have the history. skimo -
Nov 30, 9:33 am 2006
Andy Parkins
Re: [RFC] Submodules in GIT
Not entirely, although I think it's going to be handy for submodules. It was in a thread about remotes branches. By allowing checkout of any commit rather than only those that have a ref/heads/ entry, you effectively have a read-only checkout. You obviously couldn't commit to a repository like this, because HEAD wouldn't point at anything that is changeable. It would be very easy to just git-branch from there and start work though. I think it's going to be necessary for the submodule ...
Nov 30, 9:08 am 2006
Andy Parkins
Re: [RFC] Submodules in GIT
Well, I know what the commit is /that/ was all that was stored. So I (actually supermodule-git does): cd $DIRECTORY_ASSOCIATED_WITH_SUBMODULE git checkout -f $COMMIT_FROM_SUPERMODULE Obviously, this is grossly simplified. It also requires that HEAD be allowed to be an arbitrary commit rather than a branch, but that's already been generally agreed upon as a good thing. Andy -- Dr Andy Parkins, M Eng (hons), MIEE andyparkins@gmail.com -
Nov 30, 8:30 am 2006
Andreas Ericsson
Re: [RFC] Submodules in GIT
I believe that Andy meant "development history" in his above scentence. Naturally, using the code from the submodule while being capable of developing the submodule separately from the supermodule is what It has? We're not talking supermodule specific things anymore, are we? -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 -
Nov 30, 8:50 am 2006
Martin Waitz
Re: [RFC] Submodules in GIT
hoi :) It's not that easy. You also have to make sure that all your submodule commits that _ever_ have been part of your submodule have be stay in your repository forever. Consider that your submodule switches to an other branch and some old commits are not referenced by the current version any more. These old commits still have to survive a git-prune, if they have been part of some old supermodule version. So you really have to connect both object databases and it's not enough to just ...
Nov 30, 10:19 am 2006
Jakub Narebski
Re: [PATCH] Make git-commit cleverer - have it figure ou ...
Well, if it is VISUAL editor, you would see this. But adding this to template is certainly good idea. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 6:41 am 2006
Andy Parkins
[PATCH] Make git-commit cleverer - have it figure out wh ...
Raimund Bauer offered this suggestion (paraphrased): "Maybe we could do git-commit -a _only_ if the index matches HEAD, and otherwise keep current behavior? So people who don't care about the index won't get tripped up, and when you do have a dirty index, you get told about it?" Johannes Schindelin pointed out that this isn't the right thing to do for an --amend, so that is checked for. Additionally, it's probably not the right thing to do if any files are specified with "--only" or ...
Nov 30, 6:24 am 2006
Johannes Schindelin
Re: [PATCH/RFC] Make git-commit cleverer - have it figur ...
Hi, Only that you would not see it (or ignore it, as has been illustrated in another thread), because your editor pops up, hiding that message. Ciao, Dscho -
Nov 30, 8:34 am 2006
Nguyen Thai Ngoc Duy
Re: [PATCH] Make git-commit cleverer - have it figure ou ...
This is hardly seen as the editor will immediately pop up. Better -- Duy -
Nov 30, 6:32 am 2006
Jakub Narebski
Re: [PATCH/RFC] Make git-commit cleverer - have it figur ...
Could we add suggestion by Andreas Ericsson to print in the "smart commit" case: Nothing to commit but changes in working tree. Assuming 'git commit -a' or something like that? -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 6:13 am 2006
Salikh Zakirov Nov 30, 8:43 am 2006
Andy Parkins
[PATCH] Make git-commit cleverer - have it figure out wh ...
Raimund Bauer offered this suggestion (paraphrased): "Maybe we could do git-commit -a _only_ if the index matches HEAD, and otherwise keep current behavior? So people who don't care about the index won't get tripped up, and when you do have a dirty index, you get told about it?" Johannes Schindelin pointed out that this isn't the right thing to do for an --amend, so that is checked for. Additionally, it's probably not the right thing to do if any files are specified with "--only" ...
Nov 30, 8:01 am 2006
Nguyen Thai Ngoc Duy
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Uncomment to abort commit would be more intuitive. -- Duy -
Nov 30, 8:50 am 2006
Seth Falcon
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
For those using emacsclient, I don't think ^C will work. Is there another way to undu an ammend commit? If not, is there any sense in detecting a magic comment to abort the ammend commit? -
Nov 30, 8:15 am 2006
Seth Falcon Nov 30, 9:03 am 2006
Jakub Narebski
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
By the way, I think that git-commit should also watch the return code from the editor, so you can ^C it to abort git-commit --amend. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 6:16 am 2006
Jakub Narebski
Re: Getting CVS and Git to play nicely in the same box
Why not use git-cvsserver? Or port git-svn to CVS (or use Tailor)? -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 6:08 am 2006
Alex Bennee
Re: Getting CVS and Git to play nicely in the same box
I can't use git-cvsserver because the main repository is going to have to stay on CVS for the time being. I don't think it could be used as a drop in replacement for our existing server anyway as it doesn't support tagging or branching. Using git is my own personal indulgence (At least until I can demonstrate it's worth while the other migrating ;-). It looks like git-svn is the sort of tool I'd want for CVS although I'm not sure how it would live with our CVS branched development model. ...
Nov 30, 6:54 am 2006
Jakub Narebski
Re: Getting CVS and Git to play nicely in the same box
Perhaps if not git-cvsserver, then git-cvsimport (or parsecvs, or cvs2git) Well, Tailor used to work only with linear histories. But it is meant to maintain parallel repositories in different formats. -- Jakub Narebski Poland -
Nov 30, 7:16 am 2006
Andy Parkins
[PATCH/RFC] Make git-commit cleverer - have it figure ou ...
Raimund Bauer offered this suggestion (paraphrased): "Maybe we could do git-commit -a _only_ if the index matches HEAD, and otherwise keep current behavior? So people who don't care about the index won't get tripped up, and when you do have a dirty index, you get told about it?" Johannes Schindelin pointed out that this isn't the right thing to do for an --amend, so that is checked for. Additionally, it's probably not the right thing to do if any files are specified with "--only" or ...
Nov 30, 5:59 am 2006
Alex Riesen
Re: [PATCH/RFC] Make git-commit cleverer - have it figur ...
The is dangerous on filesystems which lie to the programs about file metadata. The "virtual filesystem" of cygwin is one of this kind: exec-bit of the files depend on its contents. Just calling git-commit -a will commit executability at this particular moment. For whatever reason, disabling handling of the exec-mode in gits config does not work. If you about to change the behaviour, provide at least a config option to go back to the old git-commit, which didn't do any magic. -
Nov 30, 10:14 am 2006
Alex Bennee
Getting CVS and Git to play nicely in the same box
Hi, I'm trying to get a setup where I can use git for my day to day coding on problems but still mirror a CVS repo. The situation is muddied slightly by the way we manage changes in our CVS repository and baselines. The CVS manner of working means we create a branch at a given point to do work on it: BL1_CH2 / / BL1_CH1 BL1---/ And then in the meantime a new baseline may be released: BL2 BL1_CH2 | / | BL1_CH1 BL1--/ So we employ ...
Nov 30, 5:39 am 2006
Robin Rosenberg
Re: Getting CVS and Git to play nicely in the same box
You don't need to use GIT to track metadata (I asume you mean CVS/Entries) is My setup is like this: - A tracking repo on a server runs git-cvsimport every night. - I pull from the tracking repo - I have a CVS checkout for the branch I'm interested in committing to - Then I use cvsexportcommit to export changes back to CVS. Actuallly I use a small script that runs cvs update and then exports the changes defined by a named commit so I say "tocvs ...
Nov 30, 3:21 pm 2006
Andreas Ericsson
[PATCH] git-diff: Introduce --index and deprecate --cached.
'git diff --cached' still works, but its use is discouraged in the documentation. 'git diff --index' does the same thing and is consistent with how 'git apply --index' works. Signed-off-by: Andreas Ericsson <ae@op5.se> --- Documentation/git-diff.txt | 6 ++++-- builtin-diff.c | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Documentation/git-diff.txt b/Documentation/git-diff.txt index 228c4d9..3144864 100644 --- a/Documentation/git-diff.txt +++ ...
Nov 30, 4:43 am 2006
Andreas Ericsson
[PATCH] ls-files: Give hints when errors happen.
Without this patch "git commit file.c file2.c" produces the not so stellar output: error: pathspec 'file.c' did not match any. error: pathspec 'file2.c' did not match any. With this patch, the output is changed to: error: pathspec 'file.c' did not match any file(s) known to git. error: pathspec 'file2.c' did not match any file(s) known to git. Did you forget to 'git add'? Signed-off-by: Andreas Ericsson <ae@op5.se> --- builtin-ls-files.c | 6 +++++- 1 files changed, 5 ...
Nov 30, 4:28 am 2006
Nguyen Thai Ngoc Duy
Re: git and bzr
I am serious about that. I haven't thought of it as an independent command/program though. Can you implement givor exactly like the above Okay now joke part. This command name is better :-D $ git commit [...] nothing to commit $ dammit $ git commit Givor: You haven't marked any file for commit using "git-update-index <file>" Givor: and you didn't provide files to commit with "git commit <file>" Givor: so I assume that you wanted to commit all changed files Givor: You can use "git commit ...
Nov 30, 5:14 am 2006
Jakub Narebski
Re: git and bzr
The 'givor' (pun on Vi 'vigor') or 'gitor', or 'gator'. $ git commit [...] nothing to commit $ givor $ git commit Givor: You haven't marked any file for commit using "git-update-index <file>" Givor: and you didn't provide files to commit with "git commit <file>" Givor: so I assume that you wanted to commit all changed files Givor: You can use "git commit -a" for that (-a is for --all) ;-) -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 4:58 am 2006
Andy Parkins
[PATCH] De-emphasise the symbolic link documentation.
The fact that git has previously used symbolic links for representing symbolic refs doesn't seem relevant to the current function of git-symbolic-ref. This patch makes less of a big deal about the symbolic link history and instead focuses on what git does now. Signed-off-by: Andy Parkins <andyparkins@gmail.com> --- I've not been using git long enough to have ever experienced the symbolic-link refs. It seems unnecessary that the man pages talk about something that doesn't happen in such ...
Nov 30, 3:50 am 2006
Pazu
Re: Unprivileged User
That would make more sense to me. -- Pazu -
Nov 30, 3:50 am 2006
Johannes Schindelin
Re: git and bzr
Hi, If you are talking about "git commit file1 file2" ignoring the current index, and building a new index just updating file1 and file2 from the working directory, I disagree that it was a big mistake. Actually, I was very happy to get that change (IIRC it was me requesting it, so blame me), because I now can say: just specify exactly what you want to commit *1*. If you want to commit just file2 (even if you added file1, but did not commit it yet) do "git commit file2". If you want ...
Nov 30, 3:45 pm 2006
Junio C Hamano
Re: git and bzr
When I wrote that paragraph, I said: Much later, people from CVS background wanted to say "edit foo bar; git update-index bar; git commit foo" to mean "I might have done something to the index, but I do not want to care about it now -- please make a commit that includes only the changes to bar and I do not want the changes to foo included in the commit". Somehow we ended up introducing that twisted semantics and that was where --only ...
Nov 30, 4:36 pm 2006
Jakub Narebski
Re: git and bzr
By the way, short option -i is not --index but --include (i.e. commit both changes in index and files mentioned on command line). Perhaps -I? -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 30, 2:35 am 2006
Junio C Hamano
Re: git and bzr
Just in case nobody noticed after looking at the first part of my patch a few nights ago, --include happens to mean exactly what --index would mean anyway. By default, "git commit" without parameter does "make a commit out of the index". With paths, it used to mean "oh, by the way, I forgot to run update-index on these paths, so could you please do that for me now before you make the commit", and has been that way for a long time. Much later, people from CVS background wanted to say "edit ...
Nov 30, 3:01 am 2006
Jakub Narebski
Re: Unprivileged User
Actually gitweb uses uid/user the repository (the $GIT_DIR), unless you provide it with an index file. The simplest way is to click on "TXT" link in projects list page, save it somewhere, edit it, and recompile gitweb with this file as GITWEB_LIST (see README): make ... GITWEB_LIST=<index> gitweb/gitweb.cgi (or just edit gitweb.cgi or gitweb_conf.perl setting $projects_list to this file). Perhaps gitweb should use user.name from the repository instead... P.S. Please reply also to git ...
Nov 30, 2:07 am 2006
Junio C Hamano
Re: Unprivileged User
This is a shot in the dark, but by any chance is this repository owned by nobody, which is mapped to "Unprivileged User" by /etc/passwd? Googling for "Unprivileged User" and "getpwent" tells me that on OSX boxes nobody seems to map to that Gecos name. To explicitly set the names of list of projects and their owners, set up $projects_list text file. A hint for its format is found around line 1111 in gitweb/gitweb.perl script. Hopefully somebody has documentation for gitweb ...
Nov 30, 2:39 am 2006
Ed
Unprivileged User
Hi, I'm new to git. Just got everything setup and imported a new project. From gitweb it says that my git project's owner is: Unprivileged User Should I be worried about this when I begin using this git project with others? How would I resolve this, to make the owner as the name I set in my ~/.gitconfig, or is there something I didn't read in the docs? Thanks, beside this small glitch, git has been great. Ed. -
Nov 29, 10:54 pm 2006
Jon Smirl
Re: v2.6.11 tag in kernel tree
Thanks for the replies, I got it working. I'm trying to decipher the changes a vendor made to 2.6.11 when they ported it to an ARM device and peripherals. It is the usual situation of releasing a GPL tarball without any documentation as to what they changed. -- Jon Smirl jonsmirl@gmail.com -
Nov 30, 12:11 pm 2006
Linus Torvalds
Re: v2.6.11 tag in kernel tree
Yes. We don't have that as a commit. The commit history starts with You can't check it out, since it's not a commit, but since it is a tree, you can: - use it as a base for "git diff" git diff v2.6.11 <any-commit-goes-here> - or if you want to use it as a base for development, create a new commit and branch from it: git-commit-tree v2.6.11 <<EOF This is an initial commit starting at the state of Linux-v2.6.11 EOF and then you can take the resulting SHA1 (that ...
Nov 30, 9:04 am 2006
Johannes Schindelin
Re: [PATCH] git-merge: preserve and merge local changes ...
Hi, How about "-k|--keep-changes" or "-l|--local-changes", or "-p|--preserve-changes"? BTW from a user's perspective, this operation _is_ a merge, not a checkout. So, IMHO the compatibility with that rarely used option of git-checkout is neglectable. Ciao, Dscho -
Nov 30, 3:32 am 2006
Carl Worth
Re: [PATCH] git-merge: preserve and merge local changes ...
This looks very appealing to me. I know I've often been frustrated when git refuses to fast-forward just because I have dirty state, (and stashing the diff manually into a patch file, then re-applying it after fast forward is really annoying---getting work done in spite of As I said above it seems very reasonable to me. As for the problem you mention here, isn't "no good way to recover from it" the real problem, and not this merge possibility? And is there enough information in the index file ...
Nov 30, 12:32 am 2006
Carl Worth
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Call me insane. I think it is very strange that the following command sequences commit different content for myfile: echo old > myfile git add myfile echo new > myfile git commit compared to: echo old > myfile git add myfile echo new > myfile git commit myfile The difference there is very subtle and really does prevent a reasonable, "just ignore the index and you can use git comfortably". Now, the behavior above can be explained. You and I both understand it just ...
Nov 30, 6:10 pm 2006
Nicolas Pitre
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Great. But let me repeat my last question: Would it make sense for "git add" to do the same as "git update-index" on already tracked files? Given the explanation above this would make 100% sense to me. Even for newbies this might help them understand the power of the index with only one command. "You _add_ your changes together before you may commit." That's simple to understand even for newbies. And then they'll start using the power of the index even without realizing it. But ...
Nov 30, 1:47 pm 2006
Nicolas Pitre
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
No no no ! I argued for that at the time and I still stands behind that change ! Nicolas -
Nov 30, 6:20 pm 2006
Nicolas Pitre
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Wonderful! We might be converging to something then. Because, conceptually, it then becomes much easier to tell newbies about the index as follows (this could be pasted in a tutorial somewhere): Contrary to other SCMs, with GIT you have to explicitly "add" all the changes you want to commit together. This can be done in a few different ways: 1) By using "git add <file_spec...>" This can be performed multiple times before a commit. Note that this is not only for ...
Nov 30, 3:21 pm 2006
Junio C Hamano
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Hmmm. I did not make my judgement based on what the command did in the ancient _original_ version. The --only behaviour being totally different from others (from "index is the only thing that matters" point of view) was what bothered me. It did not feel logical. that makes tons of sense. What's "logical" largely depends on how things ought to behave in the mental model, and the mental model you would form largely depends on how things are explained to you. -
Nov 30, 5:24 pm 2006
Junio C Hamano
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Yup. And it appears that we even agree that "intent to add" is I sense that you are inviting me to argue for reverting the other "git commit" braindead which is spelled "--only" (and Other than these "twists", I think it makes sense, and that is what I think. But making sense to me does not necessarily validate that a tutorial document is great for its intended audience, since I lost git virginity long time ago. I can only endorse that the description is technically accurate. -
Nov 30, 4:02 pm 2006
Michael K. Edwards
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
I think Linus is right that the semantics of "git commit" and "git add" are not broken and do not need fixing. But Carl and others are right that they are not self-explanatory to most people, whether or not they have been tainted by CVS and its ilk. Maybe this is a job for a little contextual documentation (aka hand-holding) to accompany the tutorial and reference docs. How about we add a set of "expert" flags in the config, gating access to non-intuitive behavior and to idioms that should be ...
Nov 30, 8:52 pm 2006
Carl Worth
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
By the way, I think I've said all I can in this thread. If the "create file; git add; edit file; git commit" confusion isn't blisteringly obvious to the git maintainers then I think I have to give up here. And this isn't just CVS-induced brain damage. It's the user being required to mentally juggle 3 states for the file, (the last "committed" state, the current "working tree" state, and this "something else" state). The sequence above, (which is very natural), exposes this "something else" ...
Nov 30, 11:51 am 2006
Junio C Hamano
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
I think this makes sense and what we did in the original "git add". -
Nov 30, 2:19 pm 2006
Linus Torvalds
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
If you want to ignore the index, you'd always use "git commit -a". The old argument by incredulity. The fact that you cannot see it doesnt' change the fact that I use it all the time. Usually not for the same file, but committing something that is different in the index and in the working tree is my normal behaviour - it's how any number of things work (like merging while you have dirty state, or applying patches while you have changes). So, let me condense the argument: - ...
Nov 30, 6:32 pm 2006
Robert Shearman
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Exactly. We had a tutorial for the project I contribute to (admittedly the initial users were all used to how CVS worked) and while a number of people got the concept of the index and were fairly happy with it, it did add to the confusion of the tutorial, so now it doesn't mention the index at all. The tutorial introduced it as a staging area for commits, but the trouble is that once you work like this you have to remember that "git-diff" won't show you what will be committed, so you ...
Nov 30, 2:33 pm 2006
Johannes Schindelin
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Hi, An obvious deficiency would also be the presence of hundreds of debug quirks I had to introduce to find the bug which I finally fixed. But I do not want to commit, because it is such a mess. So: into the index, ye files. Now I can clean up everything I introduced to find the bug. If the result does not work as expected? "git diff"! But now that I cleaned up the mess, I find that there is a more elegant way to solve the problem. Into the index, ye files! Clicketyclick, if I ...
Nov 30, 3:27 am 2006
Andreas Ericsson
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
A staging area is per definition meant to keep temporary things before they are committed to their designated place so there's nothing odd about that. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 -
Nov 30, 4:09 am 2006
Linus Torvalds
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
I actually really like the current defaults for "git commit". And I say that despite the fact that the defaults are _different_ from the original ones. I like the fact that when you do "git commit filename", it really will commit _only_ that file, not the other files you added. It's logical. So you can do echo a > file-a echo b > file-b git add file-a file-b git commit file-a and it will only commit one of them. Now, admittedly, the status message that you get is ...
Nov 30, 4:40 pm 2006
Linus Torvalds
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
I really think we're better off just telling people how things work (with practical examples, and _not_ by trying to explain things at too high a conceptual level). I don't think people generally are all that stupid, and I think it's actually counter-productive to try to basically lie about how things work. I really _think_ that a lot of that is in the documentation being overly technically oriented and talking often about the technical side of how things work in the index, rather ...
Nov 30, 7:44 pm 2006
Linus Torvalds
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Sure. It's just that some people seem to expect the index to be different from HEAD, and are afraid of being "confused" by it. The fear seems to be about "git diff" getting different results from "git diff HEAD", and always having to _check_ the two. So I wanted to make it clear that I never have that situation, because I never leave the index "dirty". I agree that there is nothing odd about it, but I think that people who don't actively use the index (or don't use git at all, and ...
Nov 30, 8:58 am 2006
Linus Torvalds
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
The default is: commit everything that you ask for to be committed. If you haven't marked anything to be committed (which you can do with "git add" too, or with simply being in the middle of a merge, or by having done something like "git pull -n" or similar that does everything _but_ commit), then git commit will say "nothing to do". It has NOTHING to do with the index per se. I still don't understand why people are so hung up about the index. So ignore the index entirely, and ...
Nov 30, 10:13 am 2006
Carl Worth
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
But, wait a second. What if I do my typo fix to file-a in between that "git add" and the "git commit". Why should "git commit" insist so vehemently on committing the _old_ state of file-a while "git commit file-a" so happily commits the _new_ state? I'm really not seeing conceptual consistency to what "commit <files>" does compared to "commit". The "commit <files>" case is a special-case of "commit -a" while "commit" is just plain different. See? I do like the direction Nico is going ...
Nov 30, 5:13 pm 2006
Linus Torvalds
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
I'm sorry, but you are wrong. It really _is_ CVS-induced brain damage, and I'm trying to teach you. You can give up, but that's really "refuse to see the damage that systems like RCS and CVS has done to the world" The fundamental brain damage that CVS (and RCS, and SVN, and just about anything else) has had is thinking that "filenames" (and sometimes this is "fixed" to be "file ID's") are somehow special, and a totally separate thing from "file contents". Really. It's a BUG. ...
Nov 30, 12:55 pm 2006
Theodore Tso
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Well, sure, because the documentation *talks* about it as a separate entity all its own. Just look at the man page for git-diff as a great example of this, or the ascii art diagram of the index. It is all But then why is the default for "git commit" to commit the index, if the index is almost == HEAD? And why is git-update-index given such If everyone agrees with this, I think it would be easier to make changes to the documentation and maybe some UI tweaks about what the default might ...
Nov 30, 9:40 am 2006
Linus Torvalds
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
If so, you should make it a special case. I refuse to believe in the "people who know what the hell they are doing should work more at it" philosophy. The "git commit -a" behaviour as it is now is better than the alternatives, exactly because it's more flexible. It _allows_ you to not commit anything at all (and as already mentioned, there are cases where that is exactly what you want). If you want to have a "-a by default", then that you require _you_ to do more work, and no, ...
Nov 30, 11:33 am 2006
Carl Worth
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
I'm sorry, Linus. I'm really failing to communicate with you somehow here. I _do_ use this all the time too. I don't need you to explain it to me again. I get it, I like it, I use it. That's not at all what I'm Nope. I get it and I use it. Most commonly I do things like "update-index;commit" to separate independent changes, (I could use "git commit explicit/files" instead but I *gasp* actually enjoy being able to manually stage things in the index first). What I'm trying to say is that ...
Nov 30, 7:08 pm 2006
Linus Torvalds
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Yeah, I think it would probably make sense. I also think it would make sense to rename "update-index" entirely, or at least offer other names for it (ie the "git resolved" suggestion). In short - I agree that it's all just facets of the same thing: telling git that some part of the working tree is now in a state ready to be committed. Whether it's because we want to "add" content, or just mark it Yeah, that's arguably a stupid thing to do ("you already added it, what do you want ...
Nov 30, 2:03 pm 2006
Carl Worth
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
OK. I'll try to not mention the "index" any more in any postings here. And can we agree that any time git spits out a message directing the I think the response that would come from the people that are confused is: "But I told git I wanted to track this file when I said 'git add' long ago. Why is it making me tell it again." As you mentioned, all systems have _some_ mechanism for keeping track of the files to be committed, (and git's is only unique in having a name and providing ...
Nov 30, 11:09 am 2006
Linus Torvalds
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Because that's what "git commit filename" means. Exactly what the command says. "git commit" says "commit everything I've told you to commit". While "git commit filename" says "commit the changes that I've made to this file". Yes, they are two totally different cases, but nobody sane can claim that it is strange. Exactly _because_ you explicitly list the filename, that also means that you want the file content AT THAT TIME. If you don't list the filename, you obviously must be ...
Nov 30, 5:21 pm 2006
Nicolas Pitre
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Might it be a good idea to have "git-add" do the same as "git-update-index" on already tracked files? That could be easily taught as "you must explicitly _add_ files to your next commit" and whether the file is already tracked or not wouldn't matter. This would help newbies actually getting used the index without mentioning the dreaded word "index" at all. Right now git-add on an already tracked file does nothing, not even a message to say it did nothing. Nicolas -
Nov 30, 10:37 am 2006
Carl Worth
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
I think this is worth doing, but it doesn't solve the problem. It would be nice if this worked, because then it would be natural to teach users to "git add" their changes, and then when the obvious complaint about that being annoying to type all the time, then respond by teaching "git commit -a" as a shortcut. That would be very natural. But this doesn't quite work. Here's a major "index is confusing" scenario that I first hit on my first exposure to git, (it was so long ago that I ...
Nov 30, 11:38 am 2006
Carl Worth
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Sure. There's no need to lie to about how things work. And I agree that would cause later problems. As far as getting the message out, we have several different ways to do that: 1. In-person presentations, demos, tutorials 2. Written tutorials 3. Reference documentation 4. Output from git commands 5. The default behavior of git commands And that list is roughly sorted from most to least "information bandwidth". The limited bandwidth at the bottom-most levels in my list, ...
Nov 30, 8:40 pm 2006
Catalin Marinas Nov 30, 1:32 am 2006
Seth Falcon
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
So I will add my $0.02: Summary: leave git-commit as-is I think the intimidation factor of the index is overstated. A scratch working area is a natural concept -- that's what people do who don't even _know_ what an scm is. I agree with Junio's description of commit -a as default breaking the mental model. I've played with three distributed scm: tla, hg, and git. I've stuck with git because, in part, it helped me to learn its more advanced features -- not because it was ...
Nov 29, 10:24 pm 2006
Raimund Bauer
Re: git and bzr
Maybe we could do that _only_ if the index matches HEAD, and otherwise keep current behavior? So people who don't care about the index won't get tripped up, and when -- best regards Ray -
Nov 29, 11:59 pm 2006
Steven Grimm
Re: git and bzr
Plus, one assumes, the git-generated comments in the commit message will tell you what kind of commit it has decided to do. I like this suggestion a lot. Thinking back over my git usage recently, which has included both styles of commits (though mostly -a ones), I think this would have done the right thing by default in every case. -Steve -
Nov 30, 2:39 am 2006
Alan Chandler
Re: git and bzr
No you won't. If you don't use update-index, then index will match HEAD and you will commit changes in the working tree. That is the way for newbies As soon as you do the first update-index the index will no longer match HEAD, so commit will do the same as it does now. And if you are not sure which you have done then presumably you do what you do now, or git commit -a or git commit -i as you need. -- Alan Chandler http://www.chandlerfamily.org.uk -
Nov 30, 2:30 am 2006
Alan Chandler
Re: git and bzr
I have been(silently) following the git commit discussion and started being fully on the side of git commit -a being the default, but was slowly moving over towards the git commit -i being the default camp. This post seems like a Eureka moment - chew over the problem long enough and someone comes in from left field with an off the wall remark that suddenly clarifies everything. -- Alan Chandler http://www.chandlerfamily.org.uk -
Nov 30, 1:31 am 2006
Nguyen Thai Ngoc Duy
Re: git and bzr
It reminds me Microsoft Office Assistant :-) Let's make "git assistant mode" that tries hard to guess user's desires and give them guidance. Once they get used to git, they can disable that mode and back to "plain git". -- Duy -
Nov 30, 4:25 am 2006
Andreas Ericsson
Re: git and bzr
Unless you do "git update-index" (and thus are already using the index) on any files, "git diff" shows you exactly the changes between your last commit and the working tree. There's nothing magic, odd or confusing about it, no matter which scm you come from. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 -
Nov 30, 5:25 am 2006
Nguyen Thai Ngoc Duy
Re: git and bzr
I hate the if clause. Suppose I prefer update-index way, I would have to check whether HEAD matches index everytime I do a commit to make sure it won't do the other way. Either -a or -i is the default, not if please. By the way I do use the update-index way, but vote -a by default. I don't mind adding " -i" after every commit commands. -- Duy -
Nov 30, 2:01 am 2006
Andreas Ericsson
Re: git and bzr
Sounds sane. Especially if we couple it with a hint for the user to use "commit -a" when he/she wants to do blanket commits. So in essence that would mean: If no pathspecs are given and index matches current HEAD, print out "Nothing to commit but changes in working tree. Assuming 'git commit -a' and then act accordingly. Carl, do you think that would satisfy the desires of your RedHat peers? Always doing '-a' by default is terribly wrong for those of us who actually use partial commits a ...
Nov 30, 5:45 am 2006
Carl Worth
Re: git and bzr
I thought of that tonight and almost suggested it myself. It would be an attempt to satisfy both "sides" of the debate without either side having to fight with a default they didn't like or configure it away. I did wonder if the powers that be would find it a bit too magic, (the problem with magic things is that they can sometimes be quite confusing when they don't do exactly what you want). But this might just work. It wouldn't be too bad to document, (we already have several commands that ...
Nov 30, 12:17 am 2006
Johannes Schindelin
Re: git and bzr
Hi, See git-gui from Shawn. It should really help new users with a graphical user interface. Ciao, Dscho -
Nov 30, 5:23 am 2006
Theodore Tso
Re: git and bzr
Until you make the mistake of reading the git-diff man page, at which point the novice git user runs screaming into the night... Show changes between two ents, an ent and the working tree, an ent and the index file, or the index file and the working tree. The combination of what is compared with what is determined by the number of ents given to the command. * When no <ent> is given, the working tree and the index file is compared, using ...
Nov 30, 1:01 pm 2006
Johannes Schindelin
Re: git and bzr
Hi, So many people spoke for it, it's time I crash the wedding. From a usability viewpoint, it is a horrible convention. The user has to remember too much of the side effects to handle the commit operation. The function of the program would no longer be dependent on the command line arguments and your config, but _also_ on something as volatile as the index. You would literally end up asking "did I change the index?" _everytime_ before you commit. And remember, even a simple "git ...
Nov 30, 3:19 am 2006
Andy Parkins
Re: [RFC] Submodules in GIT
Who said anything but rebase/rewind? As it happens though, I don't see why you can't (it wouldn't be pleasant though). A rebase or rewind still leaves the original commit in the object database, so provided no one runs I certainly never suggested anything /but/ storing a submodule type that stores the commit. The current debate is about whether the supermodule I don't really know, I only joined in to stand up against commit in the supermodule triggering commits in the submodule. ...
Nov 30, 5:40 am 2006
sf
Re: [RFC] Submodules in GIT
Andy Parkins wrote: So what? You have a submodule commit that only exists in the supermodule. I fail to see the problem. The changes you made to the submodule _in the supermodule_ can later be pulled from wherever you want. Regards Stephan -
Nov 30, 4:57 am 2006
Andreas Ericsson
Re: [RFC] Submodules in GIT
Perhaps I'm just daft, but I fail to see how you can safely track a topic-branch that might get rewinded or rebased in the submodule without crippling the supermodule. Wasn't the intention that the supermodule has a new tree object (called "submodule") that points to a commit in the submodule from where it gets its tree and stuff? Is the intention that the supermodule pulls all of the submodules history into its own ODB? If so, what's the difference between just having one large ...
Nov 30, 5:16 am 2006
Martin Waitz
Re: [RFC] Submodules in GIT
hoi :) What about: You decide to try something out quickly and create a new branch in the submodule. After you have verified that it works, you merge it to the submodules master branch and commit that to the supermodule. Not that complicated, isn't it? In fact, my current implementation does not even allow to change the Please excuse that I am not an native english speaker and I may have That is exactly what I wanted to say. In the supermoduel you call update-index (with the submodule ...
Nov 30, 10:06 am 2006
Andreas Ericsson
Re: [RFC] Submodules in GIT
There's no real technical reason for locking it to a single branch though, and in case of a fork in the upstream submodule project, you might suddenly decide that "the other team" is heading in a much more interesting direction and you want to use their work in your module instead. Will you now have to maintain a separate branch just to keep It could be, and as has already been stated, there's no real reason to limit this to a particular branch, so I don't see why we would want to No ...
Nov 30, 11:57 am 2006
Andy Whitcroft
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
If you have no commit message the commit will be aborted. So just write back a completly empty commit message. "dG:wq" in vi land. apw@larry:~/git/linux-2.6$ git commit --amend * no commit message? aborting commit. apw@larry:~/git/linux-2.6$ -apw -
Nov 30, 10:13 am 2006
Salikh Zakirov
Re: [PATCH 0/2] Making "git commit" to mean "git commit -a".
Thanks a lot for the patches, Junio! I am using them for two days, and my experience is great! Many times it saved me annoyances of forgetting to put '-a' to 'git commit'. It should be noted, that I mostly used 'git-commit files...' or 'git-commit -a' forms before. Someone said, that default '-a' does not go well with 'git-commit --amend', and I second that. It was somewhat suprising to see that 'git commit --amend' is going to include all of the dirty state into the commit, and since ...
Nov 30, 5:23 am 2006
Jon Loeliger
Re: [RFD] making separate-remote layout easier to use
I see how it is! :-) When Shawn says it, it is to be liked. But when I allude to it a _year_ ago, I'm ignored. From: Jon Loeliger <jdl@freescale.com> To: git@vger.kernel.org Subject: Re: Trying to Update All Heads of a Repository Date: Fri, 4 Nov 2005 07:49:40 -0700 Message-ID: <E1EY2su-0006LW-IN@jdl.com> So, from the git-pull man page: For "git push", the local ref that matches <src> is used to fast forward the remote ref that matches ...
Nov 30, 11:16 am 2006
Alex Riesen
[PATCH 1/2] move Git.pm build instructions into perl/Makefile
Signed-off-by: Alex Riesen <raa.lkml@gmail.com> --- This is the first patch, just rebased upon current master. The ActiveState-related parts follow
Nov 30, 9:27 am 2006
Junio C Hamano
Re: git blame
Doesn't one of our existing t/ scripts do that? -
Nov 30, 3:38 pm 2006
Johannes Schindelin
Re: git and bzr
Hi, As for now, no, it does not. This is a shortcoming of RCS merge which does the heavy-lifting. Having said that, stay tuned for new developments: the functionality of merge is being integrated in git. This opens the door to make use of the code tracking support in git, to do exactly what you just proposed. Ciao, Dscho -
Nov 30, 5:47 am 2006
J. Bruce Fields
Re: git blame [was: git and bzr]
Currently tutorial.txt doesn't work like that--there are places where it just tells the user to edit a file, or make a few commits, without listing commands to do so. It also isn't linear. That could all be "fixed", but I think the result would just make it more tedious. But I agree that a "git tutorial" command to set up a canonical example repository might be fun. --b. -
Nov 30, 3:24 pm 2006
Johannes Schindelin
Re: git blame
Hi, ;-) I did not forget... t1200-tutorial.sh But it serves a different purpose: it makes sure that we did not break the commands in the tutorial. (I fear that the script and the tutorial have diverged a little bit, though). git-tutorial should not test that, rather it should show the user what is possible, and encourage playing with git. Ciao, Dscho -
Nov 30, 3:53 pm 2006
Joseph Wakeling
Re: git blame [was: git and bzr]
I'm very happy my stupidity could help. ;-) On a related note ... I do think that bzr has quite an intuitive set of commands, and it is easy to learn, though at this point I don't feel git is really *that* much more difficult in itself. Although the terminal output for some problems could be improved, most of my difficulties are stemming from overlap of command names when the commands themselves do different things, and the fact that git's documentation is somewhat more technical than ...
Nov 30, 11:24 am 2006
Johannes Schindelin
Re: git blame [was: git and bzr]
Hi, That sounds fine! Actually, it should be very simple to turn the tutorial into such a script, displaying the command with an explanation, and executing the command. It could even call gitk from time to time, so the user can form a mental model of the ancestor graph. Ciao, Dscho -
Nov 30, 3:17 pm 2006
Linus Torvalds
Re: git and bzr
Right now (and in the near future), nope. "git blame" will track the changes (so the pure movement wasn't just an addition of new code, but you'll see it track it all the way down to the original), but "git merge" is still file-based. In other words, "git merge" does uses a data similarity analysis that could be used for smaller chunks than a whole file, but at least for now it does it on a file granularity only (and then passes it off to the standard RCS three-way merge on a ...
Nov 30, 9:45 am 2006
Nicholas Allen
Re: git and bzr
I also have a basic question about git regarding its content tracking and merging. Does this mean if I have, for example, a large C++ file with a bunch of methods in it and I move one of the methods from the bottom of the file to the top and in another branch someone makes a change to that method that when I merge their changes git will merge their changes into the method at the top of the file where I have moved it? If so that would be really quite impressive! Cheers, Nick -
Nov 30, 5:36 am 2006
Carl Worth
Re: git blame [was: git and bzr]
Here's a crazy idea. How about a "git tutorial" builtin or "git example" or something that would create a repository into some useful state for demonstrating something. I know that I'm regularly putting stuff into emails like: mkdir gittest cd gittest git init-db echo hello > hello git add hello git commit -m "add hello" git checkout -b other echo other > other git add other git commit -m "add other" git checkout master # OK, that was just setup, here's what I want to ...
Nov 30, 12:55 pm 2006
Linus Torvalds
Re: git blame [was: git and bzr]
100% agreed. A lot of the man-pages etc have been written to be about the technology, not about the _use_ of it. I encouraged people at some point to add an "Examples" section to some of the functions to show what it all _means_, so for "man git-log", I think some of the most useful stuff is that examples section that shows the combination of revision naming and path-name limiting, for example. I personally think that that is a much better way of teaching people what the commands ...
Nov 30, 11:44 am 2006
previous daytodaynext day
November 29, 2006November 30, 2006November 29, 2006