git mailing list

FromSubjectsort iconDate
linux
gitk feature request: --goto
I was just writing beginner-level instructions for looking at a specific commit in gitk ('double-click on the "SHA1 ID" box to selet the contents, type "5401f304" in its place, and click "goto"'), and it dawned on me that it would be easier to look at a given commit in context if there was a --goto <commit-ish> option as well as the usual filtering options. It might be a nice feature for "git bisect visualize" to preselect the currently-being-tested commit, for example, rather than making the ...
Nov 18, 11:32 pm 2006
Petr 'Patch Proxy' B...
[PATCH] git-fetch.sh: fix fetching of tags that point direct...
git-fetch used to fetch only tags that pointed to tag objects, because it required a ^{} suffix from git-ls-remote's output. Not signed off. --- For similar issue in Cogito, please see http://news.gmane.org/find-root.php?message_id=<20060427105251.AA4B2353DAC@atlas.de... Curiously enough, Junio himself posted a patch. Perhaps given his state as of then he forgot to fix Git as well. ;-) I did not write this patch. One fellow IRCer did, but for personal reasons he does not wish to...
Nov 18, 10:59 pm 2006
Anand Kumria
Re: how to authenticate with git-svn on a subversion reposit...
Or, even simpler, use: svn info <url> which will cache the credentials and not require a working copy. Anand -
Nov 18, 8:43 pm 2006
Petr Baudis
[PATCH] Documentation: Correct alternates documentation, doc...
For one, the documentation invalidly claimed that the paths have to be absolute when that's not the case and in fact there is a very valid reason not to use absolute paths (documented the reason as well). Signed-off-by: Petr Baudis <pasky@suse.cz> --- Documentation/repository-layout.txt | 17 ++++++++++++++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/Documentation/repository-layout.txt b/Documentation/repository-layout.txt index fd9f406..73a025b 100644 --- a/Doc...
Nov 18, 7:30 pm 2006
Yann Dirson
[BUG] gitk: fails while unfolding dir in tree-view
When using the "tree" view and trying to unfold a particular dir, I got the following error: can't read "treeheight(lib/)": no such element in array can't read "treeheight(lib/)": no such element in array (reading value of variable to increment) invoked from within "incr treeheight($x) $n" (procedure "treeopendir" line 15) invoked from within "treeopendir $w $e" (procedure "treeclick" line 20) invoked from within "treeclick .ctop.cdet.right.cfiles 18 233" (command ...
Nov 18, 7:17 pm 2006
Jakub Narebski
Re: [PATCH 1/5] gitweb: Protect against possible warning in ...
Possible _undefined value_ warning. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 18, 6:38 pm 2006
Jakub Narebski
[PATCH 0/5] gitweb: New patchset view corrections and improv...
Table of contents: [PATCH 1/5] gitweb: Protect against possible warning in git_commitdiff [PATCH 2/5] gitweb: Buffer diff header to deal with split patches + git_patchset_body refactoring [PATCH 3/5] gitweb: New improved formatting of chunk header in diff [PATCH 4/5] gitweb: Default to $hash_base or HEAD for $hash in "commit" and "commitdiff" [PATCH 5/5] gitweb: Add an option to href() to return full URL Diffstat: gitweb/gitweb.css | 13 +++ gi...
Nov 18, 6:35 pm 2006
Jakub Narebski
[PATCH 1/5] gitweb: Protect against possible warning in git_...
Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- I'm not sure _when_ this eror (warning) occur, as it happened to me once, but I couldn't repeat it; but I didn't try too hard. I think it is better coding practice, and more readable. gitweb/gitweb.perl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 7587595..b2482fe 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3731,7 +3731,8 @@ sub git_commitdi...
Nov 18, 6:35 pm 2006
Jakub Narebski
[PATCH 3/5] gitweb: New improved formatting of chunk header ...
If we have provided enough info, and diff is not combined diff, and if provided diff line is chunk header, then: * split chunk header into .chunk_info and .section span elements, first containing proper chunk header, second section heading (aka. which function), for separate styling: the proper chunk header is on non-white background, section heading part uses slightly lighter color. * hyperlink from-file-range to starting line of from-file, if file was not created. * hyperlink to-file-ra...
Nov 18, 6:35 pm 2006
Jakub Narebski
[PATCH 5/5] gitweb: Add an option to href() to return full URL
href subroutine by default generates absolute URL (generated using CGI::url(-absolute=>1), and saved in $my_uri) using $my_uri as base; add an option to generate full URL using $my_url as base. New feature usage: href(..., -full=>1) To be used in web feeds (RSS, Atom, OPML) and other places which need full URL rather than absolute or relative. Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- gitweb/gitweb.perl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) di...
Nov 18, 6:35 pm 2006
Jakub Narebski
[PATCH 2/5] gitweb: Buffer diff header to deal with split pa...
There are some cases when one line from "raw" git-diff output (raw format) corresponds to more than one patch in the patchset git-diff output. To deal with this buffer git diff header and extended diff header (everything up to actual patch) to check from information from "index <hash>..<hash>" extended header line if the patch corresponds to the same or next difftree raw line. This could also be used to gather information needed for hyperlinking, and used for printing gitweb quoted filen...
Nov 18, 6:35 pm 2006
Jakub Narebski
[PATCH 4/5] gitweb: Default to $hash_base or HEAD for $hash ...
Set $hash parameter to $hash_base || "HEAD" if it is not set (if it is not true to be more exact). This allows [hand-edited] URLs with 'action' "commit" or "commitdiff" but without 'hash' parameter. If there is 'h' (hash) parameter provided, then gitweb tries to use this. HEAD is used _only_ if nether hash, nor hash_base are provided, i.e. for URL like below URL?p=project.git;a=commit i.e. without neither 'h' nor 'hb'. Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- gitweb/gitweb...
Nov 18, 6:35 pm 2006
Junio C Hamano
What's in git.git
Executive Summary - 'maint' and 'master' are the same, since we are still in "v1.4.4 fix" mood right now. A maintenance release v1.4.4.1 should follow soonish. - 'next' has a few 'these are obviously the right things to me but I want a bit of cheering-up before pushing them out, and they can wait until the dust settles after early fixes to v1.4.4 anyway' changes. - 'pu' has the shallow clone WIP and a half-finished rewrite of git branch in C, both by Johannes. Both need...
Nov 18, 6:24 pm 2006
Junio C Hamano
Re: What's in git.git
OOPS; sorry but the latter half is entirely untrue. What's there is half-done git-shortlog. Scratch everything about branch management please. -
Nov 18, 7:14 pm 2006
Sean
Re: [PATCH] Document git-runstatus
On Sat, 18 Nov 2006 11:37:14 -0800 Well this isn't a huge issue. One point you made though that struck a chord is that many of the commands should probably not be in Is there really a reason for a git user to access these from the command line rather than a script: commit-tree, diff-files, diff-index, diff-tree, for-each-ref, hash-object, http-fetch, http-push, index-pack, local-fetch, merge-base, merge-index, merge-octopus, merge-one-file, merge-ours, merge-recur, merge-recursive, merge-recu...
Nov 18, 4:04 pm 2006
Petr Baudis
[PATCH] Documentation: Define symref and update HEAD descrip...
HEAD was still described as a symlink instead of a symref. Signed-off-by: Petr Baudis <pasky@suse.cz> --- Documentation/glossary.txt | 7 +++++++ Documentation/repository-layout.txt | 14 +++++++++----- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/Documentation/glossary.txt b/Documentation/glossary.txt index 7e560b0..894883d 100644 --- a/Documentation/glossary.txt +++ b/Documentation/glossary.txt @@ -282,6 +282,13 @@ SCM:: SHA1:: Synonym for object...
Nov 18, 3:44 pm 2006
Junio C Hamano
Re: [PATCH] Documentation: Define symref and update HEAD des...
We fully support dealing with repositories with symlinked HEAD, and will continue to do so; I do not think we ever talked about deprecating it. Public "distribution point" repositories that have been established long ago that do not have reason to switch HEAD to point at different branch still have symlinked HEAD and they should continue to work. What we _don't_ do these days is to set up new repositories with symlinked HEAD, but that does not have anything to do with deprecating symlinked HEAD...
Nov 18, 3:55 pm 2006
Petr Baudis
Re: [PATCH] Documentation: Define symref and update HEAD des...
That's true, perhaps "obsoleted" is a better word. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ The meaning of Stonehenge in Traflamadorian, when viewed from above, is: "Replacement part being rushed with all possible speed." -- Kurt Vonnegut, Sirens from Titan -
Nov 18, 5:31 pm 2006
Jakub Narebski
Re: Possible but in gitweb
Ah, well. This could be considered a bug... but it can be not. The link is clearly marked "HEAD", so you are requesting HEAD version of the file... which does not exist. We could check if the file has HEAD version, but that is another call to git commands. What you want is the link to the tip of branch ("head", "top" or "tip")... you are welcome to add that (or replace "HEAD" link with that). Tip: href(...,hash_base => $hash_base,...) -- Jakub Narebski Poland -
Nov 18, 2:21 pm 2006
Luben Tuikov
Re: Possible but in gitweb
I think so too, at lest this is the intention: "head of line", "latest" whatever you want to call it, in the branch context one is at. -
Nov 18, 3:06 pm 2006
Jakub Narebski
Re: Possible but in gitweb" title="http://repo.or.cz/w/LinuxKernelDevelopmentProcess.git/html:/Lin...">http://repo.or.cz/w/LinuxKernelDevelopmentProcess.git/html:/Lin...
Nov 18, 1:35 pm 2006
Paolo Ciarrocchi
Re: Possible but in gitweb
Fair enoough but then there should be no link in the web interface. Yeah, but I would like to see the interpreted page. http://repo.or.cz/w/LinuxKernelDevelopmentProcess.git?a=blob;f=LinuxKernelDevelopmentP... That is master not html Yes, thanks! Is it reachable via the web interface? Well, I don't see how it is possible just browsing with gitweb. Ciao, -- Paolo http://docs.google.com/View?docid=dhbdhs7d_4hsxqc8 http://www.linkedin.com/pub/0/132/9a3 Non credo nelle o...
Nov 18, 1:42 pm 2006
Jakub Narebski
Re: Possible but in gitweb
Where did you find this link? On what page? "Browsing the repo" is not enough information to discover where there is a bug. -- Jakub Narebski Poland -
Nov 18, 2:01 pm 2006
Petr Baudis
Re: Possible but in gitweb
It's not really hard to find. :-) http://repo.or.cz/w/LinuxKernelDevelopmentProcess.git?a=blob;f=LinuxKernelDevelopmentP... I think the link shouldn't be 'HEAD' but 'latest' and point to the latest version in the currently browser branch. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ The meaning of Stonehenge in Traflamadorian, when viewed from above, is: "Replacement part being rushed with all possible speed." -- Kurt Vo...
Nov 18, 2:41 pm 2006
Paolo Ciarrocchi
Possible but in gitweb
Hi all, I'm playing with a repo hosted by repos.os.cz and I think I faced a bug (Pasky confirmed that this should be reported here as a bug). My repo has two branches, master html Master contains a text file while html contains his conversion in html done via asciidoc. I need to URLs that point to the top of the branches in order to have an easy way for lnkind the documentation to external portals. This link points to HEAD, so top of master: [ message continues ]
" title="http://repo.or.cz/w/LinuxKernelDevelopmentProce...">http://repo.or.cz/w/LinuxKernelDevelopmentProce...
Nov 18, 12:58 pm 2006
Judith Cunningham
New software uploaded by Gary on Nov 18 18:50:00 MSK 2006
Gary has uploaded some new software for you! Click here to view available updated software from Gary: http://moroz-oem.com/?Gary because only data bits are transmitted between sender and receiver, A common question is ``Why (or how) would we set the T1-GW to be the regarding the SLIP subnet xxx.xxx.yy via RIP onto the Ethernet; if you future, this will be the only place where announcements concerning the up the .klogin file as above, and the person in charge of Kerberos I586_CPU for cpu_t...
Nov 18, 11:57 am 2006
Petr Baudis
Re: [PATCH] Document git-runstatus
All commands deserve a man page. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ The meaning of Stonehenge in Traflamadorian, when viewed from above, is: "Replacement part being rushed with all possible speed." -- Kurt Vonnegut, Sirens from Titan -
Nov 18, 10:35 am 2006
Rene Scharfe
Re: [PATCH] Document git-runstatus
git-status is a wrapper around git-runstatus that takes the same Exactly. Even plumbers read manuals ;-). Well, me at least. Ren
Nov 18, 11:04 am 2006
Sean
Re: [PATCH] Document git-runstatus
On Sat, 18 Nov 2006 16:04:43 +0100 What could be said in the docs as to when the use of one is preferred Heh, I suppose you and Petr are right. It's just that in recent discussions the great number of commands provided by Git is seen as a UI problem. Thus having two commands that seem to do the exact same thing gives more such pain for no gain. It's possible that plumbers should not be seen as "users" but rather as coders capable of reading traditional text based (non man-page) documentation...
Nov 18, 12:04 pm 2006
Junio C Hamano
Re: [PATCH] Document git-runstatus
You should treat git-runstatus the same way as you would treat "git-merge-recursive". It strictly is a helper and you never use it by itself. It takes the parts that are too cumbersome to be enhanced in shell script from the old git-status script, and rewrites it in C. "git-status $args" is to give a preview of the commit that would be made with "git-commit $args" (where $args can be things like -a, $paths...). The part that still remain as script in git-commit and git-status performs the g...
Nov 18, 2:49 pm 2006
A Large Angry SCM
Re: [PATCH] Document git-runstatus
Are you suggesting that all non section 1 man pages should not exist? -
Nov 18, 2:20 pm 2006
Sean
Re: [PATCH] Document git-runstatus
On Sat, 18 Nov 2006 10:20:54 -0800 No... I was wrong to suggest there shouldn't be a man page.. I guess my real concern was why this particular command was needed at all. Really, it's not the man pages that are the problem but rather the large number of commands that are installed into the standard path that should only ever be accessed as plumbing. The plumbing-only commands should really be installed somewhere else, and man pages for them need only be installed in a -devel package, not in ...
Nov 18, 2:49 pm 2006
Rene Scharfe
[PATCH] Document git-runstatus
I copied most of the text from git-status.txt. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> --- Documentation/git-runstatus.txt | 66 +++++++++++++++++++++++++++++++++++++++ builtin-runstatus.c | 2 +- 2 files changed, 67 insertions(+), 1 deletions(-) diff --git a/Documentation/git-runstatus.txt b/Documentation/git-runstatus.txt new file mode 100644 index 0000000..c144c7b --- /dev/null +++ b/Documentation/git-runstatus.txt @@ -0,0 +1,66 @@ +git-runstatus(...
Nov 18, 10:15 am 2006
Sean
Re: [PATCH] Document git-runstatus
On Sat, 18 Nov 2006 15:15:49 +0100 How is git-runstatus different from "git status"? Should this command be viewed simply as plumbing, and if so does it deserve a man page or just textual documentation in the source? Sean -
Nov 18, 10:26 am 2006
Rene Scharfe
[PATCH] git-apply: slightly clean up bitfield usage
This patch fixes a sparse warning about inaccurate_eof being a "dubious one-bit signed bitfield", makes three more binary variables members of this (now unsigned) bitfield and adds a short comment to indicate the nature of two ternary variables. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> --- builtin-apply.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/builtin-apply.c b/builtin-apply.c index aad5526..61f047f 100644 --- a/builtin-apply.c ++...
Nov 18, 8:07 am 2006
Rene Scharfe
[PATCH] sparse fix: non-ANSI function declaration
The declaration of discard_cache() in cache.h already has its "void". Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> --- index-pack.c | 2 +- read-cache.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/index-pack.c b/index-pack.c index 042aea8..8331d99 100644 --- a/index-pack.c +++ b/index-pack.c @@ -90,7 +90,7 @@ static SHA_CTX input_ctx; static int input_fd, output_fd, mmap_fd; /* Discard current buffer used content. */ -static void flus...
Nov 18, 8:07 am 2006
Rene Scharfe
[PATCH] sparse fix: Using plain integer as NULL pointer
Z_NULL is defined as 0, use a proper NULL pointer in its stead. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> --- archive-zip.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/archive-zip.c b/archive-zip.c index 28e7352..ae5572a 100644 --- a/archive-zip.c +++ b/archive-zip.c @@ -160,7 +160,7 @@ static int write_zip_entry(const unsigne void *buffer = NULL; void *deflated = NULL; - crc = crc32(0, Z_NULL, 0); + crc = crc32(0, NULL, 0); p...
Nov 18, 8:06 am 2006
Marco Costalba
[WISH] Store also tag dereferences in packed-refs
Time needed to execute git-peek-remote in my box with cold cache currently is: - git tree 2.347 ms - linux tree 2.144 ms And refs are *already* packed in both repos. Looking at packed-refs file, it contains something like: d9b0f913ce0508fcc83e642e0241f373428368e5 refs/tags/v1.4.3 4314f5982d2aac08001a977fc0b1b611e858e025 refs/tags/v1.4.3-rc1 while I would need something like git-peek-remote output, d9b0f913ce0508fcc83e642e0241f373428368e5 refs/tags/v1.4.3 e0b0830726286287744cc9e1a...
Nov 18, 5:15 am 2006
Junio C Hamano
Re: [WISH] Store also tag dereferences in packed-refs
I think the question is why you would want to run peek-remote. Do you use the ^{} peeled-onion information and if so how and why? -
Nov 18, 2:38 pm 2006
Petr Baudis
Re: [WISH] Store also tag dereferences in packed-refs
My wild guess would be to attach tags to the right commits in qgit? -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ The meaning of Stonehenge in Traflamadorian, when viewed from above, is: "Replacement part being rushed with all possible speed." -- Kurt Vonnegut, Sirens from Titan -
Nov 18, 2:43 pm 2006
Marco Costalba
Re: [WISH] Store also tag dereferences in packed-refs
qgit (but also gitk FWIK) extracts e0b0830726286287744cc9e1a629a534bbe75452 1965efb1599f59b8e3380335d1fa395e2008a30b Stores in a quick look-up container and then checks against loaded commits to, as Pasky says, attach the nice green markers to tags. Marco -
Nov 18, 2:47 pm 2006
Junio C Hamano
Re: [WISH] Store also tag dereferences in packed-refs
Two answers. A quick one that is to the point to solve "your" problem. show-ref -d Not a quick one but that may lead to solution of a similar issue for wider audiences is... I wonder how fast update-server-info is under the same condition with your earlier timing. I am not suggesting you to use update-server-info. The reason I am wondering about it are: (1) traditionally, "peek-remote ." has been the only way to get to that information, so you have every right to keep doing ...
Nov 18, 3:04 pm 2006
Marco Costalba
Re: [WISH] Store also tag dereferences in packed-refs
I was out for dinner, just come back home. Some quick tests with show-ref -d instead of peek-remote: - git tree 2374ms - linux tree 2225ms Not a big change. I reboot before each test to have a guaranteed cold cache. Tested also with show-ref only, not useful to me, but just as a comparison. - git tree 1420ms - linux tree 1021ms Better, but still slower then what I would expected. In both case CPU load is low, processes are heavily I/O bound, so avoiding some fork does not save the ...
Nov 18, 8:28 pm 2006
Linus Torvalds
Re: [WISH] Store also tag dereferences in packed-refs
MUCH slower than expected. Can you do strace -o tracefile -Ttt git show-ref and send out the tracefile? What I _suspect_ is going on is that when you packed your refs, you either didn't prune them (which means that packing didn't actually help you), or if you did prune them, since we don't seem to remove the refs _directories_ when packing, you still have an old and big directory for .git/refs/tags, and just reading that (empty, but non-shrunken) directory takes time. The -Tt...
Nov 18, 9:11 pm 2006
Junio C Hamano
Re: [WISH] Store also tag dereferences in packed-refs
This is still a WIP and for discussion only (I have to leave to pick up my wife now so I won't be making any further progress tonight), but I think parse_object() in show-ref is costing us. One worry is that existing git will misinterpret packed-refs file prepared with this version. If you say "git show-ref -d --tags" to this version, it takes the fast path which seems to shave about 1/3 of the runtime. --- diff --git a/builtin-pack-refs.c b/builtin-pack-refs.c index 042d271..0c770f5 1006...
Nov 18, 9:40 pm 2006
Junio C Hamano
Re: [WISH] Store also tag dereferences in packed-refs
There is something seriously wrong about Marco's number with or without my patch. I am getting something like this from linux-2.6 with fully packed and pruned refs; $ /usr/bin/time git-show-ref -d >/dev/null 0.08user 0.00system 0:00.08elapsed 97%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0major+3314minor)pagefaults 0swaps $ /usr/bin/time ../git.junio/git-show-ref -d >/dev/null 0.05user 0.01system 0:00.06elapsed 98%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0maj...
Nov 18, 9:45 pm 2006
Linus Torvalds
Re: [WISH] Store also tag dereferences in packed-refs
Well, Marco is testing cold-cache numbers. But I agree, even with cold-cache, it shouldn't be anywhere close to that bad. Linus -
Nov 18, 9:59 pm 2006
Chris Riddoch
The patch documenting --pretty options (oops)
Hi, folks. I'm terribly sorry about the repost of my old patch. I fixed it, adding more information about the rest of the output formats and the 'Merge: ' line, but then accidentally reposted the original one. I hope this new version addresses your original concerns with my patch, Junio. -- epistemological humility Chris Riddoch -
Nov 18, 2:28 am 2006
Chris Riddoch
[PATCH] Move --pretty options into Documentation/pretty-form...
Asciidoc-include it into the manuals for programs that use the --pretty command-line option, for consistency among the docs. This describes all the pretty-formats currently listed in the cmit_fmt enum in commit.h, and also briefly describes the presence and format of the 'Merge: ' line in some pretty formats. Signed-off-by: Chris Riddoch <chris@syntacticsugar.org> --- Documentation/git-diff-tree.txt | 7 ++--- Documentation/git-log.txt | 3 +- Documentation/git-rev-list.txt...
Nov 18, 2:24 am 2006
Junio C Hamano
Re: [PATCH] Move --pretty options into Documentation/pretty-...
The default abbreviation depends on the command. Porcelain-ish commands default to abbreviate but plumbing commands tend to show unabbreviated. A few other things to note. - When --parents option is in effect, you will see the list of parent commits on "commit" line after the commit itself. - The list of parents shown on "Merge:" may be different from the true parents when the command's revision traversal is limited with paths parameters; they show simplified parents. This ...
Nov 18, 3:39 pm 2006
previous daytodaynext day
November 17, 2006November 18, 2006November 19, 2006