Re: [PATCH] Fix git-for-each-refs broken for tags

Previous thread: New software uploaded by Victor on Nov 18 05:00:00 MSK 2006 by Bobbi Jones on Friday, November 17, 2006 - 10:16 pm. (1 message)

Next thread: http git and curl 7.16.0 by George Sherwood on Saturday, November 18, 2006 - 12:07 am. (9 messages)
To: Junio C Hamano <junkio@...>
Cc: <git@...>
Date: Friday, November 17, 2006 - 10:56 pm

Unfortunately, git-for-each-refs is currently unusable for peeking into tag
comments, since it uses freed pointers, so it just prints out all sort of
garbage.

This makes it strdup() contents and body values.

Signed-off-by: Petr Baudis <pasky@suse.cz>
---

builtin-for-each-ref.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c
index 173bf38..227aa3c 100644
--- a/builtin-for-each-ref.c
+++ b/builtin-for-each-ref.c
@@ -478,9 +478,9 @@ static void grab_sub_body_contents(struc
if (!strcmp(name, "subject"))
v->s = copy_line(subpos);
else if (!strcmp(name, "body"))
- v->s = bodypos;
+ v->s = xstrdup(bodypos);
else if (!strcmp(name, "contents"))
- v->s = subpos;
+ v->s = xstrdup(subpos);
}
}

-

To: Petr Baudis <pasky@...>
Cc: <git@...>
Date: Saturday, November 18, 2006 - 12:45 am

Thanks for noticing.

This is not like rev-list where we walk all over the map of
ancestry graph, so it might be a simpler and better to keep
the buffer than to keep duplicate copies of pieces.

-

To: Junio C Hamano <junkio@...>
Cc: <git@...>
Date: Saturday, November 18, 2006 - 12:54 am

I would rather not do that in any new code since it's gonna be a problem
if you use this outside of the standalone command as part of libgit.

--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
The meaning of Stonehenge in Traflamadorian, when viewed from above, is:
"Replacement part being rushed with all possible speed."
-- Kurt Vonnegut, Sirens from Titan
-

Previous thread: New software uploaded by Victor on Nov 18 05:00:00 MSK 2006 by Bobbi Jones on Friday, November 17, 2006 - 10:16 pm. (1 message)

Next thread: http git and curl 7.16.0 by George Sherwood on Saturday, November 18, 2006 - 12:07 am. (9 messages)