Re: Question about commit message conventions

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andreas Ericsson
Date: Wednesday, October 25, 2006 - 8:23 am

Erik Mouw wrote:

If you sift through the Linux kernel, you will find numerous patches 
where subsystem maintainers have acked patches sent to them. I *think* 
this usually means that they have reviewed the patch and approve of it, 
but not modified it. The Ack is then solely for Linus' benefits and 
tells him that at least one pair of eyes have already gone over the patch.

Subsys maintainers sometimes also add Signed-off-by: lines, which I 
assume means they have tweaked the patch somewhat or somehow 
collaborated with the author in producing it. I know Junio signs off 
patches he modifies, and I'm guessing this habit is inherited from the 
kernel workflow which was most likely encouraged by Linus when he was 
the Git maintainer.

Lots of guesswork here, but in a sane world I can't be too far off the 
mark ;-)

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Question about commit message conventions, Tobias Toedter, (Tue Oct 24, 6:49 am)
Re: Question about commit message conventions, Erik Mouw, (Tue Oct 24, 7:08 am)
Re: Question about commit message conventions, Andreas Ericsson, (Wed Oct 25, 8:23 am)
Re: Question about commit message conventions, Junio C Hamano, (Wed Oct 25, 11:48 am)