Re: [PATCH 2/2] Remove dead code after direct graph drawing

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Josef Weidendorfer
Date: Saturday, October 21, 2006 - 8:40 am

On Saturday 21 October 2006 08:35, you wrote:

I am not really sure...
I just scrolled up and down through
the kernel repo with the page up/down keys (around 34K revisions).

On the first pass down, the memory increases by around 26 MB,
which could by correct, as you do setupData() lazy (no idea what
this function does...).
On the 2nd pass up again, I only get an increase of around 2 MB.
That could be other effects, as on further passes, I do not see
any change with pure scrolling.


Can you compare with/without my patch?
I have no idea what could have introduced any leak here. I do not
create any new class instance / structures, but only get rid of pixmap
creations/deletions.

How did you check for leaks in the past?
Did you try valgrind (memcheck or massif)?

Josef

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/2] Remove dead code after direct graph drawing, Josef Weidendorfer, (Thu Oct 19, 7:13 am)
Re: [PATCH 2/2] Remove dead code after direct graph drawing, Josef Weidendorfer, (Thu Oct 19, 4:11 pm)
Re: [PATCH 2/2] Remove dead code after direct graph drawing, Marco Costalba, (Fri Oct 20, 11:35 pm)
Re: [PATCH 2/2] Remove dead code after direct graph drawing, Josef Weidendorfer, (Sat Oct 21, 8:40 am)
Re: [PATCH 2/2] Remove dead code after direct graph drawing, Marco Costalba, (Sat Oct 21, 12:33 pm)