Home » Mailing list archives » git » 2005 » December » 4

Re: [PATCH] Add compat/setenv.c, use in git.c.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Junio C Hamano <junkio@...>
To: H. Peter Anvin <hpa@...>
Cc: Jason Riedy <ejr@...>, <git@...>
Subject: Re: [PATCH] Add compat/setenv.c, use in git.c.
Date: Sunday, December 4, 2005 - 6:24 pm

"H. Peter Anvin" <hpa@zytor.com> writes:


Perhaps, but considering that (1) this function is not something
frequently called anyway, and (2) the proposed change would make
it the first alloca() user, and (3) this is compatibility
replacement function, I'd rather choose to keep it "old, known
to work at more places" malloc/free pair, and not having to
worry about it.

But now you quote the patch, sizeof(char) looks funny.  Isn't it
always 1 by definition?


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Add compat/setenv.c, use in git.c., Jason Riedy, (Fri Dec 2, 7:08 pm)
[PATCH] compat/setenv: do not free what we fed putenv(3)., Junio C Hamano, (Sun Dec 4, 7:01 pm)
Re: [PATCH] Add compat/setenv.c, use in git.c., H. Peter Anvin, (Sun Dec 4, 5:07 pm)
Re: [PATCH] Add compat/setenv.c, use in git.c., Junio C Hamano, (Sun Dec 4, 6:31 pm)
Re: [PATCH] Add compat/setenv.c, use in git.c. , Jason Riedy, (Mon Dec 5, 2:07 pm)
Re: [PATCH] Add compat/setenv.c, use in git.c., H. Peter Anvin, (Mon Dec 5, 2:39 pm)
Re: [PATCH] Add compat/setenv.c, use in git.c., H. Peter Anvin, (Sun Dec 4, 7:34 pm)
Re: [PATCH] Add compat/setenv.c, use in git.c., Junio C Hamano, (Sun Dec 4, 6:24 pm)
Re: [PATCH] Add compat/setenv.c, use in git.c., Junio C Hamano, (Sun Dec 4, 2:26 am)