Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

quoted text
> Am I missing something? I don't see where the changes are written back to 
> the fd. After all, mmap() is called with PROT_WRITE...

PROT_WRITE is true, but we do MAP_PRIVATE, and if I recall
correctly we do not write file via mmap -- at least we do not
intend to.

 - index file is mapped for reading, long ago it was mapped
   read-only but these days we do PROT_WRITE, but updates are
   done via opening a new file and writing afresh.

 - objects are mapped for reading, but, never updated once
   created.  Creation side is regular open - write - close.

 - diff reads original by mapping, but obviously has no business
   writing.

 - local-fetch reads original by mapping for copying.

quoted text
> *shameless plug* Of course, this problem does not come up with
> my NO_MMAP patch.

Yes.  It might have been overkill that you supported writing
changes back, though.
.  

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html