login
Header Space

 
 

Re: [PATCH] Fix symbolic ref validation

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jonas Fonseca <fonseca@...>
Cc: <git@...>
Date: Wednesday, October 5, 2005 - 12:54 pm

Jonas Fonseca <fonseca@diku.dk> writes:


Thanks.

One request, not just to Jonas.  Please do not use '^---$' to
separate the introductory discussion and the real commit log
message.

Linus style (recently the kernel list had a thread on this as
well) is to have the commit log upfront with signoff, three-dash
line, optional discussion and diffstat, and then diff.

I do not mind seeing discussion upfront personally [*1*], but
the thing is the tool treats everything after the first '^---$' 
something to be fed to patch, and does not treat it as the
commit log message.


[Footnote]

*1* ...but remember, Linus does.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
First cut at git port to Cygwin, H. Peter Anvin, (Wed Sep 28, 8:53 pm)
Re: First cut at git port to Cygwin, Jonas Fonseca, (Wed Oct 5, 9:16 am)
Re: First cut at git port to Cygwin, Johannes Schindelin, (Wed Oct 5, 9:58 am)
[PATCH] Fix symbolic ref validation, Jonas Fonseca, (Wed Oct 5, 11:52 am)
Re: [PATCH] Fix symbolic ref validation, Junio C Hamano, (Wed Oct 5, 12:54 pm)
Re: First cut at git port to Cygwin, Alex Riesen, (Tue Oct 4, 8:31 am)
Re: First cut at git port to Cygwin, H. Peter Anvin, (Tue Oct 4, 11:03 am)
Re: First cut at git port to Cygwin, Alex Riesen, (Wed Oct 5, 7:24 am)
Re: First cut at git port to Cygwin, Alex Riesen, (Wed Oct 5, 11:46 am)
Re: First cut at git port to Cygwin, Christopher Faylor, (Wed Oct 5, 11:54 am)
Re: First cut at git port to Cygwin, Alex Riesen, (Wed Oct 5, 3:17 pm)
Re: First cut at git port to Cygwin, Christopher Faylor, (Wed Oct 5, 4:29 pm)
Re: First cut at git port to Cygwin, Alex Riesen, (Thu Oct 6, 5:05 am)
Re: First cut at git port to Cygwin, Alex Riesen, (Thu Oct 6, 6:07 am)
Re: First cut at git port to Cygwin, Alex Riesen, (Fri Oct 7, 8:44 am)
Re: First cut at git port to Cygwin, Linus Torvalds, (Fri Oct 7, 11:34 am)
Re: First cut at git port to Cygwin, Alex Riesen, (Fri Oct 7, 4:54 pm)
Re: First cut at git port to Cygwin, Alex Riesen, (Fri Oct 7, 5:22 pm)
Re: First cut at git port to Cygwin, Chuck Lever, (Fri Oct 7, 5:29 pm)
Re: First cut at git port to Cygwin, Alex Riesen, (Fri Oct 7, 5:39 pm)
Re: First cut at git port to Cygwin, Linus Torvalds, (Sat Oct 8, 12:11 pm)
Re: First cut at git port to Cygwin, Johannes Schindelin, (Sat Oct 8, 2:27 pm)
Re: First cut at git port to Cygwin, Alex Riesen, (Sat Oct 8, 2:49 pm)
Re: First cut at git port to Cygwin, Junio C Hamano, (Sat Oct 8, 2:44 pm)
Re: First cut at git port to Cygwin, H. Peter Anvin, (Mon Oct 10, 2:43 pm)
Re: First cut at git port to Cygwin, Johannes Schindelin, (Mon Oct 10, 3:01 pm)
Re: First cut at git port to Cygwin, Daniel Barkalow, (Mon Oct 10, 4:27 pm)
Re: First cut at git port to Cygwin, H. Peter Anvin, (Mon Oct 10, 3:26 pm)
Re: First cut at git port to Cygwin, Junio C Hamano, (Mon Oct 10, 4:34 pm)
Re: First cut at git port to Cygwin, H. Peter Anvin, (Mon Oct 10, 4:52 pm)
Re: First cut at git port to Cygwin, Junio C Hamano, (Mon Oct 10, 4:21 pm)
Re: First cut at git port to Cygwin, Johannes Schindelin, (Mon Oct 10, 3:42 pm)
Re: First cut at git port to Cygwin, Johannes Schindelin, (Sat Oct 8, 3:04 pm)
Re: First cut at git port to Cygwin, Junio C Hamano, (Sat Oct 8, 5:10 pm)
Re: First cut at git port to Cygwin, Johannes Schindelin, (Sat Oct 8, 6:06 pm)
Re: First cut at git port to Cygwin, Elfyn McBratney, (Sat Oct 8, 1:43 pm)
Re: First cut at git port to Cygwin, Elfyn McBratney, (Sat Oct 8, 1:38 pm)
Re: First cut at git port to Cygwin, Davide Libenzi, (Wed Oct 5, 12:09 pm)
Re: First cut at git port to Cygwin, Christopher Faylor, (Wed Oct 5, 12:15 pm)
Re: First cut at git port to Cygwin, Davide Libenzi, (Wed Oct 5, 1:29 pm)
Re: First cut at git port to Cygwin, H. Peter Anvin, (Wed Oct 5, 12:23 pm)
Re: First cut at git port to Cygwin, Christopher Faylor, (Wed Oct 5, 12:28 pm)
Re: First cut at git port to Cygwin, Christopher Faylor, (Tue Oct 4, 11:16 pm)
Re: First cut at git port to Cygwin, H. Peter Anvin, (Wed Oct 5, 1:25 am)
Re: First cut at git port to Cygwin, H. Peter Anvin, (Tue Oct 4, 10:06 am)
Re: First cut at git port to Cygwin, Christopher Faylor, (Tue Oct 4, 11:15 pm)
Re: First cut at git port to Cygwin, Alex Riesen, (Tue Oct 4, 9:06 am)
Re: First cut at git port to Cygwin, Johannes Schindelin, (Thu Sep 29, 4:46 am)
Re: First cut at git port to Cygwin, H. Peter Anvin, (Thu Sep 29, 1:25 pm)
Re: First cut at git port to Cygwin, H. Peter Anvin, (Thu Sep 29, 12:11 pm)
Re: First cut at git port to Cygwin, Martin Langhoff, (Thu Sep 29, 12:46 am)
Re: First cut at git port to Cygwin, H. Peter Anvin, (Thu Sep 29, 2:19 am)
Re: First cut at git port to Cygwin, Junio C Hamano, (Thu Sep 29, 1:13 am)
Re: First cut at git port to Cygwin, Junio C Hamano, (Thu Sep 29, 12:30 am)
Re: First cut at git port to Cygwin, H. Peter Anvin, (Thu Sep 29, 1:07 am)
speck-geostationary