usbnet: Set parent device early for netdev_printk()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, July 7, 2010 - 7:59 pm

Gitweb:     http://git.kernel.org/linus/0dacca73a3ddefa6cb8a7e0282f938e01faa1a64
Commit:     0dacca73a3ddefa6cb8a7e0282f938e01faa1a64
Parent:     7b00ac51ffcda994ef0839001257be894cc6e5a8
Author:     Ben Hutchings <ben@decadent.org.uk>
AuthorDate: Fri Jul 2 21:49:02 2010 -0700
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Fri Jul 2 21:49:02 2010 -0700

    usbnet: Set parent device early for netdev_printk()
    
    netdev_printk() follows the net_device's parent device pointer, so
    we must set that earlier than we previously did.
    
    Reported-by: Luís Picciochi Oliveira <pitxyoki@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/usb/usbnet.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index a95c73d..81c76ad 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1293,6 +1293,9 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
 		goto out;
 	}
 
+	/* netdev_printk() needs this so do it as early as possible */
+	SET_NETDEV_DEV(net, &udev->dev);
+
 	dev = netdev_priv(net);
 	dev->udev = xdev;
 	dev->intf = udev;
@@ -1377,8 +1380,6 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
 		dev->rx_urb_size = dev->hard_mtu;
 	dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
 
-	SET_NETDEV_DEV(net, &udev->dev);
-
 	if ((dev->driver_info->flags & FLAG_WLAN) != 0)
 		SET_NETDEV_DEVTYPE(net, &wlan_type);
 	if ((dev->driver_info->flags & FLAG_WWAN) != 0)
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
usbnet: Set parent device early for netdev_printk(), Linux Kernel Mailing ..., (Wed Jul 7, 7:59 pm)