Gitweb:     http://git.kernel.org/linus/dd1589a431e90f9ff587e640c67101a565e52bba
Commit:     dd1589a431e90f9ff587e640c67101a565e52bba
Parent:     9b2c2ff7a1c04e69842254dd4afe0f8ad4efa439
Author:     David Howells <dhowells@redhat.com>
AuthorDate: Wed Jun 30 13:10:09 2010 -0700
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Wed Jun 30 13:10:09 2010 -0700

    Bluetooth: Fix abuse of the preincrement operator
    
    Fix abuse of the preincrement operator as detected when building with gcc
    4.6.0:
    
    	 CC [M]  drivers/bluetooth/hci_bcsp.o
    	drivers/bluetooth/hci_bcsp.c: In function 'bcsp_prepare_pkt':
    	drivers/bluetooth/hci_bcsp.c:247:20: warning: operation on 'bcsp->msgq_txseq' may be undefined
    
    Reported-by: Justin P. Mattock <justinmattock@gmail.com>
    Signed-off-by: David Howells <dhowells@redhat.com>
    Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/bluetooth/hci_bcsp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
index 40aec0f..42d69d4 100644
--- a/drivers/bluetooth/hci_bcsp.c
+++ b/drivers/bluetooth/hci_bcsp.c
@@ -244,7 +244,7 @@ static struct sk_buff *bcsp_prepare_pkt(struct bcsp_struct *bcsp, u8 *data,
 	if (rel) {
 		hdr[0] |= 0x80 + bcsp->msgq_txseq;
 		BT_DBG("Sending packet with seqno %u", bcsp->msgq_txseq);
-		bcsp->msgq_txseq = ++(bcsp->msgq_txseq) & 0x07;
+		bcsp->msgq_txseq = (bcsp->msgq_txseq + 1) & 0x07;
 	}
 
 	if (bcsp->use_crc)
--

[ message continues ]