ixgbe: fix panic when shutting down system with WoL enabled

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, July 7, 2010 - 7:59 pm

Gitweb:     http://git.kernel.org/linus/fa37813401ff52d78591c262d6542e4d5d935584
Commit:     fa37813401ff52d78591c262d6542e4d5d935584
Parent:     bf988435bd5b53529f4408a8efb1f433f6ddfda9
Author:     Andy Gospodarek <andy@greyhouse.net>
AuthorDate: Tue Jun 29 18:28:12 2010 +0000
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Tue Jun 29 23:12:39 2010 -0700

    ixgbe: fix panic when shutting down system with WoL enabled
    
    This patch added to 2.6.34:
    
    	commit 5f6c01819979afbfec7e0b15fe52371b8eed87e8
    	Author: Jesse Brandeburg <jesse.brandeburg@intel.com>
    	Date:   Wed Apr 14 16:04:23 2010 -0700
    
    	    ixgbe: fix bug with vlan strip in promsic mode
    
    among other things added a function called ixgbe_vlan_filter_enable.
    This new function wants to access and set some rx_ring parameters, but
    adapter->rx_ring has already been freed.  This simply moves the free
    until after the access and makes __ixgbe_shutdown look more like
    ixgbe_remove.
    
    Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
    Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
    Tested-by: Emil Tantilov <emil.s.tantilov@intel.com>
    Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/ixgbe/ixgbe_main.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index ce30c62..e237748 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -5195,7 +5195,6 @@ static int __ixgbe_shutdown(struct pci_dev *pdev, bool *enable_wake)
 		ixgbe_free_all_tx_resources(adapter);
 		ixgbe_free_all_rx_resources(adapter);
 	}
-	ixgbe_clear_interrupt_scheme(adapter);
 
 #ifdef CONFIG_PM
 	retval = pci_save_state(pdev);
@@ -5230,6 +5229,8 @@ static int __ixgbe_shutdown(struct pci_dev *pdev, bool *enable_wake)
 
 	*enable_wake = !!wufc;
 
+	ixgbe_clear_interrupt_scheme(adapter);
+
 	ixgbe_release_hw_control(adapter);
 
 	pci_disable_device(pdev);
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
ixgbe: fix panic when shutting down system with WoL enabled, Linux Kernel Mailing ..., (Wed Jul 7, 7:59 pm)