V4L/DVB: v4l: mem2mem_testdev: fix g_fmt NULL pointer dereference

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Monday, July 12, 2010 - 4:59 pm

Gitweb:     http://git.kernel.org/linus/b6ae906b04113cb73c1ffe9c42fbcdcb074d9f07
Commit:     b6ae906b04113cb73c1ffe9c42fbcdcb074d9f07
Parent:     9c3b10b53875279306d8464fe9b24fa634329fc8
Author:     Pawel Osciak <p.osciak@samsung.com>
AuthorDate: Tue Jun 22 05:38:41 2010 -0300
Committer:  Mauro Carvalho Chehab <mchehab@redhat.com>
CommitDate: Thu Jul 8 16:50:24 2010 -0300

    V4L/DVB: v4l: mem2mem_testdev: fix g_fmt NULL pointer dereference
    
    Calling g_fmt before s_fmt resulted in a NULL pointer dereference as no
    default formats were being selected on probe.
    
    Reported-by: Németh Márton <nm127@freemail.hu>
    Signed-off-by: Pawel Osciak <p.osciak@samsung.com>
    Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---
 drivers/media/video/mem2mem_testdev.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/mem2mem_testdev.c b/drivers/media/video/mem2mem_testdev.c
index 554eaf1..10ddecc 100644
--- a/drivers/media/video/mem2mem_testdev.c
+++ b/drivers/media/video/mem2mem_testdev.c
@@ -988,6 +988,9 @@ static int m2mtest_probe(struct platform_device *pdev)
 		goto err_m2m;
 	}
 
+	q_data[V4L2_M2M_SRC].fmt = &formats[0];
+	q_data[V4L2_M2M_DST].fmt = &formats[0];
+
 	return 0;
 
 err_m2m:
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
V4L/DVB: v4l: mem2mem_testdev: fix g_fmt NULL pointer dere ..., Linux Kernel Mailing ..., (Mon Jul 12, 4:59 pm)