kbuild: Generate modules.builtin in make modules_install

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Tuesday, June 1, 2010 - 10:00 am

Gitweb:     http://git.kernel.org/linus/73d1393eb8507ed5fd7f8e696f6b1ecc18035ebe
Commit:     73d1393eb8507ed5fd7f8e696f6b1ecc18035ebe
Parent:     e93bc1a0cab3e54e3c1947e01c8e73892e35630d
Author:     Michal Marek <mmarek@suse.cz>
AuthorDate: Wed Mar 10 12:28:58 2010 +0100
Committer:  Michal Marek <mmarek@suse.cz>
CommitDate: Wed Mar 10 12:31:06 2010 +0100

    kbuild: Generate modules.builtin in make modules_install
    
    The previous approach didn't work if one did
    make modules && make modules_install
    Add modules.builtin as dependency of _modinst_, which is the target that
    actually needs the file.
    
    Reported-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Michal Marek <mmarek@suse.cz>
---
 Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 160cada..b98943a 100644
--- a/Makefile
+++ b/Makefile
@@ -1086,7 +1086,7 @@ ifdef CONFIG_MODULES
 
 # By default, build modules as well
 
-all: modules modules.builtin
+all: modules
 
 #	Build modules
 #
@@ -1104,7 +1104,7 @@ modules: $(vmlinux-dirs) $(if $(KBUILD_BUILTIN),vmlinux)
 modules.builtin: $(vmlinux-dirs:%=%/modules.builtin)
 	$(Q)$(AWK) '!x[$$0]++' $^ > $(objtree)/modules.builtin
 
-%/modules.builtin: include/config/auto.conf | modules
+%/modules.builtin: include/config/auto.conf
 	$(Q)$(MAKE) $(modbuiltin)=$*
 
 
@@ -1117,7 +1117,7 @@ PHONY += modules_install
 modules_install: _modinst_ _modinst_post
 
 PHONY += _modinst_
-_modinst_:
+_modinst_: modules.builtin
 	@if [ -z "`$(DEPMOD) -V 2>/dev/null | grep module-init-tools`" ]; then \
 		echo "Warning: you may need to install module-init-tools"; \
 		echo "See http://www.codemonkey.org.uk/docs/post-halloween-2.6.txt";\
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
kbuild: Generate modules.builtin in make modules_install, Linux Kernel Mailing ..., (Tue Jun 1, 10:00 am)