Gitweb:     http://git.kernel.org/linus/89dc0be68f4aaa06dba1b5d6ea9ecfe8fa9b7bf0
Commit:     89dc0be68f4aaa06dba1b5d6ea9ecfe8fa9b7bf0
Parent:     84e5b9f75b48fe4a1e4ee72698230701439d0805
Author:     Julia Lawall <julia@diku.dk>
AuthorDate: Thu May 27 16:29:05 2010 -0700
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Fri May 28 01:57:18 2010 -0700

    drivers/net/hamradio: Eliminate a NULL pointer dereference
    
    At the point of the print, dev is NULL.
    
    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @r exists@
    expression E,E1;
    identifier f;
    statement S1,S2,S3;
    @@
    
    if ((E == NULL && ...) || ...)
    {
      ... when != if (...) S1 else S2
          when != E = E1
    * E->f
      ... when any
      return ...;
    }
    else S3
    // </smpl>
    
    Signed-off-by: Julia Lawall <julia@diku.dk>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/hamradio/yam.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index 694132e..4e7d1d0 100644
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -1151,8 +1151,7 @@ static int __init yam_init_driver(void)
 		dev = alloc_netdev(sizeof(struct yam_port), name,
 				   yam_setup);
 		if (!dev) {
-			printk(KERN_ERR "yam: cannot allocate net device %s\n",
-			       dev->name);
+			pr_err("yam: cannot allocate net device\n");
 			err = -ENOMEM;
 			goto error;
 		}
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html