Gitweb:     http://git.kernel.org/linus/a47311380e094bb201be8a818370c73c3f52122c
Commit:     a47311380e094bb201be8a818370c73c3f52122c
Parent:     a02c37891a9b2d7ce93f9d09455b4f67c4c23b95
Author:     Eric Dumazet <eric.dumazet@gmail.com>
AuthorDate: Thu May 27 16:09:39 2010 -0700
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Fri May 28 01:57:16 2010 -0700

    net: fix __neigh_event_send()
    
    commit 7fee226ad23 (net: add a noref bit on skb dst) missed one spot
    where an skb is enqueued, with a possibly not refcounted dst entry.
    
    __neigh_event_send() inserts skb into arp_queue, so we must make sure
    dst entry is refcounted, or dst entry can be freed by garbage collector
    after caller exits from rcu protected section.
    
    Reported-by: Ingo Molnar <mingo@elte.hu>
    Tested-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/core/neighbour.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index bff3790..6ba1c0e 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -934,6 +934,7 @@ int __neigh_event_send(struct neighbour *neigh, struct sk_buff *skb)
 				kfree_skb(buff);
 				NEIGH_CACHE_STAT_INC(neigh->tbl, unres_discards);
 			}
+			skb_dst_force(skb);
 			__skb_queue_tail(&neigh->arp_queue, skb);
 		}
 		rc = 1;
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html