sctp: dubious bitfields in sctp_transport

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, May 28, 2010 - 11:59 am

Gitweb:     http://git.kernel.org/linus/ff937938e7781b2c1bffce0a5400af308e3946d5
Commit:     ff937938e7781b2c1bffce0a5400af308e3946d5
Parent:     ed0f160ad674407adb3aba499444f71c83289c63
Author:     Dan Carpenter <error27@gmail.com>
AuthorDate: Wed May 26 00:40:11 2010 -0700
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Wed May 26 00:40:11 2010 -0700

    sctp: dubious bitfields in sctp_transport
    
    Sparse complains because these one-bit bitfields are signed.
      include/net/sctp/structs.h:879:24: error: dubious one-bit signed bitfield
      include/net/sctp/structs.h:889:31: error: dubious one-bit signed bitfield
      include/net/sctp/structs.h:895:26: error: dubious one-bit signed bitfield
      include/net/sctp/structs.h:898:31: error: dubious one-bit signed bitfield
      include/net/sctp/structs.h:901:27: error: dubious one-bit signed bitfield
    
    It doesn't cause a problem in the current code, but it would be better
    to clean it up.  This was introduced by c0058a35aacc7: "sctp: Save some
    room in the sctp_transport by using bitfields".
    
    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 include/net/sctp/structs.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
index 6173c61..4b86011 100644
--- a/include/net/sctp/structs.h
+++ b/include/net/sctp/structs.h
@@ -876,7 +876,7 @@ struct sctp_transport {
 
 	/* Reference counting. */
 	atomic_t refcnt;
-	int	 dead:1,
+	__u32	 dead:1,
 		/* RTO-Pending : A flag used to track if one of the DATA
 		 *		chunks sent to this address is currently being
 		 *		used to compute a RTT. If this flag is 0,
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
sctp: dubious bitfields in sctp_transport, Linux Kernel Mailing ..., (Fri May 28, 11:59 am)