Home » Mailing list archives » git-commits-head » 2010 » May » 28

sata_mv: drop unncessary EH callback resetting

Previous thread: [IA64] Fix build breakage by Linux Kernel Mailing List on Thursday, May 27, 2010 - 6:59 pm. (1 message)

Next thread: libata-sff: ata_sff_irq_clear() is BMDMA specific by Linux Kernel Mailing List on Friday, May 28, 2010 - 11:59 am. (1 message)
[view original message]
From: Linux Kernel Mailing List
Subject: sata_mv: drop unncessary EH callback resetting
Date: Friday, May 28, 2010 - 11:59 am

Gitweb:     http://git.kernel.org/linus/2f20ccf8190b064468cb2c7ba92e757ae37e61b1
Commit:     2f20ccf8190b064468cb2c7ba92e757ae37e61b1
Parent:     ec96e2fe954c23a54bfdf2673437a39e193a1822
Author:     Tejun Heo <tj@kernel.org>
AuthorDate: Wed May 19 22:10:19 2010 +0200
Committer:  Jeff Garzik <jgarzik@redhat.com>
CommitDate: Tue May 25 19:40:15 2010 -0400

    sata_mv: drop unncessary EH callback resetting
    
    Now that BMDMA EH ops are separated out from SFF ops, mv5_ops doesn't
    have to explicitly reset ->error_handler() and ->post_internal_cmd().
    Drop them.
    
    Signed-off-by: Tejun Heo <tj@kernel.org>
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
 drivers/ata/sata_mv.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index f3471bc..16bacd3 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -675,8 +675,6 @@ static struct ata_port_operations mv5_ops = {
 	.freeze			= mv_eh_freeze,
 	.thaw			= mv_eh_thaw,
 	.hardreset		= mv_hardreset,
-	.error_handler		= ata_std_error_handler, /* avoid SFF EH */
-	.post_internal_cmd	= ATA_OP_NULL,
 
 	.scr_read		= mv5_scr_read,
 	.scr_write		= mv5_scr_write,
--


[ message continues ]
Previous thread: [IA64] Fix build breakage by Linux Kernel Mailing List on Thursday, May 27, 2010 - 6:59 pm. (1 message)

Next thread: libata-sff: ata_sff_irq_clear() is BMDMA specific by Linux Kernel Mailing List on Friday, May 28, 2010 - 11:59 am. (1 message)