x86: Handle overlapping mptables

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, April 7, 2010 - 11:59 am

Gitweb:     http://git.kernel.org/linus/909fc87b32b3b9e3f0b87dcc5d98319c41900c58
Commit:     909fc87b32b3b9e3f0b87dcc5d98319c41900c58
Parent:     9f3a5f52aa63d3aa4c64a7245153549bb66bad8c
Author:     Andi Kleen <andi@firstfloor.org>
AuthorDate: Mon Mar 29 09:41:11 2010 +0200
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Thu Apr 1 13:31:07 2010 -0700

    x86: Handle overlapping mptables
    
    We found a system where the MP table MPC and MPF structures overlap.
    
    That doesn't really matter because the mptable is not used anyways with ACPI,
    but it leads to a panic in the early allocator due to the overlapping
    reservations in 2.6.33.
    
    Earlier kernels handled this without problems.
    
    Simply change these reservations to reserve_early_overlap_ok to avoid
    the panic.
    
    Reported-by: Thomas Renninger <trenn@suse.de>
    Tested-by: Thomas Renninger <trenn@suse.de>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    LKML-Reference: <20100329074111.GA22821@basil.fritz.box>
    Signed-off-by: H. Peter Anvin <hpa@zytor.com>
    Cc: <stable@kernel.org>
---
 arch/x86/kernel/mpparse.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index a2c1edd..e81030f 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -664,7 +664,7 @@ static void __init smp_reserve_memory(struct mpf_intel *mpf)
 {
 	unsigned long size = get_mpc_size(mpf->physptr);
 
-	reserve_early(mpf->physptr, mpf->physptr+size, "MP-table mpc");
+	reserve_early_overlap_ok(mpf->physptr, mpf->physptr+size, "MP-table mpc");
 }
 
 static int __init smp_scan_config(unsigned long base, unsigned long length)
@@ -693,7 +693,7 @@ static int __init smp_scan_config(unsigned long base, unsigned long length)
 			       mpf, (u64)virt_to_phys(mpf));
 
 			mem = virt_to_phys(mpf);
-			reserve_early(mem, mem + sizeof(*mpf), "MP-table mpf");
+			reserve_early_overlap_ok(mem, mem + sizeof(*mpf), "MP-table mpf");
 			if (mpf->physptr)
 				smp_reserve_memory(mpf);
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
x86: Handle overlapping mptables, Linux Kernel Mailing ..., (Wed Apr 7, 11:59 am)