x86,kgdb: Always initialize the hw breakpoint attribute

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Sunday, April 4, 2010 - 12:59 pm

Gitweb:     http://git.kernel.org/linus/ab310b5edb8b601bcb02491ed6f7676da4fd1757
Commit:     ab310b5edb8b601bcb02491ed6f7676da4fd1757
Parent:     e49a5bd38159dfb1928fd25b173bc9de4bbadb21
Author:     Jason Wessel <jason.wessel@windriver.com>
AuthorDate: Tue Mar 30 14:05:07 2010 -0500
Committer:  Frederic Weisbecker <fweisbec@gmail.com>
CommitDate: Thu Apr 1 08:26:32 2010 +0200

    x86,kgdb: Always initialize the hw breakpoint attribute
    
    It is required to call hw_breakpoint_init() on an attr before using it
    in any other calls.  This fixes the problem where kgdb will sometimes
    fail to initialize on x86_64.
    
    Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: 2.6.33 <stable@kernel.org>
    LKML-Reference: <1269975907-27602-1-git-send-email-jason.wessel@windriver.com>
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 arch/x86/kernel/kgdb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index bfba601..b2258ca 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -618,8 +618,8 @@ int kgdb_arch_init(void)
 	 * portion of kgdb because this operation requires mutexs to
 	 * complete.
 	 */
+	hw_breakpoint_init(&attr);
 	attr.bp_addr = (unsigned long)kgdb_arch_init;
-	attr.type = PERF_TYPE_BREAKPOINT;
 	attr.bp_len = HW_BREAKPOINT_LEN_1;
 	attr.bp_type = HW_BREAKPOINT_W;
 	attr.disabled = 1;
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
x86,kgdb: Always initialize the hw breakpoint attribute, Linux Kernel Mailing ..., (Sun Apr 4, 12:59 pm)