Home » Mailing list archives » git-commits-head » 2010 » April » 30

musb_core: don't touch 'musb->clock' in musb_free()

Previous thread: omap2_mcspi: Flush posted writes by Linux Kernel Mailing List on Friday, April 30, 2010 - 10:59 am. (1 message)

Next thread: spi: spi_device memory should be released instead of device. by Linux Kernel Mailing List on Friday, April 30, 2010 - 10:59 am. (1 message)
[view original message]
From: Linux Kernel Mailing List
Subject: musb_core: don't touch 'musb->clock' in musb_free()
Date: Friday, April 30, 2010 - 10:59 am

Gitweb:     http://git.kernel.org/linus/1fb48f4a96ef3d4eee0a13b92a3e8489171b47c9
Commit:     1fb48f4a96ef3d4eee0a13b92a3e8489171b47c9
Parent:     714bc5ef3edaec3ca0cf155fe01411760527c52e
Author:     Sergei Shtylyov <sshtylyov@ru.mvista.com>
AuthorDate: Thu Mar 25 13:14:28 2010 +0200
Committer:  Greg Kroah-Hartman <gregkh@suse.de>
CommitDate: Fri Apr 30 09:25:08 2010 -0700

    musb_core: don't touch 'musb->clock' in musb_free()
    
    Remove duplicate/unbalanced calls to clk_disable()/clk_put() in musb_free():
    
    - clk_disable() is called by musb_platform_exit() just prior to this call;
    - clk_put() is called by the callers of musb_free() prior to calling it...
    
    Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/usb/musb/musb_core.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 3342b82..03544de 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -1857,11 +1857,6 @@ static void musb_free(struct musb *musb)
 	musb_platform_exit(musb);
 	musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
 
-	if (musb->clock) {
-		clk_disable(musb->clock);
-		clk_put(musb->clock);
-	}
-
 #ifdef CONFIG_USB_MUSB_HDRC_HCD
 	usb_put_hcd(musb_to_hcd(musb));
 #else
--


[ message continues ]
Previous thread: omap2_mcspi: Flush posted writes by Linux Kernel Mailing List on Friday, April 30, 2010 - 10:59 am. (1 message)

Next thread: spi: spi_device memory should be released instead of device. by Linux Kernel Mailing List on Friday, April 30, 2010 - 10:59 am. (1 message)