Home » Mailing list archives » git-commits-head » 2010 » April » 30

MUSB: DaVinci: fix musb_platform_init() error cleanup path

Previous thread: staging: iio: ring_sw: Fix incorrect test on successful read of last value, causes infinite loop by Linux Kernel Mailing List on Friday, April 30, 2010 - 10:59 am. (1 message)

Next thread: staging: rtl8192su: add Support for Belkin F5D8053 v6 by Linux Kernel Mailing List on Friday, April 30, 2010 - 10:59 am. (1 message)
[view original message]
From: Linux Kernel Mailing List
Subject: MUSB: DaVinci: fix musb_platform_init() error cleanup path
Date: Friday, April 30, 2010 - 10:59 am

Gitweb:     http://git.kernel.org/linus/13962c747915e4d7ef4cf92c36bd06a7fe648f0b
Commit:     13962c747915e4d7ef4cf92c36bd06a7fe648f0b
Parent:     3d0bfbf25957e04354389047f0e6ba520d58487c
Author:     Sergei Shtylyov <sshtylyov@ru.mvista.com>
AuthorDate: Thu Mar 25 13:14:30 2010 +0200
Committer:  Greg Kroah-Hartman <gregkh@suse.de>
CommitDate: Fri Apr 30 09:25:08 2010 -0700

    MUSB: DaVinci: fix musb_platform_init() error cleanup path
    
    This function forgets to call clk_disable() iff reading the USB module version
    register returns 0.
    
    Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/usb/musb/davinci.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/davinci.c
index 29bce5c..ce2e16f 100644
--- a/drivers/usb/musb/davinci.c
+++ b/drivers/usb/musb/davinci.c
@@ -444,6 +444,8 @@ int __init musb_platform_init(struct musb *musb)
 	return 0;
 
 fail:
+	clk_disable(musb->clock);
+
 	usb_nop_xceiv_unregister();
 	return -ENODEV;
 }
--


[ message continues ]
Previous thread: staging: iio: ring_sw: Fix incorrect test on successful read of last value, causes infinite loop by Linux Kernel Mailing List on Friday, April 30, 2010 - 10:59 am. (1 message)

Next thread: staging: rtl8192su: add Support for Belkin F5D8053 v6 by Linux Kernel Mailing List on Friday, April 30, 2010 - 10:59 am. (1 message)