Home » Mailing list archives » git-commits-head » 2010 » April » 28

drbd: fix memory leak

Previous thread: tg3: Fix INTx fallback when MSI fails by Linux Kernel Mailing List on Wednesday, April 28, 2010 - 1:59 pm. (1 message)

Next thread: pcmcia: pcmcia_dev_present bugfix by Linux Kernel Mailing List on Wednesday, April 28, 2010 - 1:59 pm. (1 message)
[view original message]
From: Linux Kernel Mailing List
Subject: drbd: fix memory leak
Date: Wednesday, April 28, 2010 - 1:59 pm

Gitweb:     http://git.kernel.org/linus/7ac314c82f552eefebaa91c9fffe8c0d435641b9
Commit:     7ac314c82f552eefebaa91c9fffe8c0d435641b9
Parent:     6de9400250f95f82da432c28b9b43823f4154c58
Author:     Dan Carpenter <error27@gmail.com>
AuthorDate: Thu Apr 22 14:27:23 2010 +0200
Committer:  Jens Axboe <jens.axboe@oracle.com>
CommitDate: Thu Apr 22 14:27:23 2010 +0200

    drbd: fix memory leak
    
    We leak memory if "--dry-run" is not supported by the peer.
    
    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
---
 drivers/block/drbd/drbd_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 67e0fc5..93d1f9b 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -1695,6 +1695,7 @@ int drbd_send_protocol(struct drbd_conf *mdev)
 			cf |= CF_DRY_RUN;
 		else {
 			dev_err(DEV, "--dry-run is not supported by peer");
+			kfree(p);
 			return 0;
 		}
 	}
--


[ message continues ]
Previous thread: tg3: Fix INTx fallback when MSI fails by Linux Kernel Mailing List on Wednesday, April 28, 2010 - 1:59 pm. (1 message)

Next thread: pcmcia: pcmcia_dev_present bugfix by Linux Kernel Mailing List on Wednesday, April 28, 2010 - 1:59 pm. (1 message)