drm/i915: Attempt to fix watermark setup on 85x (v2)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Thursday, April 22, 2010 - 6:59 pm

Gitweb:     http://git.kernel.org/linus/8f4695ed1c9e068772bcce4cd4ff03f88d57a008
Commit:     8f4695ed1c9e068772bcce4cd4ff03f88d57a008
Parent:     13bd8e4673d527a9e48f41956b11d391e7c2cfe0
Author:     Adam Jackson <ajax@redhat.com>
AuthorDate: Fri Apr 16 18:20:57 2010 -0400
Committer:  Eric Anholt <eric@anholt.net>
CommitDate: Sun Apr 18 16:52:56 2010 -0700

    drm/i915: Attempt to fix watermark setup on 85x (v2)
    
    IS_MOBILE() catches 85x, so we'd always try to use the 9xx FIFO sizing;
    since there's an explicit 85x version, this seems wrong.
    
    v2: Handle 830m correctly too.
    
    Signed-off-by: Adam Jackson <ajax@redhat.com>
    Reviewed-by: Eric Anholt <eric@anholt.net>
    Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/i915/intel_display.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index e7356fb..c7502b6 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4853,17 +4853,18 @@ static void intel_init_display(struct drm_device *dev)
 		dev_priv->display.update_wm = g4x_update_wm;
 	else if (IS_I965G(dev))
 		dev_priv->display.update_wm = i965_update_wm;
-	else if (IS_I9XX(dev) || IS_MOBILE(dev)) {
+	else if (IS_I9XX(dev)) {
 		dev_priv->display.update_wm = i9xx_update_wm;
 		dev_priv->display.get_fifo_size = i9xx_get_fifo_size;
+	} else if (IS_I85X(dev)) {
+		dev_priv->display.update_wm = i9xx_update_wm;
+		dev_priv->display.get_fifo_size = i85x_get_fifo_size;
 	} else {
-		if (IS_I85X(dev))
-			dev_priv->display.get_fifo_size = i85x_get_fifo_size;
-		else if (IS_845G(dev))
+		dev_priv->display.update_wm = i830_update_wm;
+		if (IS_845G(dev))
 			dev_priv->display.get_fifo_size = i845_get_fifo_size;
 		else
 			dev_priv->display.get_fifo_size = i830_get_fifo_size;
-		dev_priv->display.update_wm = i830_update_wm;
 	}
 }
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
drm/i915: Attempt to fix watermark setup on 85x (v2), Linux Kernel Mailing ..., (Thu Apr 22, 6:59 pm)