eCryptfs: Copy lower directory inode times and size on link

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Monday, April 19, 2010 - 4:59 pm

Gitweb:     http://git.kernel.org/linus/3a8380c0754a7972668a46f645930910e304095c
Commit:     3a8380c0754a7972668a46f645930910e304095c
Parent:     133b8f9d632cc23715c6d72d1c5ac449e054a12a
Author:     Tyler Hicks <tyhicks@linux.vnet.ibm.com>
AuthorDate: Tue Mar 23 18:09:02 2010 -0500
Committer:  Tyler Hicks <tyhicks@linux.vnet.ibm.com>
CommitDate: Mon Apr 19 14:42:15 2010 -0500

    eCryptfs: Copy lower directory inode times and size on link
    
    The timestamps and size of a lower inode involved in a link() call was
    being copied to the upper parent inode.  Instead, we should be
    copying lower parent inode's timestamps and size to the upper parent
    inode.  I discovered this bug using the POSIX test suite at Tuxera.
    
    Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
---
 fs/ecryptfs/inode.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index efd4f47..15b4248 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -456,8 +456,8 @@ static int ecryptfs_link(struct dentry *old_dentry, struct inode *dir,
 	rc = ecryptfs_interpose(lower_new_dentry, new_dentry, dir->i_sb, 0);
 	if (rc)
 		goto out_lock;
-	fsstack_copy_attr_times(dir, lower_new_dentry->d_inode);
-	fsstack_copy_inode_size(dir, lower_new_dentry->d_inode);
+	fsstack_copy_attr_times(dir, lower_dir_dentry->d_inode);
+	fsstack_copy_inode_size(dir, lower_dir_dentry->d_inode);
 	old_dentry->d_inode->i_nlink =
 		ecryptfs_inode_to_lower(old_dentry->d_inode)->i_nlink;
 	i_size_write(new_dentry->d_inode, file_size_save);
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
eCryptfs: Copy lower directory inode times and size on link, Linux Kernel Mailing ..., (Mon Apr 19, 4:59 pm)