forcedeth: fix tx limit2 flag check

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Monday, April 19, 2010 - 8:59 am

Gitweb:     http://git.kernel.org/linus/5c659322a904a7cc0265e7b183372b9bdebec6db
Commit:     5c659322a904a7cc0265e7b183372b9bdebec6db
Parent:     a6d37024de02e7cb2b2333e438e71355a9c32a0a
Author:     Ayaz Abdulla <aabdulla@nvidia.com>
AuthorDate: Tue Apr 13 18:49:51 2010 -0700
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Tue Apr 13 18:49:51 2010 -0700

    forcedeth: fix tx limit2 flag check
    
    This is a fix for bug 572201 @ bugs.debian.org
    
    This patch fixes the TX_LIMIT feature flag. The previous logic check
    for TX_LIMIT2 also took into account a device that only had TX_LIMIT
    set.
    
    Reported-by: Stephen Mulcahu <stephen.mulcahy@deri.org>
    Reported-by: Ben Huchings <ben@decadent.org.uk>
    Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/forcedeth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index 73b260c..5c98f7c 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -5899,7 +5899,7 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
 	/* Limit the number of tx's outstanding for hw bug */
 	if (id->driver_data & DEV_NEED_TX_LIMIT) {
 		np->tx_limit = 1;
-		if ((id->driver_data & DEV_NEED_TX_LIMIT2) &&
+		if (((id->driver_data & DEV_NEED_TX_LIMIT2) == DEV_NEED_TX_LIMIT2) &&
 		    pci_dev->revision >= 0xA2)
 			np->tx_limit = 0;
 	}
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
forcedeth: fix tx limit2 flag check, Linux Kernel Mailing ..., (Mon Apr 19, 8:59 am)