x86/amd-iommu: Remove double NULL check in check_device

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Thursday, April 15, 2010 - 1:59 pm

Gitweb:     http://git.kernel.org/linus/339d3261aa3eb0e12f68ef868e042c1ca03628f7
Commit:     339d3261aa3eb0e12f68ef868e042c1ca03628f7
Parent:     60b341b778cc2929df16c0a504c91621b3c6a4ad
Author:     Julia Lawall <julia@diku.dk>
AuthorDate: Sat Feb 6 09:42:39 2010 +0100
Committer:  Joerg Roedel <joerg.roedel@amd.com>
CommitDate: Mon Mar 1 13:24:45 2010 +0100

    x86/amd-iommu: Remove double NULL check in check_device
    
    dev was tested just above, so drop the second test.
    
    Signed-off-by: Julia Lawall <julia@diku.dk>
    Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kernel/amd_iommu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index adb0ba0..2c4a501 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -118,7 +118,7 @@ static bool check_device(struct device *dev)
 		return false;
 
 	/* No device or no PCI device */
-	if (!dev || dev->bus != &pci_bus_type)
+	if (dev->bus != &pci_bus_type)
 		return false;
 
 	devid = get_device_id(dev);
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
x86/amd-iommu: Remove double NULL check in check_device, Linux Kernel Mailing ..., (Thu Apr 15, 1:59 pm)