hwmon: (sht15) Properly handle the case CONFIG_REGULATOR=n

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, April 14, 2010 - 6:59 pm

Gitweb:     http://git.kernel.org/linus/c7a78d2c2e2537fd24903e966f34aae50319d587
Commit:     c7a78d2c2e2537fd24903e966f34aae50319d587
Parent:     328a2c22abd08911e37fa66f1358f829cecd72e9
Author:     Jean Delvare <khali@linux-fr.org>
AuthorDate: Wed Apr 14 16:14:08 2010 +0200
Committer:  Jean Delvare <khali@linux-fr.org>
CommitDate: Wed Apr 14 16:14:08 2010 +0200

    hwmon: (sht15) Properly handle the case CONFIG_REGULATOR=n
    
    When CONFIG_REGULATOR isn't set, regulator_get_voltage() returns 0.
    Properly handle this case by not trusting the value.
    
    Reported-by: Jerome Oufella <jerome.oufella@savoirfairelinux.com>
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Cc: Jonathan Cameron <jic23@cam.ac.uk>
    Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Cc: stable@kernel.org
---
 drivers/hwmon/sht15.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c
index 9a15b1a..a610e78 100644
--- a/drivers/hwmon/sht15.c
+++ b/drivers/hwmon/sht15.c
@@ -542,7 +542,12 @@ static int __devinit sht15_probe(struct platform_device *pdev)
 /* If a regulator is available, query what the supply voltage actually is!*/
 	data->reg = regulator_get(data->dev, "vcc");
 	if (!IS_ERR(data->reg)) {
-		data->supply_uV = regulator_get_voltage(data->reg);
+		int voltage;
+
+		voltage = regulator_get_voltage(data->reg);
+		if (voltage)
+			data->supply_uV = voltage;
+
 		regulator_enable(data->reg);
 		/* setup a notifier block to update this if another device
 		 *  causes the voltage to change */
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
hwmon: (sht15) Properly handle the case CONFIG_REGULATOR=n, Linux Kernel Mailing ..., (Wed Apr 14, 6:59 pm)