lguest: workaround cmpxchg8b_emu by ignoring cli in the guest.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, April 14, 2010 - 6:59 pm

Gitweb:     http://git.kernel.org/linus/5094aeafbbd500509f648e3cd102b053bc7926b3
Commit:     5094aeafbbd500509f648e3cd102b053bc7926b3
Parent:     2ba3abd8186f24c7fb418927025b4e2120e3a362
Author:     Rusty Russell <rusty@rustcorp.com.au>
AuthorDate: Wed Apr 14 21:43:53 2010 -0600
Committer:  Rusty Russell <rusty@rustcorp.com.au>
CommitDate: Wed Apr 14 21:43:54 2010 +0930

    lguest: workaround cmpxchg8b_emu by ignoring cli in the guest.
    
    It's only used by cmpxchg8b_emu (see db677ffa5f5a for the gory
    details), and fixing that to be paravirt aware would be more work than
    simply ignoring it (and AFAICT only help lguest).  This makes lguest
    work on machines which have cmpxchg8b, for kernels compiled for older
    processors.
    
    (We can't emulate it properly: the popf which expects to restore interrupts
    does not trap).
    
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    Cc: Jeremy Fitzhardinge <jeremy@xensource.com>
    Cc: virtualization@lists.osdl.org
---
 drivers/lguest/x86/core.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/drivers/lguest/x86/core.c b/drivers/lguest/x86/core.c
index fb2b7ef..b4eb675 100644
--- a/drivers/lguest/x86/core.c
+++ b/drivers/lguest/x86/core.c
@@ -288,6 +288,18 @@ static int emulate_insn(struct lg_cpu *cpu)
 	insn = lgread(cpu, physaddr, u8);
 
 	/*
+	 * Around 2.6.33, the kernel started using an emulation for the
+	 * cmpxchg8b instruction in early boot on many configurations.  This
+	 * code isn't paravirtualized, and it tries to disable interrupts.
+	 * Ignore it, which will Mostly Work.
+	 */
+	if (insn == 0xfa) {
+		/* "cli", or Clear Interrupt Enable instruction.  Skip it. */
+		cpu->regs->eip++;
+		return 1;
+	}
+
+	/*
 	 * 0x66 is an "operand prefix".  It means it's using the upper 16 bits
 	 * of the eax register.
 	 */
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
lguest: workaround cmpxchg8b_emu by ignoring cli in the guest., Linux Kernel Mailing ..., (Wed Apr 14, 6:59 pm)