Staging: comedi: cb_pcimdda.c: Checkpatch cleanup

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Sunday, March 7, 2010 - 6:03 pm

Gitweb:     http://git.kernel.org/linus/f1c54e82726fe51a55a18d15dc9377b8fd568ca2
Commit:     f1c54e82726fe51a55a18d15dc9377b8fd568ca2
Parent:     7c2f1946a5d41da3cfc1696944aaa420db5b5145
Author:     Andrea Gelmini <andrea.gelmini@gelma.net>
AuthorDate: Fri Feb 26 10:15:03 2010 +0100
Committer:  Greg Kroah-Hartman <gregkh@suse.de>
CommitDate: Wed Mar 3 16:43:06 2010 -0800

    Staging: comedi: cb_pcimdda.c: Checkpatch cleanup
    
    WARNING: braces {} are not necessary for any arm of this statement
    +	if (it->options[2]) {
    [...]
    +	} else {
    [...]
    
    WARNING: braces {} are not necessary for single statement blocks
    +			if (devpriv->registers) {
    +				comedi_pci_disable(devpriv->pci_dev);
    +			}
    
    Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/staging/comedi/drivers/cb_pcimdda.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/cb_pcimdda.c b/drivers/staging/comedi/drivers/cb_pcimdda.c
index 980fa0a..e32a317 100644
--- a/drivers/staging/comedi/drivers/cb_pcimdda.c
+++ b/drivers/staging/comedi/drivers/cb_pcimdda.c
@@ -284,11 +284,10 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
 	s->n_chan = thisboard->ao_chans;
 	s->maxdata = figure_out_maxdata(thisboard->ao_bits);
 	/* this is hard-coded here */
-	if (it->options[2]) {
+	if (it->options[2])
 		s->range_table = &range_bipolar10;
-	} else {
+	else
 		s->range_table = &range_bipolar5;
-	}
 	s->insn_write = &ao_winsn;
 	s->insn_read = &ao_rinsn;
 
@@ -337,9 +336,8 @@ static int detach(struct comedi_device *dev)
 		}
 
 		if (devpriv->pci_dev) {
-			if (devpriv->registers) {
+			if (devpriv->registers)
 				comedi_pci_disable(devpriv->pci_dev);
-			}
 			pci_dev_put(devpriv->pci_dev);
 		}
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Staging: comedi: cb_pcimdda.c: Checkpatch cleanup, Linux Kernel Mailing ..., (Sun Mar 7, 6:03 pm)