Gitweb: http://git.kernel.org/linus/4881a4f89a95cc5fef6d32953954bcc3443eefd5
Commit: 4881a4f89a95cc5fef6d32953954bcc3443eefd5
Parent: 8e039d84b323c4503c4d56863faa47c783660826
Author: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
AuthorDate: Tue Mar 23 04:23:50 2010 +0000
Committer: David S. Miller <davem@davemloft.net>
CommitDate: Tue Mar 23 13:06:15 2010 -0700
ksz884x: fix return value of netdev_set_eeprom
ksz884x: fix return value of netdev_set_eeprom
netdev_set_eeprom() confused ethtool by just returning 1 on error
instead of a proper -EINVAL.
Signed-off-by: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/ksz884x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ksz884x.c b/drivers/net/ksz884x.c
index 0f59099..6c5327a 100644
--- a/drivers/net/ksz884x.c
+++ b/drivers/net/ksz884x.c
@@ -6322,7 +6322,7 @@ static int netdev_set_eeprom(struct net_device *dev,
int len;
if (eeprom->magic != EEPROM_MAGIC)
- return 1;
+ return -EINVAL;
len = (eeprom->offset + eeprom->len + 1) / 2;
for (i = eeprom->offset / 2; i < len; i++)
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
