USB: serial: fix error message on close in generic driver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, March 19, 2010 - 1:59 pm

Gitweb:     http://git.kernel.org/linus/0ae1474367a15e1b65a9deed3a73a14475a419fc
Commit:     0ae1474367a15e1b65a9deed3a73a14475a419fc
Parent:     7152b592593b9d48b33f8997b1dfd6df9143f7ec
Author:     Johan Hovold <jhovold@gmail.com>
AuthorDate: Sat Feb 27 14:05:46 2010 +0100
Committer:  Greg Kroah-Hartman <gregkh@suse.de>
CommitDate: Fri Mar 19 07:24:02 2010 -0700

    USB: serial: fix error message on close in generic driver
    
    Resubmitting read urb fails with -EPERM if completion handler runs while
    urb is being killed on close. This should not be reported as an error.
    
    Signed-off-by: Johan Hovold <jhovold@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/usb/serial/generic.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 89fac36..e560d1d 100644
--- a/drivers/usb/serial/generic.c
+++ b/drivers/usb/serial/generic.c
@@ -415,11 +415,13 @@ void usb_serial_generic_resubmit_read_urb(struct usb_serial_port *port,
 			   ((serial->type->read_bulk_callback) ?
 			     serial->type->read_bulk_callback :
 			     usb_serial_generic_read_bulk_callback), port);
+
 	result = usb_submit_urb(urb, mem_flags);
-	if (result)
+	if (result && result != -EPERM) {
 		dev_err(&port->dev,
 			"%s - failed resubmitting read urb, error %d\n",
 							__func__, result);
+	}
 }
 EXPORT_SYMBOL_GPL(usb_serial_generic_resubmit_read_urb);
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
USB: serial: fix error message on close in generic driver, Linux Kernel Mailing ..., (Fri Mar 19, 1:59 pm)